[FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value

[FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value

[Michael Niedermayer]

Fixes: CID1397741 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavfilter/avfiltergraph.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c
index 0c569eb218e..4eeaa33d5e9 100644
--- a/libavfilter/avfiltergraph.c
+++ b/libavfilter/avfiltergraph.c
@@ -1410,7 +1410,7 @@ int avfilter_graph_request_oldest(AVFilterGraph *graph)
         if (r == AVERROR(EAGAIN) &&
             !oldest->frame_wanted_out && !oldesti->frame_blocked_in &&
             !oldesti->status_in)
-            ff_request_frame(oldest);
+            ff_request_frame(oldest); // return value is intentionally ignored
         else if (r < 0)
             return r;
     }
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value

[Andreas Rheinhardt]

Michael Niedermayer:
> Fixes: CID1397741 Unchecked return value
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavfilter/avfiltergraph.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c
> index 0c569eb218e..4eeaa33d5e9 100644
> --- a/libavfilter/avfiltergraph.c
> +++ b/libavfilter/avfiltergraph.c
> @@ -1410,7 +1410,7 @@ int avfilter_graph_request_oldest(AVFilterGraph *graph)
>          if (r == AVERROR(EAGAIN) &&
>              !oldest->frame_wanted_out && !oldesti->frame_blocked_in &&
>              !oldesti->status_in)
> -            ff_request_frame(oldest);
> +            ff_request_frame(oldest); // return value is intentionally ignored
>          else if (r < 0)
>              return r;
>      }

Isn't the typical way to signal this to cast the return value to void?

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1322 bytes --]

On Tue, Apr 30, 2024 at 09:14:16AM +0200, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > Fixes: CID1397741 Unchecked return value
> > 
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavfilter/avfiltergraph.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c
> > index 0c569eb218e..4eeaa33d5e9 100644
> > --- a/libavfilter/avfiltergraph.c
> > +++ b/libavfilter/avfiltergraph.c
> > @@ -1410,7 +1410,7 @@ int avfilter_graph_request_oldest(AVFilterGraph *graph)
> >          if (r == AVERROR(EAGAIN) &&
> >              !oldest->frame_wanted_out && !oldesti->frame_blocked_in &&
> >              !oldesti->status_in)
> > -            ff_request_frame(oldest);
> > +            ff_request_frame(oldest); // return value is intentionally ignored
> >          else if (r < 0)
> >              return r;
> >      }
> 
> Isn't the typical way to signal this to cast the return value to void?

yes, i will push that change instead

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".