From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9B5404A434 for ; Tue, 30 Apr 2024 07:14:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 325B168C4E3; Tue, 30 Apr 2024 10:14:27 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2055.outbound.protection.outlook.com [40.92.73.55]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D6A268D602 for ; Tue, 30 Apr 2024 10:14:21 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HsIJwrnlcX/9LTG1GFEufW2cIMzn0rN8ScztmJGwdIp/4MT6nmZrwTvPDNuGqx5/G/bk7tWmp+bLXmUX1lFnjZuBO3D4PSyrm8ExbF2dZAuVxsAt+WdIUJyiFMYHYkQ7eD5G6eoyfVNc9xWZDkyVVLg9hf5qWs1fwBCQH3D00QoXK4cMqK5YE3QDuwcee6nO4y1e+NZXX+elauEZYhHDYfUqE4/Tv1qnenG/3tMpE/GBsFgfnnhzu44VzdPmnlGGVdFlpk9lCCRCFDkcp5RYZx1h2Yc3YLe79PFPV1RLZ6oU7TNJojqa7MPFVA8ybO8bqZzEPSD4GuXFayINJseXXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l76v8vZZKJKjsfc39lt6srqxbGnjfXrHvLEqDHpel0Q=; b=LT50pIq955QT2w7PogVih6ff3vQZ/1iOdQCUUs5wH6lF3w0kbdU2vgStzMLjE6Shu281p9QvdBJT4HSB3X2hc+TF8VQi7F+D+v/JVtJ5gVXhcx7IwjH7jKa+h1ZHUGFpkLd5QsPVoy3ipG49zqu8k0U2W4LOEriYPwz+J6yhE6A6gtlssZ/b2cUbPI6swkviM0FM+0TcXdFnXqBA/8VSdGQk5bVlyST2jmJW/0u0KTvkC5nL7vNat6DBbEWZMZUoQ71BVSkA90tOWEcL8ruKpEQ9fWNeCPzw9CS/FLb28ILVk6IdlLhKJhO2O9QDQhFVPrwhr6dBIzT/O/Cv/4k8vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l76v8vZZKJKjsfc39lt6srqxbGnjfXrHvLEqDHpel0Q=; b=nllzpOtNXomMP00CXq1Pmc/hjhoUcEba1AW6TLu0gSS2v+r2KyOEeV9HLtw8os56Qs6NsV1at5iaQoO/DWFNUjyYc+HQcd5AK14YZ5TYzEzomfqOLk8QPMY7NiSmv5pGNEX9qaici72z6PVCKdb/sLiNqyhku9TQkyDi3A67IsUMNcTIFw7D/9w0TAOtCaXaJ0gzw976YDmhC2Yg71SuKS8OBReTNiQC6hBGuT2AUv/l24kdgTrrhy/IwlzIeQ7rivfRbLkakReTNCr3GO+SVj4KHd6CjQZS3wvANY/jbn8xbS9hs5BBco3p1dnsQZXtLuDjaq0nxFWIcKUzmUgYDg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0122.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:36d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Tue, 30 Apr 2024 07:14:19 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7519.031; Tue, 30 Apr 2024 07:14:19 +0000 Message-ID: Date: Tue, 30 Apr 2024 09:14:16 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240422005351.4179419-1-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240422005351.4179419-1-michael@niedermayer.cc> X-TMN: [vMwAow97ufHnnX0tNbrWcwff5ghoBUD+iZqs9uBcups=] X-ClientProxiedBy: ZRAP278CA0012.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::22) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <78f54c25-0150-4885-a54e-46b328b67845@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0122:EE_ X-MS-Office365-Filtering-Correlation-Id: 399c8eb9-41ea-4674-aaf8-08dc68e52729 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: cnyaRWjjjZUPhMNhZKEYrc6wuxspBUoJmNIcFWDnKLnv4fKFjXGBTYEt5fNpmH+uKXx3HMcJtyS9xVMKx+A/dID78pBZjZ2Z3HvVWKQAAUO2tzt+VLU+ZhyZ/M/pOW4MV6TyhFcdK0kXmOAdD+aQutxhP5ilR9mOuGKtjb1cvZZMgsWPNRSSguHU3Uagta4BBnl8aVb+Z1pT8iV2ihyh2CSE0cPAlhi2nDxQtJxzLhl6gdn8MreZnj9kq5+SDqV8pmpWaw2B9IClYG49iOM/Eabf6wWs2PKwqaHOPnAv3Uq9w0kyXUdyxVKDdRrfc/0XW7d+22wcUrOo6ntWS5IWh6gomNaPWrygH9R9uXBM6V+C/jxOgCbiqBK9ZVDNdc8kZrpljQUvm9DB8Vut1WvaKeYjIZQDOtYTWIeygF3lAm+AsFCzz7kf0fCTda9+/WurPu5GSbwyM1E45zLaduxi/qa3XQOKRc07Fi4x8/nAWdrH+joVN9StA+h5cZ9mbruxp74DGQRluvbsxekGV3pp/YaGxvqq2epVuRmgEuDmiX6wbML4deDnueQks4Z8fORK X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0RjazVpN21uYjBVOW9vYnhxcENXbzhEcDhENFJEUXlPcDREZnNlQm4yeS9O?= =?utf-8?B?UFRFb3cyT01iMkVSK1kza1dnOUJKSnpNeUVDajRIOGdJTUY3N2JkWFhySHBG?= =?utf-8?B?dmVrOGNuSE11VThqLzRFbk5YdzlnVUptZ0wrM1FRVzlsMXZSa3VvaTF0K1R4?= =?utf-8?B?WE9TdkZuaDk1WU5xMW1zNFJqa2NvSWJnblFDQ0NHUURpRVp4MHVweG5UV1Fv?= =?utf-8?B?OW13ZmRJNlpMUDJmNnNDa3ZsNnhyOWpOeHMyZmN6c0Q3bnBGVmdvUGMzRk1W?= =?utf-8?B?bktJajVvbnNOTUJWMW02M0JsYUFKSVBDMy9LOXBhQXpLUEkrbTZiOTRXd05k?= =?utf-8?B?UWpwYVdURHlDRytsRjYxL3pSYUpzQjd5MVVJMy9JRElHN3FYUjh0QzlONk9a?= =?utf-8?B?Qm9RRUZ0VlV1amYxbjVIdGlyQVV3a21LWm42a1VvWG9PN3FYVjM5cXhVcVRL?= =?utf-8?B?WDJucUk2YXgzblBRQks2UmJINkhxVXo3OTFKTUx1WDYxWCtEay90WkxvSC93?= =?utf-8?B?TGh1WjkzZ1A4eUR4bEtzTURSZ2xKdktLL2Nyd3NSMXM1bWI4UENHTHk4c3pM?= =?utf-8?B?a09GVitGVWJZaWd4ZUN5dmlTTzE4Tk9vSk9LZk1rcG5zMmNQYk9qSk8yaUN4?= =?utf-8?B?eEZ0NzJ3VG1wZWpYc0dodlVpV0Q2V2tKQmkweWNJRW9xekVkVTZuZkZHV3lK?= =?utf-8?B?UHZQTS84NTFocktxd0pZMy9qZzJyUVB5TlJhK25uaHRJd0pqWU85MG5NYVQ5?= =?utf-8?B?dm1ER2kxbGg3YmhsWkpxVE1xM3lmaks0WDArQVpoK1NJRHJLQzIvUlZBendZ?= =?utf-8?B?VWsrRHdJdDBJalQwMnFVZUdtZHRxU0ROSEkzdC9XdENRbzFyTG42VkxQZ1hT?= =?utf-8?B?eXhmM3NhQkdzZmR1ZU1YRGdQTGNqeTNrMjNRWmpDclZkUzk0cEwzQU82NW9C?= =?utf-8?B?KzhXTURNMkd1V0tuNzdLYkNydiszYnRTUTdkZVJGOXcyY0M5L1Q2V2NhY0RW?= =?utf-8?B?alBFN0ZaU1U5YjdTVWZmQm1veDlIa3pGWEhqZVg1eER0S0FuMmNSQ1dJdlR2?= =?utf-8?B?V04waFhwRHpqdDNYc2xYN2ZOSWZwMUVoMEdxaWhhZzRaWHRUT3lvTWZVa2xR?= =?utf-8?B?SFNrVkx4SWxTRWhueDh4YzEzdlh2bkd6ak01UHJybi9PaGN6a3daT3hITTNq?= =?utf-8?B?b05kRWpiVEVaQWNydGdqdmxPdUdxb01OMlFlR1BvSXNROHFGMzBkcEtQNUNh?= =?utf-8?B?am1adURlWTM2SFBkZVJLSGE3QlZpdE5ONlIzSlR0V1pmeCtzV0dtL1VjVHNE?= =?utf-8?B?dnYya3lBUitUSWpvOTNrZ04zY2VLUExkRW5iL3BGYjlJYzRkN3RnbDIvY01u?= =?utf-8?B?RU9NcElBR3M3T3hlNG9vMUgrU2hmK05VUHh2clFJRTRRNkcvRndNZXU4Sks3?= =?utf-8?B?MldwbTJEZGVsVVhqem5rQ1Rvdm5USnFUSDNmNThEa2FxKys2M2gvRDZJZ3Fo?= =?utf-8?B?cnU5SGdocUVmUXJYVWxKV2dDZ0tBcVlJZFdQUThvK1h1b2plZTM5R3g4SUZQ?= =?utf-8?B?UWZ0NlNvRnRHZy9GUi9mdDVkbjdiMDVpRzNOVkJsTkVpeFMxZFhtZG8yd3oz?= =?utf-8?B?Y1I2czEzZDdCOG9qNytDV3RKYzhJdDFvY3FjOFFzMnFTVjhuS2xQL1FBVTVr?= =?utf-8?B?OVR2NW5JVjlTV0lndnVJVE9tQmkwdDFZVlNuaCtxUnRtY0JlaG84WUlnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 399c8eb9-41ea-4674-aaf8-08dc68e52729 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 07:14:19.6584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0122 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: CID1397741 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavfilter/avfiltergraph.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c > index 0c569eb218e..4eeaa33d5e9 100644 > --- a/libavfilter/avfiltergraph.c > +++ b/libavfilter/avfiltergraph.c > @@ -1410,7 +1410,7 @@ int avfilter_graph_request_oldest(AVFilterGraph *graph) > if (r == AVERROR(EAGAIN) && > !oldest->frame_wanted_out && !oldesti->frame_blocked_in && > !oldesti->status_in) > - ff_request_frame(oldest); > + ff_request_frame(oldest); // return value is intentionally ignored > else if (r < 0) > return r; > } Isn't the typical way to signal this to cast the return value to void? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".