From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5DDD04A506 for ; Wed, 1 May 2024 00:32:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C919B68D645; Wed, 1 May 2024 03:32:33 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8EFF868D55D for ; Wed, 1 May 2024 03:32:27 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id E7C8E20005 for ; Wed, 1 May 2024 00:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714523547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7aGohRntHsOeMM7kOFjLm7vW0c1AJOMETvLcnxFtj1Y=; b=mo5w7QZo0KU9gEaxVRX0e6J17gyNp+GVhdJGpIJDMQxFa5aU8unnUqAUDllXmagPkk9vZi 5ZMsqj+miCCUr6iv8c6aAFYcp/cbtRkO7stbn3zIeKvSKi/1uEPL6AUy38WnZx9JmVZNRQ /RywTo/+4kVL/3KJDx1qHNKn/BW/c8hs9+Z4AFpkM5ePekSfO1/Aq6lAasfIGWRshHcop7 NaupAcv8y0LWf/avnfL1kQumBAt9Z9mjqCc+oFI8AbJh/Ja1APX1AiBgd4FJyR9w/rVuBe YU3J8+DrWYG/e3aWne/wdcWEh+CIJxAUzyk0R7yfHEnRK3iQ1rcOVt7hUrJX/w== Date: Wed, 1 May 2024 02:32:25 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240501003225.GZ6420@pb2> References: <20240422005351.4179419-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2939040001318948876==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2939040001318948876== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Geyo7hAfaP8jhQE9" Content-Disposition: inline --Geyo7hAfaP8jhQE9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 30, 2024 at 09:14:16AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1397741 Unchecked return value > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/avfiltergraph.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c > > index 0c569eb218e..4eeaa33d5e9 100644 > > --- a/libavfilter/avfiltergraph.c > > +++ b/libavfilter/avfiltergraph.c > > @@ -1410,7 +1410,7 @@ int avfilter_graph_request_oldest(AVFilterGraph *= graph) > > if (r =3D=3D AVERROR(EAGAIN) && > > !oldest->frame_wanted_out && !oldesti->frame_blocked_in && > > !oldesti->status_in) > > - ff_request_frame(oldest); > > + ff_request_frame(oldest); // return value is intentionally= ignored > > else if (r < 0) > > return r; > > } >=20 > Isn't the typical way to signal this to cast the return value to void? yes, i will push that change instead thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato=20 --Geyo7hAfaP8jhQE9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjGNkwAKCRBhHseHBAsP q0+9AJ9sSLXl9J4kzYFCQnnbozYglqq1/ACfTE8CbrWQn70wcnPLYy8FABjeZ50= =Od9x -----END PGP SIGNATURE----- --Geyo7hAfaP8jhQE9-- --===============2939040001318948876== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2939040001318948876==--