Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] checkasm: vc1dsp: Align buffers sufficiently for the mspel tests
@ 2024-04-30  7:18 Martin Storsjö
  2024-04-30 18:54 ` James Almer
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Storsjö @ 2024-04-30  7:18 UTC (permalink / raw)
  To: ffmpeg-devel

This fixes crashes in the mspel tests on x86.
---
 tests/checkasm/vc1dsp.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/checkasm/vc1dsp.c b/tests/checkasm/vc1dsp.c
index 407d9e5fe8..f18f0f8251 100644
--- a/tests/checkasm/vc1dsp.c
+++ b/tests/checkasm/vc1dsp.c
@@ -441,10 +441,10 @@ static void check_unescape(void)
 
 static void check_mspel_pixels(void)
 {
-    LOCAL_ALIGNED_8(uint8_t, src0, [32 * 32]);
-    LOCAL_ALIGNED_8(uint8_t, src1, [32 * 32]);
-    LOCAL_ALIGNED_8(uint8_t, dst0, [32 * 32]);
-    LOCAL_ALIGNED_8(uint8_t, dst1, [32 * 32]);
+    LOCAL_ALIGNED_16(uint8_t, src0, [32 * 32]);
+    LOCAL_ALIGNED_16(uint8_t, src1, [32 * 32]);
+    LOCAL_ALIGNED_16(uint8_t, dst0, [32 * 32]);
+    LOCAL_ALIGNED_16(uint8_t, dst1, [32 * 32]);
 
     VC1DSPContext h;
 
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [FFmpeg-devel] [PATCH] checkasm: vc1dsp: Align buffers sufficiently for the mspel tests
  2024-04-30  7:18 [FFmpeg-devel] [PATCH] checkasm: vc1dsp: Align buffers sufficiently for the mspel tests Martin Storsjö
@ 2024-04-30 18:54 ` James Almer
  0 siblings, 0 replies; 2+ messages in thread
From: James Almer @ 2024-04-30 18:54 UTC (permalink / raw)
  To: ffmpeg-devel

On 4/30/2024 4:18 AM, Martin Storsjö wrote:
> This fixes crashes in the mspel tests on x86.
> ---
>   tests/checkasm/vc1dsp.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/checkasm/vc1dsp.c b/tests/checkasm/vc1dsp.c
> index 407d9e5fe8..f18f0f8251 100644
> --- a/tests/checkasm/vc1dsp.c
> +++ b/tests/checkasm/vc1dsp.c
> @@ -441,10 +441,10 @@ static void check_unescape(void)
>   
>   static void check_mspel_pixels(void)
>   {
> -    LOCAL_ALIGNED_8(uint8_t, src0, [32 * 32]);
> -    LOCAL_ALIGNED_8(uint8_t, src1, [32 * 32]);
> -    LOCAL_ALIGNED_8(uint8_t, dst0, [32 * 32]);
> -    LOCAL_ALIGNED_8(uint8_t, dst1, [32 * 32]);
> +    LOCAL_ALIGNED_16(uint8_t, src0, [32 * 32]);
> +    LOCAL_ALIGNED_16(uint8_t, src1, [32 * 32]);
> +    LOCAL_ALIGNED_16(uint8_t, dst0, [32 * 32]);
> +    LOCAL_ALIGNED_16(uint8_t, dst1, [32 * 32]);
>   
>       VC1DSPContext h;

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-30 18:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-30  7:18 [FFmpeg-devel] [PATCH] checkasm: vc1dsp: Align buffers sufficiently for the mspel tests Martin Storsjö
2024-04-30 18:54 ` James Almer

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git