* [FFmpeg-devel] [PATCH] fftools/graph/graphprint: Remove redundant avio_flush()
@ 2025-06-02 10:50 Víctor Manuel Jáquez Leal
2025-06-02 10:55 ` Víctor Manuel Jáquez Leal
0 siblings, 1 reply; 2+ messages in thread
From: Víctor Manuel Jáquez Leal @ 2025-06-02 10:50 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: softworkz ., Andreas Rheinhardt
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
The AVIOContext will be automatically flushed upon closure.
Reviewed-by: softworkz . <softworkz-at-hotmail.com@ffmpeg.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
fftools/graph/graphprint.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fftools/graph/graphprint.c b/fftools/graph/graphprint.c
index 7f0e85d008..e4c6886cf8 100644
--- a/fftools/graph/graphprint.c
+++ b/fftools/graph/graphprint.c
@@ -1070,7 +1070,6 @@ static int print_filtergraphs_priv(FilterGraph **graphs, int nb_graphs, InputFil
}
avio_write(avio, (const unsigned char *)target_buf.str, FFMIN(target_buf.len, target_buf.size - 1));
- avio_flush(avio);
if ((ret = avio_closep(&avio)) < 0)
av_log(NULL, AV_LOG_ERROR, "Error closing graph output file, loss of information possible: %s\n", av_err2str(ret));
--
2.47.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools/graph/graphprint: Remove redundant avio_flush()
2025-06-02 10:50 [FFmpeg-devel] [PATCH] fftools/graph/graphprint: Remove redundant avio_flush() Víctor Manuel Jáquez Leal
@ 2025-06-02 10:55 ` Víctor Manuel Jáquez Leal
0 siblings, 0 replies; 2+ messages in thread
From: Víctor Manuel Jáquez Leal @ 2025-06-02 10:55 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Please ignore this patch. I made a mistake. Sorry.
vmjl
On Mon, 02 Jun 2025 at 12:50, Víctor Manuel Jáquez Leal wrote:
> From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>
> The AVIOContext will be automatically flushed upon closure.
>
> Reviewed-by: softworkz . <softworkz-at-hotmail.com@ffmpeg.org>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> fftools/graph/graphprint.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fftools/graph/graphprint.c b/fftools/graph/graphprint.c
> index 7f0e85d008..e4c6886cf8 100644
> --- a/fftools/graph/graphprint.c
> +++ b/fftools/graph/graphprint.c
> @@ -1070,7 +1070,6 @@ static int print_filtergraphs_priv(FilterGraph **graphs, int nb_graphs, InputFil
> }
>
> avio_write(avio, (const unsigned char *)target_buf.str, FFMIN(target_buf.len, target_buf.size - 1));
> - avio_flush(avio);
>
> if ((ret = avio_closep(&avio)) < 0)
> av_log(NULL, AV_LOG_ERROR, "Error closing graph output file, loss of information possible: %s\n", av_err2str(ret));
> --
> 2.47.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-02 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-02 10:50 [FFmpeg-devel] [PATCH] fftools/graph/graphprint: Remove redundant avio_flush() Víctor Manuel Jáquez Leal
2025-06-02 10:55 ` Víctor Manuel Jáquez Leal
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git