Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: MCC CS <mcccs@gmx.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] Guidance needed for a semi-breaking change
Date: Wed, 27 Apr 2022 14:42:23 +0200
Message-ID: <trinity-7dbcd3cf-2c65-4135-bc7f-316f8b4c8a82-1651063343295@3c-app-mailcom-bs12> (raw)

Hi,

It's my first time writing an (original) patch for ffmpeg, so I would like your help.

I’m planning to propose a diff to an encoder param for aac_at, which is, as currently listed by "ffmpeg -h encoder=aac_at”:

  -aac_at_quality    <int>        E...A...... quality vs speed control (from 0 to 2) (default 0)

Currently, 0 uses HIGH, and 1, 2 use MID, LOW quality encodings.

I’d like to change this param so that all 5 levels listed by Apple (MAX, HIGH, MID, LOW, MIN) can be used.

Do I change it to:

  -aac_at_quality    <int>        E...A...... quality vs speed control (from 0 to 4) (default 0)

and migrate everyone to a higher-quality encoding preset

or
  -aac_at_quality    <int>        E...A...... quality vs speed control (from -1 to 3) (default -1)

so that previous levels are kept as they are, adding only MAX and MIN, which were previously out of range.

I’d like to know: Which of these aligns better with FFMPEG’s policies?

Many thanks
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2022-04-27 12:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 12:42 MCC CS [this message]
2022-04-27 12:49 ` Timo Rothenpieler
2022-04-27 13:06   ` MCC CS
2022-04-27 13:15     ` Timo Rothenpieler
2022-04-27 13:18       ` Nicolas George
2022-04-27 14:07         ` MCC CS
2022-04-27 15:18           ` Timo Rothenpieler
2022-04-27 18:05             ` MCC CS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=trinity-7dbcd3cf-2c65-4135-bc7f-316f8b4c8a82-1651063343295@3c-app-mailcom-bs12 \
    --to=mcccs@gmx.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git