* [FFmpeg-devel] avcodec/audiotoolboxdec: fix missing decoder out properties
@ 2022-04-14 6:06 MCC CS
2022-04-18 7:18 ` [FFmpeg-devel] ping, ping, just 5 lines MCC CS
0 siblings, 1 reply; 5+ messages in thread
From: MCC CS @ 2022-04-14 6:06 UTC (permalink / raw)
To: ffmpeg-devel
Resubmit: fix title.
This is a repost of the patch by Chris Snowhill who originally sent this patch
on 31 December - which didn't receive any replies. As you can see
on https://trac.ffmpeg.org/ticket/9564 the patch is needed and works perfectly.
I have rebased it and recompiled it.
Original commit description:
Monterey needs mBytesPerFrame and mBytesPerPacket to be set, and I'm
surprised this didn't break any previous system versions.
Fixes bug #9564: Cannot decode xHE-AAC with audiotoolbox (aac_at) on
Mac OS Monterey. Fixes likely bug that none of the AudioToolbox
decoders work on Monterey.
---
libavcodec/audiotoolboxdec.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c
index b8d0e868f7..daccf4abf8 100644
--- a/libavcodec/audiotoolboxdec.c
+++ b/libavcodec/audiotoolboxdec.c
@@ -375,6 +375,11 @@ static av_cold int ffat_create_decoder(AVCodecContext *avctx,
avctx->ch_layout.order = AV_CHANNEL_ORDER_UNSPEC;
avctx->ch_layout.nb_channels = out_format.mChannelsPerFrame = in_format.mChannelsPerFrame;
+ out_format.mBytesPerFrame =
+ out_format.mChannelsPerFrame * (out_format.mBitsPerChannel / 8);
+ out_format.mBytesPerPacket =
+ out_format.mBytesPerFrame * out_format.mFramesPerPacket;
+
if (avctx->codec_id == AV_CODEC_ID_ADPCM_IMA_QT)
in_format.mFramesPerPacket = 64;
--
2.35.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* [FFmpeg-devel] ping, ping, just 5 lines
2022-04-14 6:06 [FFmpeg-devel] avcodec/audiotoolboxdec: fix missing decoder out properties MCC CS
@ 2022-04-18 7:18 ` MCC CS
2022-04-21 13:55 ` [FFmpeg-devel] 2nd ping MCC CS
0 siblings, 1 reply; 5+ messages in thread
From: MCC CS @ 2022-04-18 7:18 UTC (permalink / raw)
To: ffmpeg-devel
The patch "avcodec/audiotoolboxdec: fix missing decoder out properties" hasn't been reviewed. Could anyone with some time, please, review this patch? Audiotoolbox decoder on macOS desperately needs this to be useful.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* [FFmpeg-devel] 2nd ping
2022-04-18 7:18 ` [FFmpeg-devel] ping, ping, just 5 lines MCC CS
@ 2022-04-21 13:55 ` MCC CS
2022-04-24 12:35 ` James Almer
2022-04-24 23:56 ` Bang He
0 siblings, 2 replies; 5+ messages in thread
From: MCC CS @ 2022-04-21 13:55 UTC (permalink / raw)
To: ffmpeg-devel
It would be great if anyone who reads this could review this small patch (original: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295351.html):
This is a repost of the patch by Chris Snowhill who originally sent this patch
on 31 December - which didn't receive any replies. As you can see
on https://trac.ffmpeg.org/ticket/9564 the patch is needed and works perfectly.
I have rebased it and recompiled it.
Original commit description:
Monterey needs mBytesPerFrame and mBytesPerPacket to be set, and I'm
surprised this didn't break any previous system versions.
Fixes bug #9564: Cannot decode xHE-AAC with audiotoolbox (aac_at) on
Mac OS Monterey. Fixes likely bug that none of the AudioToolbox
decoders work on Monterey.
---
libavcodec/audiotoolboxdec.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c
index b8d0e868f7..daccf4abf8 100644
--- a/libavcodec/audiotoolboxdec.c
+++ b/libavcodec/audiotoolboxdec.c
@@ -375,6 +375,11 @@ static av_cold int ffat_create_decoder(AVCodecContext *avctx,
avctx->ch_layout.order = AV_CHANNEL_ORDER_UNSPEC;
avctx->ch_layout.nb_channels = out_format.mChannelsPerFrame = in_format.mChannelsPerFrame;
+ out_format.mBytesPerFrame =
+ out_format.mChannelsPerFrame * (out_format.mBitsPerChannel / 8);
+ out_format.mBytesPerPacket =
+ out_format.mBytesPerFrame * out_format.mFramesPerPacket;
+
if (avctx->codec_id == AV_CODEC_ID_ADPCM_IMA_QT)
in_format.mFramesPerPacket = 64;
--
2.35.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] 2nd ping
2022-04-21 13:55 ` [FFmpeg-devel] 2nd ping MCC CS
@ 2022-04-24 12:35 ` James Almer
2022-04-24 23:56 ` Bang He
1 sibling, 0 replies; 5+ messages in thread
From: James Almer @ 2022-04-24 12:35 UTC (permalink / raw)
To: ffmpeg-devel
On 4/21/2022 10:55 AM, MCC CS wrote:
> It would be great if anyone who reads this could review this small patch (original: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295351.html):
>
> This is a repost of the patch by Chris Snowhill who originally sent this patch
> on 31 December - which didn't receive any replies. As you can see
> on https://trac.ffmpeg.org/ticket/9564 the patch is needed and works perfectly.
>
> I have rebased it and recompiled it.
>
> Original commit description:
>
> Monterey needs mBytesPerFrame and mBytesPerPacket to be set, and I'm
> surprised this didn't break any previous system versions.
>
> Fixes bug #9564: Cannot decode xHE-AAC with audiotoolbox (aac_at) on
> Mac OS Monterey. Fixes likely bug that none of the AudioToolbox
> decoders work on Monterey.
> ---
> libavcodec/audiotoolboxdec.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c
> index b8d0e868f7..daccf4abf8 100644
> --- a/libavcodec/audiotoolboxdec.c
> +++ b/libavcodec/audiotoolboxdec.c
> @@ -375,6 +375,11 @@ static av_cold int ffat_create_decoder(AVCodecContext *avctx,
> avctx->ch_layout.order = AV_CHANNEL_ORDER_UNSPEC;
> avctx->ch_layout.nb_channels = out_format.mChannelsPerFrame = in_format.mChannelsPerFrame;
>
> + out_format.mBytesPerFrame =
> + out_format.mChannelsPerFrame * (out_format.mBitsPerChannel / 8);
> + out_format.mBytesPerPacket =
> + out_format.mBytesPerFrame * out_format.mFramesPerPacket;
> +
> if (avctx->codec_id == AV_CODEC_ID_ADPCM_IMA_QT)
> in_format.mFramesPerPacket = 64;
>
> --
> 2.35.1
Will apply. Thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] 2nd ping
2022-04-21 13:55 ` [FFmpeg-devel] 2nd ping MCC CS
2022-04-24 12:35 ` James Almer
@ 2022-04-24 23:56 ` Bang He
1 sibling, 0 replies; 5+ messages in thread
From: Bang He @ 2022-04-24 23:56 UTC (permalink / raw)
To: FFmpeg development discussions and patches
look good for me
On Thu, Apr 21, 2022 at 9:55 PM MCC CS <mcccs@gmx.com> wrote:
> It would be great if anyone who reads this could review this small patch
> (original:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295351.html):
>
> This is a repost of the patch by Chris Snowhill who originally sent this
> patch
> on 31 December - which didn't receive any replies. As you can see
> on https://trac.ffmpeg.org/ticket/9564 the patch is needed and works
> perfectly.
>
> I have rebased it and recompiled it.
>
> Original commit description:
>
> Monterey needs mBytesPerFrame and mBytesPerPacket to be set, and I'm
> surprised this didn't break any previous system versions.
>
> Fixes bug #9564: Cannot decode xHE-AAC with audiotoolbox (aac_at) on
> Mac OS Monterey. Fixes likely bug that none of the AudioToolbox
> decoders work on Monterey.
> ---
> libavcodec/audiotoolboxdec.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c
> index b8d0e868f7..daccf4abf8 100644
> --- a/libavcodec/audiotoolboxdec.c
> +++ b/libavcodec/audiotoolboxdec.c
> @@ -375,6 +375,11 @@ static av_cold int ffat_create_decoder(AVCodecContext
> *avctx,
> avctx->ch_layout.order = AV_CHANNEL_ORDER_UNSPEC;
> avctx->ch_layout.nb_channels = out_format.mChannelsPerFrame =
> in_format.mChannelsPerFrame;
>
> + out_format.mBytesPerFrame =
> + out_format.mChannelsPerFrame * (out_format.mBitsPerChannel / 8);
> + out_format.mBytesPerPacket =
> + out_format.mBytesPerFrame * out_format.mFramesPerPacket;
> +
> if (avctx->codec_id == AV_CODEC_ID_ADPCM_IMA_QT)
> in_format.mFramesPerPacket = 64;
>
> --
> 2.35.1
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-24 23:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 6:06 [FFmpeg-devel] avcodec/audiotoolboxdec: fix missing decoder out properties MCC CS
2022-04-18 7:18 ` [FFmpeg-devel] ping, ping, just 5 lines MCC CS
2022-04-21 13:55 ` [FFmpeg-devel] 2nd ping MCC CS
2022-04-24 12:35 ` James Almer
2022-04-24 23:56 ` Bang He
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git