Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

From: "Zhao Zhili" <quinkblack@foxmail.com>
To: "'FFmpeg development discussions and patches'" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback
Date: Mon, 9 Jan 2023 22:48:20 +0800
Message-ID: <tencent_FE801434BF3E4357879D44E01C5AB434B309@qq.com> (raw)
In-Reply-To: <7807fe91-c269-4a6d-a397-481fb2014aa3@Spark>

> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Alessandro Di Nepi
> Sent: 2022年12月15日 22:16
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback
> 
> Ping on this,
> Can I contribute somehow either to fix calling `av_videotoolbox_default_init` or at least update the docs?

Hope this patch set fixed the original usecase.

http://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305477.html

> 
> Best Regards,
> Alessandro
> On 11 Dec 2022, 11:57 +0200, Alessandro Di Nepi <alessandro.dinepi@gmail.com>, wrote:
> > On 9 Dec 2022, 6:45 +0200, FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>, wrote:
> > > Did you call av_videotoolbox_default_init() or av_videotoolbox_default_init2()?
> > Actually yes, I call `av_videotoolbox_default_init(context);`
> > > I think that’s why avctx->internal->hwaccel_priv_data is NULL. That code path is broken.
> > > Does remove the call of av_videotoolbox_default_init()/av_videotoolbox_default_init2() works for you?
> > Definitively yes, if I remove the call to `av_videotoolbox_default_init` the context is fine.
> >
> > Thanks for sorting this out. I'd like to contribute and have this fixed or documented for other people.
> > What should be the desired behavior? Calling `av_videotoolbox_default_init` and having the context not NULL?
> > Or shall we remove the init at all?
> >
> > Best Regards
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".