* [FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace
@ 2024-05-20 1:12 Marvin Scholz
2024-05-21 1:56 ` Gnattu OC via ffmpeg-devel
0 siblings, 1 reply; 5+ messages in thread
From: Marvin Scholz @ 2024-05-20 1:12 UTC (permalink / raw)
To: ffmpeg-devel
Fix #10884
---
libavutil/hwcontext_videotoolbox.c | 54 +++++++++++++++++++++---------
1 file changed, 38 insertions(+), 16 deletions(-)
diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
index 9f82b104c3..4a35bfc7ff 100644
--- a/libavutil/hwcontext_videotoolbox.c
+++ b/libavutil/hwcontext_videotoolbox.c
@@ -530,6 +530,8 @@ CFStringRef av_map_videotoolbox_color_trc_from_av(enum AVColorTransferCharacteri
static int vt_pixbuf_set_colorspace(void *log_ctx,
CVPixelBufferRef pixbuf, const AVFrame *src)
{
+ CGColorSpaceRef colorspace = NULL;
+ CFMutableDictionaryRef attachments = NULL;
CFStringRef colormatrix = NULL, colorpri = NULL, colortrc = NULL;
Float32 gamma = 0;
@@ -550,37 +552,57 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
else if (src->color_trc == AVCOL_TRC_GAMMA28)
gamma = 2.8;
+ attachments = CFDictionaryCreateMutable(NULL, 0,
+ &kCFTypeDictionaryKeyCallBacks,
+ &kCFTypeDictionaryValueCallBacks);
+ if (!attachments)
+ return AVERROR(ENOMEM);
+
if (colormatrix) {
- CVBufferSetAttachment(
- pixbuf,
+ CFDictionarySetValue(
+ attachments,
kCVImageBufferYCbCrMatrixKey,
- colormatrix,
- kCVAttachmentMode_ShouldPropagate);
+ colormatrix);
}
if (colorpri) {
- CVBufferSetAttachment(
- pixbuf,
+ CFDictionarySetValue(
+ attachments,
kCVImageBufferColorPrimariesKey,
- colorpri,
- kCVAttachmentMode_ShouldPropagate);
+ colorpri);
}
if (colortrc) {
- CVBufferSetAttachment(
- pixbuf,
+ CFDictionarySetValue(
+ attachments,
kCVImageBufferTransferFunctionKey,
- colortrc,
- kCVAttachmentMode_ShouldPropagate);
+ colortrc);
}
if (gamma != 0) {
CFNumberRef gamma_level = CFNumberCreate(NULL, kCFNumberFloat32Type, &gamma);
- CVBufferSetAttachment(
- pixbuf,
+ CFDictionarySetValue(
+ attachments,
kCVImageBufferGammaLevelKey,
- gamma_level,
- kCVAttachmentMode_ShouldPropagate);
+ gamma_level);
CFRelease(gamma_level);
}
+ if (__builtin_available(macOS 10.8, iOS 10, *))
+ colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments);
+
+ if (colorspace) {
+ CFDictionarySetValue(
+ attachments,
+ kCVImageBufferCGColorSpaceKey,
+ colorspace);
+ CFRelease(colorspace);
+ } else
+ av_log(log_ctx, AV_LOG_WARNING, "Unable to set proper colorspace for the CVImageBuffer.\n");
+
+ CVBufferSetAttachments(
+ pixbuf,
+ attachments,
+ kCVAttachmentMode_ShouldPropagate);
+ CFRelease(attachments);
+
return 0;
}
base-commit: 463c573e6b6489c588bee90124d5cf92db8ccaaa
--
2.39.3 (Apple Git-145)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace
2024-05-20 1:12 [FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace Marvin Scholz
@ 2024-05-21 1:56 ` Gnattu OC via ffmpeg-devel
2024-05-23 16:05 ` Zhao Zhili
0 siblings, 1 reply; 5+ messages in thread
From: Gnattu OC via ffmpeg-devel @ 2024-05-21 1:56 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Gnattu OC
> On May 20, 2024, at 09:12, Marvin Scholz <epirat07@gmail.com> wrote:
>
> Fix #10884
> ---
> libavutil/hwcontext_videotoolbox.c | 54 +++++++++++++++++++++---------
> 1 file changed, 38 insertions(+), 16 deletions(-)
>
> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
> index 9f82b104c3..4a35bfc7ff 100644
> --- a/libavutil/hwcontext_videotoolbox.c
> +++ b/libavutil/hwcontext_videotoolbox.c
> @@ -530,6 +530,8 @@ CFStringRef av_map_videotoolbox_color_trc_from_av(enum AVColorTransferCharacteri
> static int vt_pixbuf_set_colorspace(void *log_ctx,
> CVPixelBufferRef pixbuf, const AVFrame *src)
> {
> + CGColorSpaceRef colorspace = NULL;
> + CFMutableDictionaryRef attachments = NULL;
> CFStringRef colormatrix = NULL, colorpri = NULL, colortrc = NULL;
> Float32 gamma = 0;
>
> @@ -550,37 +552,57 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
> else if (src->color_trc == AVCOL_TRC_GAMMA28)
> gamma = 2.8;
>
> + attachments = CFDictionaryCreateMutable(NULL, 0,
> + &kCFTypeDictionaryKeyCallBacks,
> + &kCFTypeDictionaryValueCallBacks);
> + if (!attachments)
> + return AVERROR(ENOMEM);
> +
> if (colormatrix) {
> - CVBufferSetAttachment(
> - pixbuf,
> + CFDictionarySetValue(
> + attachments,
> kCVImageBufferYCbCrMatrixKey,
> - colormatrix,
> - kCVAttachmentMode_ShouldPropagate);
> + colormatrix);
> }
> if (colorpri) {
> - CVBufferSetAttachment(
> - pixbuf,
> + CFDictionarySetValue(
> + attachments,
> kCVImageBufferColorPrimariesKey,
> - colorpri,
> - kCVAttachmentMode_ShouldPropagate);
> + colorpri);
> }
> if (colortrc) {
> - CVBufferSetAttachment(
> - pixbuf,
> + CFDictionarySetValue(
> + attachments,
> kCVImageBufferTransferFunctionKey,
> - colortrc,
> - kCVAttachmentMode_ShouldPropagate);
> + colortrc);
> }
> if (gamma != 0) {
> CFNumberRef gamma_level = CFNumberCreate(NULL, kCFNumberFloat32Type, &gamma);
> - CVBufferSetAttachment(
> - pixbuf,
> + CFDictionarySetValue(
> + attachments,
> kCVImageBufferGammaLevelKey,
> - gamma_level,
> - kCVAttachmentMode_ShouldPropagate);
> + gamma_level);
> CFRelease(gamma_level);
> }
>
> + if (__builtin_available(macOS 10.8, iOS 10, *))
> + colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments);
> +
> + if (colorspace) {
> + CFDictionarySetValue(
> + attachments,
> + kCVImageBufferCGColorSpaceKey,
> + colorspace);
> + CFRelease(colorspace);
> + } else
> + av_log(log_ctx, AV_LOG_WARNING, "Unable to set proper colorspace for the CVImageBuffer.\n");
This will spam the console on SDR video inputs because they have nothing to be set as the attachment and the colorspace creation will always fail and return nil.
> +
> + CVBufferSetAttachments(
> + pixbuf,
> + attachments,
> + kCVAttachmentMode_ShouldPropagate);
> + CFRelease(attachments);
> +
> return 0;
> }
>
>
> base-commit: 463c573e6b6489c588bee90124d5cf92db8ccaaa
> --
> 2.39.3 (Apple Git-145)
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace
2024-05-21 1:56 ` Gnattu OC via ffmpeg-devel
@ 2024-05-23 16:05 ` Zhao Zhili
2024-05-23 18:41 ` epirat07
0 siblings, 1 reply; 5+ messages in thread
From: Zhao Zhili @ 2024-05-23 16:05 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Gnattu OC, Marvin Scholz
> On May 21, 2024, at 09:56, Gnattu OC via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>
>>
>> On May 20, 2024, at 09:12, Marvin Scholz <epirat07@gmail.com> wrote:
>>
>> Fix #10884
>> ---
>> libavutil/hwcontext_videotoolbox.c | 54 +++++++++++++++++++++---------
>> 1 file changed, 38 insertions(+), 16 deletions(-)
>>
>> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
>> index 9f82b104c3..4a35bfc7ff 100644
>> --- a/libavutil/hwcontext_videotoolbox.c
>> +++ b/libavutil/hwcontext_videotoolbox.c
>> @@ -530,6 +530,8 @@ CFStringRef av_map_videotoolbox_color_trc_from_av(enum AVColorTransferCharacteri
>> static int vt_pixbuf_set_colorspace(void *log_ctx,
>> CVPixelBufferRef pixbuf, const AVFrame *src)
>> {
>> + CGColorSpaceRef colorspace = NULL;
>> + CFMutableDictionaryRef attachments = NULL;
>> CFStringRef colormatrix = NULL, colorpri = NULL, colortrc = NULL;
>> Float32 gamma = 0;
>>
>> @@ -550,37 +552,57 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
>> else if (src->color_trc == AVCOL_TRC_GAMMA28)
>> gamma = 2.8;
>>
>> + attachments = CFDictionaryCreateMutable(NULL, 0,
>> + &kCFTypeDictionaryKeyCallBacks,
>> + &kCFTypeDictionaryValueCallBacks);
>> + if (!attachments)
>> + return AVERROR(ENOMEM);
>> +
>> if (colormatrix) {
>> - CVBufferSetAttachment(
>> - pixbuf,
>> + CFDictionarySetValue(
>> + attachments,
>> kCVImageBufferYCbCrMatrixKey,
>> - colormatrix,
>> - kCVAttachmentMode_ShouldPropagate);
>> + colormatrix);
>> }
>> if (colorpri) {
>> - CVBufferSetAttachment(
>> - pixbuf,
>> + CFDictionarySetValue(
>> + attachments,
>> kCVImageBufferColorPrimariesKey,
>> - colorpri,
>> - kCVAttachmentMode_ShouldPropagate);
>> + colorpri);
>> }
>> if (colortrc) {
>> - CVBufferSetAttachment(
>> - pixbuf,
>> + CFDictionarySetValue(
>> + attachments,
>> kCVImageBufferTransferFunctionKey,
>> - colortrc,
>> - kCVAttachmentMode_ShouldPropagate);
>> + colortrc);
>> }
>> if (gamma != 0) {
>> CFNumberRef gamma_level = CFNumberCreate(NULL, kCFNumberFloat32Type, &gamma);
>> - CVBufferSetAttachment(
>> - pixbuf,
>> + CFDictionarySetValue(
>> + attachments,
>> kCVImageBufferGammaLevelKey,
>> - gamma_level,
>> - kCVAttachmentMode_ShouldPropagate);
>> + gamma_level);
>> CFRelease(gamma_level);
>> }
>>
>> + if (__builtin_available(macOS 10.8, iOS 10, *))
>> + colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments);
>> +
>> + if (colorspace) {
>> + CFDictionarySetValue(
>> + attachments,
>> + kCVImageBufferCGColorSpaceKey,
>> + colorspace);
>> + CFRelease(colorspace);
>> + } else
>> + av_log(log_ctx, AV_LOG_WARNING, "Unable to set proper colorspace for the CVImageBuffer.\n");
>
> This will spam the console on SDR video inputs because they have nothing to be set as the attachment and the colorspace creation will always fail and return nil.
I will just remove the log message and apply the patch this week if no objection.
>
>> +
>> + CVBufferSetAttachments(
>> + pixbuf,
>> + attachments,
>> + kCVAttachmentMode_ShouldPropagate);
>> + CFRelease(attachments);
>> +
>> return 0;
>> }
>>
>>
>> base-commit: 463c573e6b6489c588bee90124d5cf92db8ccaaa
>> --
>> 2.39.3 (Apple Git-145)
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace
2024-05-23 16:05 ` Zhao Zhili
@ 2024-05-23 18:41 ` epirat07
2024-05-24 2:27 ` Zhao Zhili
0 siblings, 1 reply; 5+ messages in thread
From: epirat07 @ 2024-05-23 18:41 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On 23 May 2024, at 18:05, Zhao Zhili wrote:
>> On May 21, 2024, at 09:56, Gnattu OC via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>>
>>>
>>> On May 20, 2024, at 09:12, Marvin Scholz <epirat07@gmail.com> wrote:
>>>
>>> Fix #10884
>>> ---
>>> libavutil/hwcontext_videotoolbox.c | 54 +++++++++++++++++++++---------
>>> 1 file changed, 38 insertions(+), 16 deletions(-)
>>>
>>> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
>>> index 9f82b104c3..4a35bfc7ff 100644
>>> --- a/libavutil/hwcontext_videotoolbox.c
>>> +++ b/libavutil/hwcontext_videotoolbox.c
>>> @@ -530,6 +530,8 @@ CFStringRef av_map_videotoolbox_color_trc_from_av(enum AVColorTransferCharacteri
>>> static int vt_pixbuf_set_colorspace(void *log_ctx,
>>> CVPixelBufferRef pixbuf, const AVFrame *src)
>>> {
>>> + CGColorSpaceRef colorspace = NULL;
>>> + CFMutableDictionaryRef attachments = NULL;
>>> CFStringRef colormatrix = NULL, colorpri = NULL, colortrc = NULL;
>>> Float32 gamma = 0;
>>>
>>> @@ -550,37 +552,57 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
>>> else if (src->color_trc == AVCOL_TRC_GAMMA28)
>>> gamma = 2.8;
>>>
>>> + attachments = CFDictionaryCreateMutable(NULL, 0,
>>> + &kCFTypeDictionaryKeyCallBacks,
>>> + &kCFTypeDictionaryValueCallBacks);
>>> + if (!attachments)
>>> + return AVERROR(ENOMEM);
>>> +
>>> if (colormatrix) {
>>> - CVBufferSetAttachment(
>>> - pixbuf,
>>> + CFDictionarySetValue(
>>> + attachments,
>>> kCVImageBufferYCbCrMatrixKey,
>>> - colormatrix,
>>> - kCVAttachmentMode_ShouldPropagate);
>>> + colormatrix);
>>> }
>>> if (colorpri) {
>>> - CVBufferSetAttachment(
>>> - pixbuf,
>>> + CFDictionarySetValue(
>>> + attachments,
>>> kCVImageBufferColorPrimariesKey,
>>> - colorpri,
>>> - kCVAttachmentMode_ShouldPropagate);
>>> + colorpri);
>>> }
>>> if (colortrc) {
>>> - CVBufferSetAttachment(
>>> - pixbuf,
>>> + CFDictionarySetValue(
>>> + attachments,
>>> kCVImageBufferTransferFunctionKey,
>>> - colortrc,
>>> - kCVAttachmentMode_ShouldPropagate);
>>> + colortrc);
>>> }
>>> if (gamma != 0) {
>>> CFNumberRef gamma_level = CFNumberCreate(NULL, kCFNumberFloat32Type, &gamma);
>>> - CVBufferSetAttachment(
>>> - pixbuf,
>>> + CFDictionarySetValue(
>>> + attachments,
>>> kCVImageBufferGammaLevelKey,
>>> - gamma_level,
>>> - kCVAttachmentMode_ShouldPropagate);
>>> + gamma_level);
>>> CFRelease(gamma_level);
>>> }
>>>
>>> + if (__builtin_available(macOS 10.8, iOS 10, *))
>>> + colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments);
>>> +
>>> + if (colorspace) {
>>> + CFDictionarySetValue(
>>> + attachments,
>>> + kCVImageBufferCGColorSpaceKey,
>>> + colorspace);
>>> + CFRelease(colorspace);
>>> + } else
>>> + av_log(log_ctx, AV_LOG_WARNING, "Unable to set proper colorspace for the CVImageBuffer.\n");
>>
>> This will spam the console on SDR video inputs because they have nothing to be set as the attachment and the colorspace creation will always fail and return nil.
>
> I will just remove the log message and apply the patch this week if no objection.
>
I will do some more tests, if you want apply with the log message removed and I will do a follow up patch
if I find another solution.
>>
>>> +
>>> + CVBufferSetAttachments(
>>> + pixbuf,
>>> + attachments,
>>> + kCVAttachmentMode_ShouldPropagate);
>>> + CFRelease(attachments);
>>> +
>>> return 0;
>>> }
>>>
>>>
>>> base-commit: 463c573e6b6489c588bee90124d5cf92db8ccaaa
>>> --
>>> 2.39.3 (Apple Git-145)
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace
2024-05-23 18:41 ` epirat07
@ 2024-05-24 2:27 ` Zhao Zhili
0 siblings, 0 replies; 5+ messages in thread
From: Zhao Zhili @ 2024-05-24 2:27 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On May 24, 2024, at 02:41, epirat07@gmail.com wrote:
>
>
> On 23 May 2024, at 18:05, Zhao Zhili wrote:
>
>>> On May 21, 2024, at 09:56, Gnattu OC via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>>>
>>>>
>>>> On May 20, 2024, at 09:12, Marvin Scholz <epirat07@gmail.com> wrote:
>>>>
>>>> Fix #10884
>>>> ---
>>>> libavutil/hwcontext_videotoolbox.c | 54 +++++++++++++++++++++---------
>>>> 1 file changed, 38 insertions(+), 16 deletions(-)
>>>>
>>>> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
>>>> index 9f82b104c3..4a35bfc7ff 100644
>>>> --- a/libavutil/hwcontext_videotoolbox.c
>>>> +++ b/libavutil/hwcontext_videotoolbox.c
>>>> @@ -530,6 +530,8 @@ CFStringRef av_map_videotoolbox_color_trc_from_av(enum AVColorTransferCharacteri
>>>> static int vt_pixbuf_set_colorspace(void *log_ctx,
>>>> CVPixelBufferRef pixbuf, const AVFrame *src)
>>>> {
>>>> + CGColorSpaceRef colorspace = NULL;
>>>> + CFMutableDictionaryRef attachments = NULL;
>>>> CFStringRef colormatrix = NULL, colorpri = NULL, colortrc = NULL;
>>>> Float32 gamma = 0;
>>>>
>>>> @@ -550,37 +552,57 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
>>>> else if (src->color_trc == AVCOL_TRC_GAMMA28)
>>>> gamma = 2.8;
>>>>
>>>> + attachments = CFDictionaryCreateMutable(NULL, 0,
>>>> + &kCFTypeDictionaryKeyCallBacks,
>>>> + &kCFTypeDictionaryValueCallBacks);
>>>> + if (!attachments)
>>>> + return AVERROR(ENOMEM);
>>>> +
>>>> if (colormatrix) {
>>>> - CVBufferSetAttachment(
>>>> - pixbuf,
>>>> + CFDictionarySetValue(
>>>> + attachments,
>>>> kCVImageBufferYCbCrMatrixKey,
>>>> - colormatrix,
>>>> - kCVAttachmentMode_ShouldPropagate);
>>>> + colormatrix);
>>>> }
>>>> if (colorpri) {
>>>> - CVBufferSetAttachment(
>>>> - pixbuf,
>>>> + CFDictionarySetValue(
>>>> + attachments,
>>>> kCVImageBufferColorPrimariesKey,
>>>> - colorpri,
>>>> - kCVAttachmentMode_ShouldPropagate);
>>>> + colorpri);
>>>> }
>>>> if (colortrc) {
>>>> - CVBufferSetAttachment(
>>>> - pixbuf,
>>>> + CFDictionarySetValue(
>>>> + attachments,
>>>> kCVImageBufferTransferFunctionKey,
>>>> - colortrc,
>>>> - kCVAttachmentMode_ShouldPropagate);
>>>> + colortrc);
>>>> }
>>>> if (gamma != 0) {
>>>> CFNumberRef gamma_level = CFNumberCreate(NULL, kCFNumberFloat32Type, &gamma);
>>>> - CVBufferSetAttachment(
>>>> - pixbuf,
>>>> + CFDictionarySetValue(
>>>> + attachments,
>>>> kCVImageBufferGammaLevelKey,
>>>> - gamma_level,
>>>> - kCVAttachmentMode_ShouldPropagate);
>>>> + gamma_level);
>>>> CFRelease(gamma_level);
>>>> }
>>>>
>>>> + if (__builtin_available(macOS 10.8, iOS 10, *))
>>>> + colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments);
>>>> +
>>>> + if (colorspace) {
>>>> + CFDictionarySetValue(
>>>> + attachments,
>>>> + kCVImageBufferCGColorSpaceKey,
>>>> + colorspace);
>>>> + CFRelease(colorspace);
>>>> + } else
>>>> + av_log(log_ctx, AV_LOG_WARNING, "Unable to set proper colorspace for the CVImageBuffer.\n");
>>>
>>> This will spam the console on SDR video inputs because they have nothing to be set as the attachment and the colorspace creation will always fail and return nil.
>>
>> I will just remove the log message and apply the patch this week if no objection.
>>
>
> I will do some more tests, if you want apply with the log message removed and I will do a follow up patch
> if I find another solution.
OK, then I can wait. Please notify when it’s ready.
>
>>>
>>>> +
>>>> + CVBufferSetAttachments(
>>>> + pixbuf,
>>>> + attachments,
>>>> + kCVAttachmentMode_ShouldPropagate);
>>>> + CFRelease(attachments);
>>>> +
>>>> return 0;
>>>> }
>>>>
>>>>
>>>> base-commit: 463c573e6b6489c588bee90124d5cf92db8ccaaa
>>>> --
>>>> 2.39.3 (Apple Git-145)
>>>> _______________________________________________
>>>> ffmpeg-devel mailing list
>>>> ffmpeg-devel@ffmpeg.org
>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>>
>>>> To unsubscribe, visit link above, or email
>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org> <mailto:ffmpeg-devel@ffmpeg.org>
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-24 2:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-20 1:12 [FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace Marvin Scholz
2024-05-21 1:56 ` Gnattu OC via ffmpeg-devel
2024-05-23 16:05 ` Zhao Zhili
2024-05-23 18:41 ` epirat07
2024-05-24 2:27 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git