Re: [FFmpeg-devel] [PATCH v2] avutil/{color_utils, csp}: merge color_utils into csp and expose API

["\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>]

> On Jan 31, 2023, at 02:22, Leo Izen <leo.izen@gmail.com> wrote:
> 
> On 1/30/23 12:08, Zhao Zhili wrote:
>>> -----Original Message-----
>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Leo Izen
>>> Sent: 2023年1月31日 0:50
>>> To: ffmpeg-devel@ffmpeg.org
>>> Cc: Leo Izen <leo.izen@gmail.com>
>>> Subject: [FFmpeg-devel] [PATCH v2] avutil/{color_utils, csp}: merge color_utils into csp and expose API
>>> 
>>> libavutil/color_utils contains some avpriv_ symbols that map
>>> enum AVTransferCharacteristic values to gamma-curve approximations and
>>> to the actual transfer functions to invert them (i.e. -> linear).
>>> 
>>> There's two issues with this:
>>> (1) avpriv is evil and should be avoided whenever possible
>>> (2) libavutil/csp.h exposes a public API for handling color that
>>>     already handles primaries and matricies
>>> 
>>> I don't see any reason this API has to be private, so this commit takes
>>> the functionality from avutil/color_utils and merges it into avutil/csp
>>> with an exposed av_ API rather than the previous avpriv_ API.
>>> 
>>> Every reference to the previous API has been updated to point to the
>>> new one. color_utils.h has been deleted as well. This should not break
>>> any applications as it only contained avpriv_ symbols in the first
>>> place, so nothing in that header could be referenced by other
>>> applications.
>> Isn't it break old libavcodec which linked to the new libavutil?
> 
> That's why it's in the major version bump thread.

OK then. Didn’t notice that because email client didn’t show thread correctly.

> 
> - Leo Izen (thebombzen)
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".