Thank you Martin, thank for pointing out the shortcomings.


// frank xu


------------------ Original ------------------
From:                                                                                                                        "FFmpeg development discussions and patches"                                                                                    <martin@martin.st&gt;;
Date:&nbsp;Wed, Apr 12, 2023 09:02 PM
To:&nbsp;"FFmpeg development discussions and patches"<ffmpeg-devel@ffmpeg.org&gt;;
Cc:&nbsp;"Ð츣¡"<839789740@qq.com&gt;;
Subject:&nbsp;Re: [FFmpeg-devel] [PATCH] codec/aarch64/hevc:add idct_32x32_neon



On Tue, 11 Apr 2023, xufuji456 wrote:

&gt; got 73% speed up (run_count=1000, CPU=Cortex A53)
&gt; idct_32x32_neon: 4826 idct_32x32_c: 18236
&gt; idct_32x32_neon: 4824 idct_32x32_c: 18149
&gt; idct_32x32_neon: 4937 idct_32x32_c: 18333
&gt; ---
&gt; libavcodec/aarch64/hevcdsp_idct_neon.S&nbsp;&nbsp;&nbsp; | 289 +++++++++++++++++++---
&gt; libavcodec/aarch64/hevcdsp_init_aarch64.c |&nbsp;&nbsp; 5 +
&gt; 2 files changed, 266 insertions(+), 28 deletions(-)

One minor comment below, otherwise it seems fine.

&gt; +.macro tr_32x4 name, shift
&gt; +function func_tr_32x4_\name
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; mov&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; x10, lr
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; bl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; func_tr_16x4_noscale

Older binutils don't support the name 'lr' for the register, it has to be 
spelled out as x30.

Pushed with that fixed.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".