From: =?gb18030?B?0Oy4o8Kh?= <839789740@qq.com>
To: =?gb18030?B?RkZtcGVnIGRldmVsb3BtZW50IGRpc2N1c3Npb25zIGFuZCBwYXRjaGVz?=
<ffmpeg-devel@ffmpeg.org>
Cc: =?gb18030?B?TWFydGluJm5ic3A7U3RvcnNqhDGkNw==?= <martin@martin.st>
Subject: Re: [FFmpeg-devel] [PATCH] codec/aarch64/hevc:add idct_32x32_neon
Date: Thu, 13 Apr 2023 11:48:15 +0800
Message-ID: <tencent_F992182FC01BB2B3F23E97E384DAB2636209@qq.com> (raw)
In-Reply-To: <d8269da9-c716-88d7-6c51-cf74aae6ccb4@martin.st>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 2193 bytes --]
Thank you Martin, thank for pointing out the shortcomings.
// frank xu
------------------ Original ------------------
From: "FFmpeg development discussions and patches" <martin@martin.st>;
Date: Wed, Apr 12, 2023 09:02 PM
To: "FFmpeg development discussions and patches"<ffmpeg-devel@ffmpeg.org>;
Cc: "Ð츣¡"<839789740@qq.com>;
Subject: Re: [FFmpeg-devel] [PATCH] codec/aarch64/hevc:add idct_32x32_neon
On Tue, 11 Apr 2023, xufuji456 wrote:
> got 73% speed up (run_count=1000, CPU=Cortex A53)
> idct_32x32_neon: 4826 idct_32x32_c: 18236
> idct_32x32_neon: 4824 idct_32x32_c: 18149
> idct_32x32_neon: 4937 idct_32x32_c: 18333
> ---
> libavcodec/aarch64/hevcdsp_idct_neon.S | 289 +++++++++++++++++++---
> libavcodec/aarch64/hevcdsp_init_aarch64.c | 5 +
> 2 files changed, 266 insertions(+), 28 deletions(-)
One minor comment below, otherwise it seems fine.
> +.macro tr_32x4 name, shift
> +function func_tr_32x4_\name
> + mov x10, lr
> + bl func_tr_16x4_noscale
Older binutils don't support the name 'lr' for the register, it has to be
spelled out as x30.
Pushed with that fixed.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-04-13 3:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 11:10 xufuji456
2023-04-12 13:02 ` Martin Storsjö
2023-04-13 3:48 ` =?gb18030?B?0Oy4o8Kh?= [this message]
2023-04-13 3:16 [FFmpeg-devel] [PATCH] codec/aarch64/hevc: add idct_32x32_neon xufuji456
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_F992182FC01BB2B3F23E97E384DAB2636209@qq.com \
--to=839789740@qq.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=martin@martin.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git