From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9BEDF429C5 for ; Mon, 11 Apr 2022 09:12:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0F30068B39B; Mon, 11 Apr 2022 12:12:17 +0300 (EEST) Received: from out162-62-57-137.mail.qq.com (out162-62-57-137.mail.qq.com [162.62.57.137]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8B58B68B13D for ; Mon, 11 Apr 2022 12:12:10 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1649668327; bh=tb7/mRWrdiJBesQcSfnnnip3SY/IFNewFGrcxIJG8S4=; h=From:Subject:Date:References:To:In-Reply-To; b=ogK1qtTWnt9P5pGvZbNlKLBbiQXzX4J+m6Ln2y7bl9gd9FebTfd7RL6Ggehrg5LC8 CmfDbIRXF6t6H8s2u4RFz5m4EbX7C/3+0MgWHnlxurUUxAbu7o7WD1VDJfIKn2XrJn U50n109DHhbQWqSFY00atG4TecIfVC/8oeoX3VUo= Received: from [192.168.255.10] ([113.108.77.53]) by newxmesmtplogicsvrszc7.qq.com (NewEsmtp) with SMTP id 305AF612; Mon, 11 Apr 2022 17:12:05 +0800 X-QQ-mid: xmsmtpt1649668325twjkgi926 Message-ID: X-QQ-XMAILINFO: N3NLPHd8OPNAQ9p2ij+5i1/NFWInSLGysBq70JJK/q9w1JYKq52VMxrXDoP0Jj KHYaQa6eBCGDqrkLYnQRP2A9L5ZOk1FR/br9dzm1c3Gm4uRKiRjkra9wmcSUecFMnCIbEZcyZuam oDZVTQs4CuNmahIhjIvlvnRKJGE/u/XKsWPfhXBC4qUKArfBWg0RR8j4C2LBDM857ASPslyLAiQq H7wu5JwpOfj/YfNiGLQWTkVwKh3bflhm3DVXOnMbRF5fkEflvudOMQ9LNczeM6VFSTXXzJEglIOl dqSvaq5F5Qk2aBTo5hzuOyOxL7GY3KCSO5msi/VTE6qTzv2HBNgVZTnBKfVTLSwgJifxwS44Ors4 pUTBYxaoatA7XPbfceTTFvgKbt86x2g0U+442+vjoyeFS8t78TIxf+zP2sknQnnP8XPoHj0l4rnO PdUGzaspYOUM0RWjbWVB0iPaiRlrbUrVrs36rW7BJBMQX8mlge25v9WHhRBZ2J42KRkaBMvLGDxR lGbmRQUAlS57zVm0HkwgAGa9cx9SHWZxtXSw957CPOpQwarPvKGZXMwZazCsCw856jaPlGSige52 dNyRq1D9Rantf3n42xy7qeQTERVo39L4YAKH4OB2j0v4uanOungq0MwsgjR45NKhwpbccQ4H8qIq m00AUz5zifAyq4WcDJ0JNqi/1+4kBlhPP8nEaIs82bl9416zNeyYZJvXdPTL8dVnoP1X5r0TcUqa 0wI2b4p8idmThWGnsu4JLumK+1m/lMDiaBMWfKOpcLSoeQjZ11+1EGwJpf4gs6uf0riuMftmPupo Sd0nd5cnBZLoxQDBtp95BmpIoqHh5Cz5IFq7jApEgdgCejXn2OL4pCUFW4yJzrxun4dJUsWREfRv aK+QwjR/xotme7R90yZI+DFZIkWRjXkV8a6vCkNB/z From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Mon, 11 Apr 2022 17:12:05 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH v4] examples/decode_video: flush parser to fix missing frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ping. The same kind of issue like `doc/examples/transcode_aac: Don't ignore last encoded frame. https://patchwork.ffmpeg.org/project/ffmpeg/patch/8fd28808-07f8-9458-b032-8792c67a38fd@gmail.com/ > On Jul 14, 2021, at 11:02 AM, Zhao Zhili wrote: > > --- > v4: break when error occured in fread, fix infinite loop introduced by v3 > v3: check EOF by "eof = !data_size && feof(f);" > > doc/examples/decode_video.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/doc/examples/decode_video.c b/doc/examples/decode_video.c > index 18ee90a6c0..7238e38103 100644 > --- a/doc/examples/decode_video.c > +++ b/doc/examples/decode_video.c > @@ -92,6 +92,7 @@ int main(int argc, char **argv) > uint8_t *data; > size_t data_size; > int ret; > + int eof; > AVPacket *pkt; > > if (argc <= 2) { > @@ -150,15 +151,16 @@ int main(int argc, char **argv) > exit(1); > } > > - while (!feof(f)) { > + do { > /* read raw data from the input file */ > data_size = fread(inbuf, 1, INBUF_SIZE, f); > - if (!data_size) > + if (ferror(f)) > break; > + eof = !data_size; > > /* use the parser to split the data into frames */ > data = inbuf; > - while (data_size > 0) { > + while (data_size > 0 || eof) { > ret = av_parser_parse2(parser, c, &pkt->data, &pkt->size, > data, data_size, AV_NOPTS_VALUE, AV_NOPTS_VALUE, 0); > if (ret < 0) { > @@ -170,8 +172,10 @@ int main(int argc, char **argv) > > if (pkt->size) > decode(c, frame, pkt, outfilename); > + else if (eof) > + break; > } > - } > + } while (!eof); > > /* flush the decoder */ > decode(c, frame, NULL, outfilename); > -- > 2.31.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".