From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v2 5/7] avcodec/mediacodecenc: remove the strategy to create DTS Date: Tue, 13 Dec 2022 10:55:27 +0800 Message-ID: <tencent_F71FDC414B91E61B9093E6EBA7E4AAA9D306@qq.com> (raw) In-Reply-To: <22621577bd7ccd1da3bab3e16740528ffd1d82fb.camel@haerdin.se> > On Dec 12, 2022, at 23:28, Tomas Härdin <git@haerdin.se> wrote: > > ons 2022-12-07 klockan 17:31 +0800 skrev Zhao Zhili: >> From: Zhao Zhili <zhilizhao@tencent.com> >> >> Use input PTS as DTS has multiple problems: >> 1. If there is no reordering, it's better to just use the output >> PTS as DTS, since encoder may change the timestamp value (do it >> on purpose or rounding error). >> >> 2. If there is reordering, input PTS should be shift a few frames >> as DTS to satisfy the requirement of PTS >= DTS. I can't find a >> reliable way to determine how many frames to be shift. For example, >> we don't known if the encoder use hierarchical B frames. The >> max_num_reorder_frames can be get from VUI, but VUI is optional. >> >> 3. Encoder dropping frames makes the case worse. Android has an >> BITRATE_MODE_CBR_FD option to allow it explicitly. > > Don't we already have code to parse this stuff from h.264 streams? We have code to parse max_num_reorder_frames, if the stream contains the field. We have some code to generate/guess DTS but doesn’t work reliably for H.264/H.265. I guess it’s hard, if not impossible. We don’t know the prediction structures. Use encoder’s input PTS as DTS works for some transport protocols like RTP, and MP4 with negative_cts_offsets, otherwise it’s broken due to PTS >= DTS. If we can and decided to implement such algorithm, it should go in a higher level, so remux raw stream works better. > > /Tomas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-13 2:55 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20221207093122.553668-1-quinkblack@foxmail.com> 2022-12-07 9:31 ` [FFmpeg-devel] [PATCH v2 1/7] avcodec/mediacodecenc: make each encoder has its own option Zhao Zhili 2022-12-07 9:31 ` [FFmpeg-devel] [PATCH v2 2/7] avcodec/mediacodecenc: add bitrate_mode option Zhao Zhili 2022-12-07 9:31 ` [FFmpeg-devel] [PATCH v2 3/7] avcodec/mediacodecenc: add level option Zhao Zhili 2022-12-07 9:31 ` [FFmpeg-devel] [PATCH v2 4/7] avcodec/mediacodecenc: use bsf to handle crop Zhao Zhili 2022-12-09 17:22 ` [FFmpeg-devel] [PATCH v3 3/7] " Zhao Zhili 2022-12-12 15:27 ` Tomas Härdin 2022-12-13 3:20 ` "zhilizhao(赵志立)" 2022-12-14 17:08 ` Tomas Härdin 2022-12-14 17:19 ` Tomas Härdin 2022-12-14 17:37 ` Zhao Zhili 2022-12-14 17:43 ` Zhao Zhili 2022-12-20 18:24 ` Tomas Härdin 2022-12-21 7:17 ` "zhilizhao(赵志立)" 2022-12-21 10:06 ` Tomas Härdin 2022-12-07 9:31 ` [FFmpeg-devel] [PATCH v2 5/7] avcodec/mediacodecenc: remove the strategy to create DTS Zhao Zhili 2022-12-12 15:28 ` Tomas Härdin 2022-12-13 2:55 ` "zhilizhao(赵志立)" [this message] 2022-12-14 17:31 ` Tomas Härdin 2023-01-04 10:16 ` Anton Khirnov 2023-01-04 11:31 ` [FFmpeg-devel] [Internet]Re: " "zhilizhao(赵志立)" 2023-01-04 13:59 ` Tomas Härdin 2023-01-04 14:46 ` Zhao Zhili 2023-01-04 15:15 ` Anton Khirnov 2023-01-04 16:12 ` Zhao Zhili 2023-01-05 8:07 ` Anton Khirnov 2022-12-07 9:31 ` [FFmpeg-devel] [PATCH v2 6/7] avcodec/mediacodecenc: add max-bframes support Zhao Zhili 2022-12-07 9:31 ` [FFmpeg-devel] [PATCH v2 7/7] avcodec/mediacodecenc: add pts_as_dts option Zhao Zhili
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tencent_F71FDC414B91E61B9093E6EBA7E4AAA9D306@qq.com \ --to=quinkblack@foxmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git