* [FFmpeg-devel] [PATCH v2] videotoolbox: Fix building with older SDKs
@ 2025-03-26 8:53 Martin Storsjö
2025-03-26 11:36 ` Zhao Zhili
0 siblings, 1 reply; 3+ messages in thread
From: Martin Storsjö @ 2025-03-26 8:53 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
The kVTVideoDecoderReferenceMissingErr constant was only added
in the macOS 12 and iOS 15 SDKs. Use a hardcoded value instead
of the named constant, to fix building with older SDKs
after c6214b0d691566c7cb0f2ff5be08a24c3534e5bb.
---
libavcodec/videotoolbox.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
index aaa6129576..a744657957 100644
--- a/libavcodec/videotoolbox.c
+++ b/libavcodec/videotoolbox.c
@@ -728,7 +728,8 @@ static void videotoolbox_decoder_callback(void *opaque,
}
if (!image_buffer) {
- if (status != kVTVideoDecoderReferenceMissingErr)
+ // kVTVideoDecoderReferenceMissingErr, defined since the macOS 12 SDKs
+ if (status != -17694)
vtctx->reconfig_needed = true;
av_log(vtctx->logctx, status ? AV_LOG_WARNING : AV_LOG_DEBUG,
--
2.39.5 (Apple Git-154)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] videotoolbox: Fix building with older SDKs
2025-03-26 8:53 [FFmpeg-devel] [PATCH v2] videotoolbox: Fix building with older SDKs Martin Storsjö
@ 2025-03-26 11:36 ` Zhao Zhili
2025-03-26 20:36 ` Martin Storsjö
0 siblings, 1 reply; 3+ messages in thread
From: Zhao Zhili @ 2025-03-26 11:36 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Mar 26, 2025, at 16:53, Martin Storsjö <martin@martin.st> wrote:
>
> The kVTVideoDecoderReferenceMissingErr constant was only added
> in the macOS 12 and iOS 15 SDKs. Use a hardcoded value instead
> of the named constant, to fix building with older SDKs
> after c6214b0d691566c7cb0f2ff5be08a24c3534e5bb.
LGTM. Thanks for the fix.
> ---
> libavcodec/videotoolbox.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
> index aaa6129576..a744657957 100644
> --- a/libavcodec/videotoolbox.c
> +++ b/libavcodec/videotoolbox.c
> @@ -728,7 +728,8 @@ static void videotoolbox_decoder_callback(void *opaque,
> }
>
> if (!image_buffer) {
> - if (status != kVTVideoDecoderReferenceMissingErr)
> + // kVTVideoDecoderReferenceMissingErr, defined since the macOS 12 SDKs
> + if (status != -17694)
> vtctx->reconfig_needed = true;
>
> av_log(vtctx->logctx, status ? AV_LOG_WARNING : AV_LOG_DEBUG,
> --
> 2.39.5 (Apple Git-154)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] videotoolbox: Fix building with older SDKs
2025-03-26 11:36 ` Zhao Zhili
@ 2025-03-26 20:36 ` Martin Storsjö
0 siblings, 0 replies; 3+ messages in thread
From: Martin Storsjö @ 2025-03-26 20:36 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Wed, 26 Mar 2025, Zhao Zhili wrote:
>
>
>> On Mar 26, 2025, at 16:53, Martin Storsjö <martin@martin.st> wrote:
>>
>> The kVTVideoDecoderReferenceMissingErr constant was only added
>> in the macOS 12 and iOS 15 SDKs. Use a hardcoded value instead
>> of the named constant, to fix building with older SDKs
>> after c6214b0d691566c7cb0f2ff5be08a24c3534e5bb.
>
> LGTM. Thanks for the fix.
Thanks, pushed.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-26 20:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-26 8:53 [FFmpeg-devel] [PATCH v2] videotoolbox: Fix building with older SDKs Martin Storsjö
2025-03-26 11:36 ` Zhao Zhili
2025-03-26 20:36 ` Martin Storsjö
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git