From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] videotoolbox: Fix building with older SDKs
Date: Wed, 26 Mar 2025 19:36:56 +0800
Message-ID: <tencent_F715B8CB9667CD502007CDD7CF82551FA707@qq.com> (raw)
In-Reply-To: <20250326085355.42194-1-martin@martin.st>
> On Mar 26, 2025, at 16:53, Martin Storsjö <martin@martin.st> wrote:
>
> The kVTVideoDecoderReferenceMissingErr constant was only added
> in the macOS 12 and iOS 15 SDKs. Use a hardcoded value instead
> of the named constant, to fix building with older SDKs
> after c6214b0d691566c7cb0f2ff5be08a24c3534e5bb.
LGTM. Thanks for the fix.
> ---
> libavcodec/videotoolbox.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
> index aaa6129576..a744657957 100644
> --- a/libavcodec/videotoolbox.c
> +++ b/libavcodec/videotoolbox.c
> @@ -728,7 +728,8 @@ static void videotoolbox_decoder_callback(void *opaque,
> }
>
> if (!image_buffer) {
> - if (status != kVTVideoDecoderReferenceMissingErr)
> + // kVTVideoDecoderReferenceMissingErr, defined since the macOS 12 SDKs
> + if (status != -17694)
> vtctx->reconfig_needed = true;
>
> av_log(vtctx->logctx, status ? AV_LOG_WARNING : AV_LOG_DEBUG,
> --
> 2.39.5 (Apple Git-154)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-26 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 8:53 Martin Storsjö
2025-03-26 11:36 ` Zhao Zhili [this message]
2025-03-26 20:36 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_F715B8CB9667CD502007CDD7CF82551FA707@qq.com \
--to=quinkblack-at-foxmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git