[FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN

[Zhao Zhili <quinkblack@foxmail.com>]

From: Zhao Zhili <zhilizhao@tencent.com>

During the refactor progress, I have found some serious issues, which
is not resolved by the patchset:

1. Tensorflow backend is broken.

I think it doesn't work since 2021 at least. For example, it destroy a
thread and create a new thread for each frame, and it destroy an invalid
thread at the first frame:


    pthread_join(async_module->thread_id, &status);
    if (status == DNN_ASYNC_FAIL) {
        av_log(ctx, AV_LOG_ERROR, "Unable to start inference as previous inference failed.\n");
        return DNN_GENERIC_ERROR;
    }
    ret = pthread_create(&async_module->thread_id, NULL, async_thread_routine, async_module);


2. Openvino V1 doesn't compile. It doesn't compile and no one complains,
I think it's a hint to just keep the code for V2.

3. Error handling. It's easy to crash with incorrect command line arguments.

I don't have enough test case. Please share your test case and help on test.

Zhao Zhili (9):
  avfilter/dnn: Refactor DNN parameter configuration system
  avfilter/dnn_backend_openvino: Fix free context at random place
  avfilter/dnn_backend_openvino: simplify memory allocation
  avfilter/dnn_backend_tf: Remove one level of indentation
  avfilter/dnn_backend_tf: Fix free context at random place
  avfilter/dnn_backend_tf: Simplify memory allocation
  avfilter/dnn_backend_torch: Simplify memory allocation
  avfilter/dnn: Remove a level of dereference
  avfilter/dnn: Use dnn_backend_info_list to search for dnn module

 libavfilter/dnn/dnn_backend_common.h   |  13 +-
 libavfilter/dnn/dnn_backend_openvino.c | 210 ++++++++++---------------
 libavfilter/dnn/dnn_backend_tf.c       | 194 ++++++++++-------------
 libavfilter/dnn/dnn_backend_torch.cpp  | 112 +++++--------
 libavfilter/dnn/dnn_interface.c        | 107 ++++++++++---
 libavfilter/dnn_filter_common.c        |  38 ++++-
 libavfilter/dnn_filter_common.h        |  37 ++---
 libavfilter/dnn_interface.h            |  73 +++++++--
 libavfilter/vf_derain.c                |   5 +-
 libavfilter/vf_dnn_classify.c          |   3 +-
 libavfilter/vf_dnn_detect.c            |   3 +-
 libavfilter/vf_dnn_processing.c        |   3 +-
 libavfilter/vf_sr.c                    |   5 +-
 13 files changed, 428 insertions(+), 375 deletions(-)

-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".