[FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

[FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

[Stefano Sabatini]

For some samples the pkt->pts is always missing, use the pkt->dts
instead.

Fix trac issue http://trac.ffmpeg.org/ticket/4427.
---
 fftools/ffprobe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index f156663019..8824b1c044 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2844,9 +2844,10 @@ static int read_interval_packets(WriterContext *w, InputFile *ifile,
         }
         if (selected_streams[pkt->stream_index]) {
             AVRational tb = ifile->streams[pkt->stream_index].st->time_base;
+            int64_t pts = pkt->pts != AV_NOPTS_VALUE ? pkt->pts : pkt->dts;
 
-            if (pkt->pts != AV_NOPTS_VALUE)
-                *cur_ts = av_rescale_q(pkt->pts, tb, AV_TIME_BASE_Q);
+            if (pts != AV_NOPTS_VALUE)
+                *cur_ts = av_rescale_q(pts, tb, AV_TIME_BASE_Q);
 
             if (!has_start && *cur_ts != AV_NOPTS_VALUE) {
                 start = *cur_ts;
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

[Stefano Sabatini]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote:
> For some samples the pkt->pts is always missing, use the pkt->dts
> instead.
> 
> Fix trac issue http://trac.ffmpeg.org/ticket/4427.
> ---
>  fftools/ffprobe.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Updated.

[-- Attachment #2: 0001-ffprobe-use-pkt-dts-to-compute-interval-ts-when-pts-.patch --]
[-- Type: text/x-diff, Size: 1228 bytes --]

From 3788035aade64f322f31bd139da8c281a15fa611 Mon Sep 17 00:00:00 2001
From: Stefano Sabatini <stefasab@gmail.com>
Date: Wed, 13 Jul 2022 01:28:33 +0200
Subject: [PATCH 1/2] ffprobe: use pkt->dts to compute interval ts when pts is
 missing

For some samples the pkt->pts is always missing, use the pkt->dts
instead.

Fix trac issue http://trac.ffmpeg.org/ticket/4427.
---
 fftools/ffprobe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index d2f126d9d6..cd824f5ad1 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2859,9 +2859,10 @@ static int read_interval_packets(WriterContext *w, InputFile *ifile,
         }
         if (selected_streams[pkt->stream_index]) {
             AVRational tb = ifile->streams[pkt->stream_index].st->time_base;
+            int64_t pts = pkt->pts != AV_NOPTS_VALUE ? pkt->pts : pkt->dts;
 
-            if (pkt->pts != AV_NOPTS_VALUE)
-                *cur_ts = av_rescale_q(pkt->pts, tb, AV_TIME_BASE_Q);
+            if (pts != AV_NOPTS_VALUE)
+                *cur_ts = av_rescale_q(pts, tb, AV_TIME_BASE_Q);
 
             if (!has_start && *cur_ts != AV_NOPTS_VALUE) {
                 start = *cur_ts;
-- 
2.25.1


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

[Stefano Sabatini]

On date Saturday 2022-12-31 20:26:34 +0100, Stefano Sabatini wrote:
> On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote:
> > For some samples the pkt->pts is always missing, use the pkt->dts
> > instead.
> > 
> > Fix trac issue http://trac.ffmpeg.org/ticket/4427.
> > ---
> >  fftools/ffprobe.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Updated.

Ping. (Also I lost my push permissions, I'm happy to regain my write
access if you know who I should contact/what should I do to get it
back).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1145 bytes --]

On Sun, Jan 15, 2023 at 02:25:40AM +0100, Stefano Sabatini wrote:
> On date Saturday 2022-12-31 20:26:34 +0100, Stefano Sabatini wrote:
> > On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote:
> > > For some samples the pkt->pts is always missing, use the pkt->dts
> > > instead.
> > > 
> > > Fix trac issue http://trac.ffmpeg.org/ticket/4427.
> > > ---
> > >  fftools/ffprobe.c | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > Updated.
> 
> Ping. (Also I lost my push permissions, I'm happy to regain my write
> access if you know who I should contact/what should I do to get it
> back).

you lost your ssh key ?
if so send me a new public ssh key  signed with the gpg key listed in
MAINTAINERs

PS: also tell me if the old key is lost (as in, should be removed)

thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

["zhilizhao(赵志立)"]

> On Jan 1, 2023, at 03:26, Stefano Sabatini <stefasab@gmail.com> wrote:
> 
> On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote:
>> For some samples the pkt->pts is always missing, use the pkt->dts
>> instead.

If some pkt->pts is missing but isn’t always missing, isn’t it mixed
the use of pts and dts? I don’t have a particular case in mind yet.

>> 
>> Fix trac issue http://trac.ffmpeg.org/ticket/4427.
>> ---
>> fftools/ffprobe.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Updated.
> <0001-ffprobe-use-pkt-dts-to-compute-interval-ts-when-pts-.patch>_______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

[Stefano Sabatini]

On date Monday 2023-01-16 11:01:51 +0800, "zhilizhao(赵志立)" wrote:
> 
> > On Jan 1, 2023, at 03:26, Stefano Sabatini <stefasab@gmail.com> wrote:
> > 
> > On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote:
> >> For some samples the pkt->pts is always missing, use the pkt->dts
> >> instead.
> 
> If some pkt->pts is missing but isn’t always missing, isn’t it mixed
> the use of pts and dts? I don’t have a particular case in mind yet.

In the ticket sample, it was missing all the PTSs, so the only time
reference was provided by the DTSs (note that this only affects the
-read_intervals option). I have no better ideas.

> >> 
> >> Fix trac issue http://trac.ffmpeg.org/ticket/4427.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

["zhilizhao(赵志立)"]

> On Jan 17, 2023, at 07:41, Stefano Sabatini <stefasab@gmail.com> wrote:
> 
> On date Monday 2023-01-16 11:01:51 +0800, "zhilizhao(赵志立)" wrote:
>> 
>>> On Jan 1, 2023, at 03:26, Stefano Sabatini <stefasab@gmail.com> wrote:
>>> 
>>> On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote:
>>>> For some samples the pkt->pts is always missing, use the pkt->dts
>>>> instead.
>> 
>> If some pkt->pts is missing but isn’t always missing, isn’t it mixed
>> the use of pts and dts? I don’t have a particular case in mind yet.
> 
> In the ticket sample, it was missing all the PTSs, so the only time
> reference was provided by the DTSs (note that this only affects the
> -read_intervals option). I have no better ideas.

Looks like there is no better choices, patch LGTM.

> 
>>>> 
>>>> Fix trac issue http://trac.ffmpeg.org/ticket/4427.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

[Stefano Sabatini]

On date Tuesday 2023-01-17 10:57:58 +0800, "zhilizhao(赵志立)" wrote:
> > On Jan 17, 2023, at 07:41, Stefano Sabatini <stefasab@gmail.com> wrote:
> > 
> > On date Monday 2023-01-16 11:01:51 +0800, "zhilizhao(赵志立)" wrote:
> >> 
> >>> On Jan 1, 2023, at 03:26, Stefano Sabatini <stefasab@gmail.com> wrote:
> >>> 
> >>> On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote:
> >>>> For some samples the pkt->pts is always missing, use the pkt->dts
> >>>> instead.
> >> 
> >> If some pkt->pts is missing but isn’t always missing, isn’t it mixed
> >> the use of pts and dts? I don’t have a particular case in mind yet.
> > 
> > In the ticket sample, it was missing all the PTSs, so the only time
> > reference was provided by the DTSs (note that this only affects the
> > -read_intervals option). I have no better ideas.
> 
> Looks like there is no better choices, patch LGTM.

Applied.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".