From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 12D7B4BB7D for ; Mon, 15 Jul 2024 08:40:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 83BAD68DA2B; Mon, 15 Jul 2024 11:40:16 +0300 (EEST) Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 386EF68D83C for ; Mon, 15 Jul 2024 11:40:08 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1721032804; bh=KuDOtL38pNpaJtVcznt86hD1QopXmZ3CkNneU6Vkw7I=; h=From:Subject:Date:References:To:In-Reply-To; b=j2Axbrm5ljnwj4nt19QWkK2g+6T4dW5TfhP+zMAid6n7DBNFY1unQPUQJ2Uwpdoi+ xo/OFSEXeeuU+T/o2xngR5qPD++Jm1xXzHAp+gVPwxvn3dhrp4rqc6osfZlaiK6JkB R2rOwNtrgxkBbMWZ1oRnUQl2qMdtbQF3mRUGST0A= Received: from smtpclient.apple ([113.108.77.53]) by newxmesmtplogicsvrszb9-1.qq.com (NewEsmtp) with SMTP id A0300AF0; Mon, 15 Jul 2024 16:40:03 +0800 X-QQ-mid: xmsmtpt1721032803t4gezcwvy Message-ID: X-QQ-XMAILINFO: OP01qWhGSBjQzxQhlOyMh4NyGovMno8xUqae3aapehCA13VUVlj3hR9I3U1Jj0 XV35iY86bp1bxFkPPAt/RuTRmb4RCAzV1VvLwbOd8lCafFJlurE35IOXDqrcWtzu3X7qOBBC8t9u EftLqJYKPj74oVF7KW9xXg/1lDoa1EqTydHRnw1Ce/jzdkYvCyyr6VsIIbfnqb4mtpKJJo+0LZtS F977ItHsbKXM0RuypRUT8YQKZYzyFIFQLCOUxG/lodL8Or2kGJn3Ea/uSM03cBT/B+doZDDoS0PJ I7chUSVMWCvUOdm1KalPjn9arcuKfIjqp+kDyKLbA9xyOeEf7K/IatHlm6ueQ8AWnczBKmZ6J8sI tT+i/7TzpLp42X52GuX+aMfJ/AG1v3NXbwO6ZoFRZ87f2KvhPCk0v670L5469LzpheFHmu32SMNy ZksRtVP8cvtZiv5W62n3/nJD7Q3sUHTz9AvJLoQDeO2kTfCh0vM1upr3+JzyAYoDNTBdfVLt2+tx /MmcA7N1NCnqAGaHJ4PpmvS6iV5FJyzHoopZKlnYzAv03bTNZ0HHUFM/9T3p/suwwiUyuvm2xC3L uHPoCDqDcGn6+C8qkK3FxRWXuNBdf5+K1IhREWhAnQiw4JNRornPaLi5g5E4iRpSHLFgQno6Xn59 bxBe3n7nWQYKLWzvQMZIDOtgB+BUNMEGgaEibQCIqWVesA1nJX+patQcLj7mFlCGhMdkfOhzINvs tN1yM++4GQ8Q0eFv64VyX8p7DZZSRfSA9H0Nri2cPQsWAiITllC05yhyEmvKdeLnSsw/sq5shxKV /AidlZoLMj3X1zGEp46hlhFKxfOGXGjCuVIkDx1GoM6peSe8URz7egNFv4v6CijdetgX0HIKYkrF VS2QDYQl7sV4/4WKjN3Q+waHldVBSByXw1DHfSXo9p1ZWH3S2JMQkOsCbXO8iPbLbdbl38dpH/RP BxK81A/hKMl+8HvDEaEA73JNpNcDhEmig3pE+c/knOPAYKgAROjqSLrJv+xakO X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= From: Zhao Zhili Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Date: Mon, 15 Jul 2024 16:39:52 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <233BB684-350A-48F7-9591-DD9BEF4951FA@foxmail.com> X-Mailer: Apple Mail (2.3774.500.171.1.1) Subject: Re: [FFmpeg-devel] [PATCH 01/11] avdevice/audiotoolbox: fix mixed declaration and code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jul 12, 2024, at 23:44, Marvin Scholz wrote: > > Fix a bunch of "mixing declarations and code is incompatible with > standards before C99" warnings. Rather than fix the warning, can we disable the check for object-c as it's a different language? > --- > libavdevice/audiotoolbox.m | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavdevice/audiotoolbox.m b/libavdevice/audiotoolbox.m > index 7d95c34593..dd607589b4 100644 > --- a/libavdevice/audiotoolbox.m > +++ b/libavdevice/audiotoolbox.m > @@ -77,6 +77,9 @@ static av_cold int at_write_header(AVFormatContext *avctx) > ATContext *ctx = (ATContext*)avctx->priv_data; > OSStatus err = noErr; > CFStringRef device_UID = NULL; > + const char *stream_name = avctx->url; > + AVCodecParameters *codecpar = avctx->streams[0]->codecpar; > + AudioStreamBasicDescription device_format = {0}; > AudioDeviceID *devices; > int num_devices; > > @@ -133,7 +136,6 @@ static av_cold int at_write_header(AVFormatContext *avctx) > > // get user-defined device UID or use default device > // -audio_device_index overrides any URL given > - const char *stream_name = avctx->url; > if (stream_name && ctx->audio_device_index == -1) { > sscanf(stream_name, "%d", &ctx->audio_device_index); > } > @@ -163,10 +165,8 @@ static av_cold int at_write_header(AVFormatContext *avctx) > } > > av_freep(&devices); > - AVCodecParameters *codecpar = avctx->streams[0]->codecpar; > > // audio format > - AudioStreamBasicDescription device_format = {0}; > device_format.mSampleRate = codecpar->sample_rate; > device_format.mFormatID = kAudioFormatLinearPCM; > device_format.mFormatFlags |= (codecpar->format == AV_SAMPLE_FMT_FLT) ? kLinearPCMFormatFlagIsFloat : 0; > @@ -237,6 +237,7 @@ static av_cold int at_write_header(AVFormatContext *avctx) > > static int at_write_packet(AVFormatContext *avctx, AVPacket *pkt) > { > + AudioQueueBufferRef buf; > ATContext *ctx = (ATContext*)avctx->priv_data; > OSStatus err = noErr; > > @@ -256,7 +257,7 @@ static int at_write_packet(AVFormatContext *avctx, AVPacket *pkt) > } > } > > - AudioQueueBufferRef buf = ctx->buffer[ctx->cur_buf]; > + buf = ctx->buffer[ctx->cur_buf]; > > // copy audio data into buffer and enqueue the buffer > memcpy(buf->mAudioData, pkt->data, buf->mAudioDataBytesCapacity); > > base-commit: 85706f5136cf7c88f95843b2634dd3f7d7d2cb6d > -- > 2.39.3 (Apple Git-146) > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".