From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 83ED343A3B for ; Wed, 6 Jul 2022 07:05:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BA14568BA4F; Wed, 6 Jul 2022 10:05:37 +0300 (EEST) Received: from out162-62-58-211.mail.qq.com (out162-62-58-211.mail.qq.com [162.62.58.211]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ED78368B73B for ; Wed, 6 Jul 2022 10:05:29 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1657091127; bh=sq8gQU4UpoFduWW46O6TYnNG+EzH2Re+9FXYZqBcBvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FLlWk96nu78MWjTsAgPDy6av7QVhtjT0RClt7M+bPhMI2zrMEonhGgJQkPvHyyLrI ikYO51amNAc46/xm+lS6nu4xlNHFvlBn6OEq/MUofuQBY2tEH6rEIvumfAq4iy2Iq3 SeMUtmCifCgvuJ06GtnkDGt5UpOaTxYQ4JMCi3YY= Received: from ZHILIZHAO-MB2.tencent.com ([113.108.77.70]) by newxmesmtplogicsvrszc10.qq.com (NewEsmtp) with SMTP id 15A15C29; Wed, 06 Jul 2022 15:05:26 +0800 X-QQ-mid: xmsmtpt1657091126tmuvxqcp5 Message-ID: X-QQ-XMAILINFO: NkHKfw09D6j8kgoB1NY3pFli9ItLC+LE7O1OQGsQ6JGR+lwiZGuetFZW/nti79 mn4EHYmq0xot4OVEz2t//O9MEmwYR2oQ3LwOoXQZWnyp8r1KIMTSQc9YsFlRqmrszv26B+QuAmdu YnQbND8ZPRhJoCZM3tRqCdkRyI054S5crBq3+UbdaF8Uns1J124gAMz+r9t2CMKiPswKYHXiIb9a cBUYy+DWFGkrr+d7Uq844Y6aZ4vg8yjiRF+T4A2sMPqhLfqGtXLqYFk9O8l36QSC7uAKNXTUKK0B t/+hSBQjNx9sz+6WISeEZTndTCgYeTfsULMSxDDKSpxbNAYhz3jiBV5H3DlkNeX4t6FMzHptkKo6 kpI2lznB1wx6j1tZn6LqRDfQZGWnvg+xUXs3Kmnt3fLyOkHUFr0ewAUkQNhhaT5Scx66eR1a5NkE Iyxp3/BqsDPofGEQ6u8//bx4Q4vPTYyOY0/SjQ3Jl9CYc2QbWMvvd7VGeWhtDRB3hmaq/tPXTb1S mb6YtjZT/Ff9Wj0G4hh2OCPtBP0ZcOhwdH37P4NOoTtAZZwffmUHHDkhEfZqX/jbteRgQ8OiO7/H YD8GmPX193WOXOt95PcMJdjVqRfjaESYjjfQOJCDffJ0nNQIdUUB+6AjNp9yxlpn9hyAYPAbhUxR z1tHO25RL+6F6E8zo/I2a/J9jhtW/+AWisAhOuGY39NqY9urkxNtnitrUjh0CwMkwePy/YkyYLzo C39HTnHnzyKHwbhi+hm1kwVB7g3rl4N53YbuphHHTf5PbOp1C1QC4QeUnBiWszHv5aWsfAU1v2ay DU/N4nC7ezS8/KcFjQfu595gudNKG1HHxc3k8HklcCtpUoHMEvZ10kK0STzcwe1hB9Mcfti45snI A1QYKpFNx/Lnwf0leMy/9J8C/ns4JIJdI6yvvXjmrBq4D50RTFJ468OiLXJkCU3bTLQr++cGt++S YfxKUFLKfV+GCpnr5uWIdIQ20ywJNNEhVvzZiPQrx5aaZ+hLsTcbKb2RsaxXE+ From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Wed, 6 Jul 2022 15:05:19 +0800 X-OQ-MSGID: <20220706070519.19060-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <807fffd6-8a8f-e8db-43f2-a3a0c447dbd9@gyani.pro> References: <807fffd6-8a8f-e8db-43f2-a3a0c447dbd9@gyani.pro> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3] avformat/mov: discard data streams with all zero sample_delta X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili Streams with all zero sample_delta in 'stts' have all zero dts. They have higher chance be chose by mov_find_next_sample(), which leads to seek again and again. For example, GoPro created a 'GoPro SOS' stream: Stream #0:4[0x5](eng): Data: none (fdsc / 0x63736466), 13 kb/s (default) Metadata: creation_time : 2022-06-21T08:49:19.000000Z handler_name : GoPro SOS With 'ffprobe -show_frames http://example.com/gopro.mp4', ffprobe blocks until all samples in 'GoPro SOS' stream are consumed first. Signed-off-by: Zhao Zhili --- v3: 'for ffmpeg' -> 'for ffmpeg command.' v2: suggest how to override discard flag in log message. libavformat/mov.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 88669faa70..9a24e5effa 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3062,6 +3062,21 @@ static int mov_read_stts(MOVContext *c, AVIOContext *pb, MOVAtom atom) st->nb_frames= total_sample_count; if (duration) st->duration= FFMIN(st->duration, duration); + + // All samples have zero duration. They have higher chance be chose by + // mov_find_next_sample, which leads to seek again and again. + // + // It's AVERROR_INVALIDDATA actually, but such files exist in the wild. + // So only mark data stream as discarded for safety. + if (!duration && sc->stts_count && + st->codecpar->codec_type == AVMEDIA_TYPE_DATA) { + av_log(c->fc, AV_LOG_WARNING, + "All samples in data stream index:id [%d:%d] have zero " + "duration, stream set to be discarded by default. Override " + "using AVStream->discard or -discard for ffmpeg command.\n", + st->index, st->id); + st->discard = AVDISCARD_ALL; + } sc->track_end = duration; return 0; } -- 2.35.3 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".