From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8FDAF403DC for ; Sat, 19 Feb 2022 08:45:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1991668A905; Sat, 19 Feb 2022 10:45:47 +0200 (EET) Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6C41F6881AC for ; Sat, 19 Feb 2022 10:45:44 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1645260339; bh=e2254+jkAOy7FntYoVfpLXQHF3DixXO3B2zjzX8UMQQ=; h=From:Subject:Date:References:To:In-Reply-To; b=eosaVgBTYsNZcTwKhpaleSVXKNWLyTd0Fn8Bu1t4bYnJDBreKxb8x5tNWl5K2veqV 4BlvYUuZwW/Utj/NUWkw60R6+p3aRVMNLXmygAiEtl8jePkwC1qt0MrH+VHbsx/1xu yageEbOiv3lq9C80D1v8iNxUMUdFZoHafv1qtA6o= Received: from [192.168.255.10] ([119.123.133.65]) by newxmesmtplogicsvrszc9.qq.com (NewEsmtp) with SMTP id B66AC498; Sat, 19 Feb 2022 16:45:38 +0800 X-QQ-mid: xmsmtpt1645260338tsla8rquz Message-ID: X-QQ-XMAILINFO: M5MiK8h9PoyRqIEsjlIwWC6UCmQtYzVf/Ug0RQgx6xtAoixyoNINWhp7Kkg/7N 2WamNf/xkDgMg9XveN+WybPG8xQdOLdPia9scZY0qBl2oWTYxQJTmC7kbjuYLEMo08eN0DgRxdSS weSB5npgBXajSxsURppjuIIgmdhb7ZgJuh8WmirvN5T0lWSdIQrkuA1AF9BaC5z651zav16MSP5u po4FPPm5y5JaXXfPM4XhDSK0i+QjoTrPgXburSaMA5ypGYOin/Rw2BeQfHc/99oBVZEAfdcGeSwF ig93hDQFyiCe53o++tyXPrE06K21zFFJ9y2tushr8SQNSoV4Wi+fWv4HY1l2U2T54Uzidi08sc44 sxibuybwEnKnMUfYFOzAAcbw6m2jeV1TT4a/YlW3EHopM/ZjaMprkhY3oteNXjCRgskCx4X9qHa4 W+DCz3GCfCIh8toXxiSRMED2xNHP8QQ06c9AGQ+yvL4tDSek3ZV45IjjHkNCQVWl3lqRcrMSg0Z2 l8qBfRky+/thpUnH2cKBrKm6pjFAXybwmtJ7Omp1k+K3rNg9HWiI3TgOsVaYLHzbQohbP+TVgVGw 281M+EH0TkycZhrjgY0n6ywW+XKlcwz5TFvYWZjTa6TitA6oMAoi/dOLRCsEPr+4YlpafRssP2cs zmZzbrTL9HhULddmdr0YKiqENsA4NgEAV5Y06JLGYdI9ptVudYspGPXKiY1S1m9qgPrQrCf6OikH l1vIrDyglOEco/1TcbFfvEzm/W16oT9xI+g8JKRxHkrW8QbO1XGmHk58epAfPWs8CRqruCirNbCj IgeO4itl6YTW4CXDzNfeodMqFTqUx/y4NTvFrYuvBbkcUwgLt24rYHEZEztQ2Nvmp1q7/hxtwxbr H0Ih/rsnKq From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Sat, 19 Feb 2022 16:45:38 +0800 References: <722ff81b-e695-4dfb-019b-1d9c3a58ce69@mail.de> <09b61d48-3eb6-486a-d211-acbe6cee2f12@mail.de> To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH 1/2] avdevice/avfoundation: fix memleak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Feb 8, 2022, at 9:05 PM, Andreas Rheinhardt wrote: > > Thilo Borgmann: >> Am 08.02.22 um 13:50 schrieb Andreas Rheinhardt: >>> Thilo Borgmann: >>>> Am 04.02.22 um 17:19 schrieb Zhao Zhili: >>>>> --- >>>>> libavdevice/avfoundation.m | 10 ++++++---- >>>>> 1 file changed, 6 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m >>>>> index 0cd6e646d5..2078c4879c 100644 >>>>> --- a/libavdevice/avfoundation.m >>>>> +++ b/libavdevice/avfoundation.m >>>>> @@ -106,6 +106,7 @@ typedef struct >>>>> int audio_device_index; >>>>> int audio_stream_index; >>>>> + char *url; >>>>> char *video_filename; >>>>> char *audio_filename; >>>>> @@ -299,6 +300,7 @@ static void destroy_context(AVFContext* ctx) >>>>> ctx->avf_delegate = NULL; >>>>> ctx->avf_audio_delegate = NULL; >>>>> + av_freep(&ctx->url); >>>>> av_freep(&ctx->audio_buffer); >>>> >>>> Why carry it in the context instead of adding the missing av_freep() in >>>> parse_device_name() ? >>>> >>> >>> Because video_filename and audio_filename point into it. >> >> Wondering if we couldn't skip av_strdup() and operate on s->url directly >> then. >> > > This would trash s->url. Ping. Can this patch set be applied? > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".