From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 0/4] Add hevc alpha layer decoding basic support
Date: Tue, 28 Feb 2023 17:00:15 +0800
Message-ID: <tencent_EC5C694E00796AD67D06AD4639F1C031B60A@qq.com> (raw)
In-Reply-To: <tencent_4EDE407C9A429F12ABA44E0370132D5C9A08@qq.com>
> On Jan 6, 2023, at 23:52, Zhao Zhili <quinkblack@foxmail.com> wrote:
>
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> v2:
> 1. Check vps_max_layers and vps_max_layer_id inside hevc decoder
> 2. Add hevc_extract_layer bsf to do the job rather than modifing hevc_metadata,
> 3. Check vps_max_layers_minus1 and vps_max_layer_id inside bsf
> 4. Update vps_max_layers_minus1 and vps_max_layer_id when rewrite as base layer
> 5. vps_extension should be updated rather than drop entirely, add a TODO
Will push soon if there's no objections.
>
> ---------------------------------------------
> 1. Don't drop nal->nuh_layer_id > 0 until decoder.
> 2. Make hevcdec able to decode a selected layer.
> 3. Add hevc_extract_layer bsf to extract a selected layer.
>
> Partially fix #7965. There is a sample in ticket #7965 which can be used to test
> the patchset. Or use videotoolbox encoder to create a sample (FFmpeg needs to be
> patched first, "avutil/hwcontext_videotoolbox: BGRA should be full range"
> http://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305252.html), e.g.,
>
> ./ffmpeg -i cctv.mp4 \
> -i pig.mp4 \
> -c:v hevc_videotoolbox \
> -alpha_quality 0.75 \
> -filter_complex '[1:v]scale=640x480[v1];[0:v][v1]alphamerge[v2]' \
> -map [v2] -an -t 60 \
> -pix_fmt bgra \
> -b:v 4M \
> -tag:v hvc1 \
> alpha.mp4 -y
>
>
> Now it's able to use two decoders to decode the base layer and alpha
> layer, and then combine the results, e.g.,
>
> ./ffmpeg -i alpha.mp4 \
> -strict -2 -nuh_layer_id 1 -i alpha.mp4 \
> -frames 60 \
> -filter_complex '[0:v][1:v]alphamerge[vout]' \
> -map '[vout]' -an test-%d.png
>
> It only works with software decoder.
>
> hevc_extract_layer can be used together with hardware decoder. The following
> example is how to extract the alpha layer and rewrite as base layer:
>
> ./ffmpeg -i alpha.mp4 \
> -an -c:v copy \
> -bsf:v hevc_extract_layer=nuh_layer_id=1 \
> test.mp4
>
> Zhao Zhili (4):
> avcodec/hevc_parse: keep nal->nuh_layer_id > 0
> avcodec/cbs_h2645: keep nal->nuh_layer_id > 0
> avcodec/hevcdec: add nuh_layer_id option
> avcodec: add hevc_extract_layer bsf
>
> configure | 1 +
> doc/bitstream_filters.texi | 12 +++
> libavcodec/Makefile | 1 +
> libavcodec/bitstream_filters.c | 1 +
> libavcodec/cbs_h2645.c | 3 -
> libavcodec/hevc_extract_layer_bsf.c | 126 ++++++++++++++++++++++++++++
> libavcodec/hevc_parse.c | 2 -
> libavcodec/hevcdec.c | 56 ++++++++++++-
> libavcodec/version.h | 2 +-
> 9 files changed, 197 insertions(+), 7 deletions(-)
> create mode 100644 libavcodec/hevc_extract_layer_bsf.c
>
> --
> 2.25.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-28 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 15:52 Zhao Zhili
2023-02-28 9:00 ` "zhilizhao(赵志立)" [this message]
2023-03-02 10:11 ` Anton Khirnov
2023-03-02 10:41 ` "zhilizhao(赵志立)"
2023-03-14 13:30 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_EC5C694E00796AD67D06AD4639F1C031B60A@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git