* [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add low latency decoding
@ 2023-05-22 6:52 xufuji456
2023-05-22 8:44 ` "zhilizhao(赵志立)"
0 siblings, 1 reply; 3+ messages in thread
From: xufuji456 @ 2023-05-22 6:52 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: xufuji456
The low-latency decoding mode has available in Android api 30.
See https://developer.android.google.cn/reference/android/media/MediaCodec?hl=en#PARAMETER_KEY_LOW_LATENCY
Signed-off-by: xufuji456 <839789740@qq.com>
---
libavcodec/mediacodecdec.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c
index 21464900d1..52c30e1173 100644
--- a/libavcodec/mediacodecdec.c
+++ b/libavcodec/mediacodecdec.c
@@ -395,6 +395,12 @@ static av_cold int mediacodec_decode_init(AVCodecContext *avctx)
ff_AMediaFormat_setInt32(format, "width", avctx->width);
ff_AMediaFormat_setInt32(format, "height", avctx->height);
+ sdk_int = ff_Build_SDK_INT(avctx);
+ // low-latency mode: available in Android api 30
+ if (sdk_int >= 30 && (avctx->flags & AV_CODEC_FLAG_LOW_DELAY)) {
+ ff_AMediaFormat_setInt32(format, "low-latency", 1);
+ }
+
s->ctx = av_mallocz(sizeof(*s->ctx));
if (!s->ctx) {
av_log(avctx, AV_LOG_ERROR, "Failed to allocate MediaCodecDecContext\n");
@@ -414,7 +420,6 @@ static av_cold int mediacodec_decode_init(AVCodecContext *avctx)
"MediaCodec started successfully: codec = %s, ret = %d\n",
s->ctx->codec_name, ret);
- sdk_int = ff_Build_SDK_INT(avctx);
/* ff_Build_SDK_INT can fail when target API < 24 and JVM isn't available.
* If we don't check sdk_int > 0, the workaround might be enabled by
* mistake.
--
2.32.0 (Apple Git-132)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add low latency decoding
2023-05-22 6:52 [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add low latency decoding xufuji456
@ 2023-05-22 8:44 ` "zhilizhao(赵志立)"
2023-05-22 9:32 ` =?gb18030?B?0Oy4o8Kh?=
0 siblings, 1 reply; 3+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-05-22 8:44 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: 徐福隆
> On May 22, 2023, at 14:52, xufuji456 <839789740@qq.com> wrote:
>
> The low-latency decoding mode has available in Android api 30.
> See https://developer.android.google.cn/reference/android/media/MediaCodec?hl=en#PARAMETER_KEY_LOW_LATENCY
>
> Signed-off-by: xufuji456 <839789740@qq.com>
> ---
> libavcodec/mediacodecdec.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c
> index 21464900d1..52c30e1173 100644
> --- a/libavcodec/mediacodecdec.c
> +++ b/libavcodec/mediacodecdec.c
> @@ -395,6 +395,12 @@ static av_cold int mediacodec_decode_init(AVCodecContext *avctx)
> ff_AMediaFormat_setInt32(format, "width", avctx->width);
> ff_AMediaFormat_setInt32(format, "height", avctx->height);
>
> + sdk_int = ff_Build_SDK_INT(avctx);
> + // low-latency mode: available in Android api 30
> + if (sdk_int >= 30 && (avctx->flags & AV_CODEC_FLAG_LOW_DELAY)) {
> + ff_AMediaFormat_setInt32(format, "low-latency", 1);
> + }
> +
Please remove the check on api level. ff_Build_SDK_INT() can fail,
and set an unknown option for api level < 30 should be fine.
> s->ctx = av_mallocz(sizeof(*s->ctx));
> if (!s->ctx) {
> av_log(avctx, AV_LOG_ERROR, "Failed to allocate MediaCodecDecContext\n");
> @@ -414,7 +420,6 @@ static av_cold int mediacodec_decode_init(AVCodecContext *avctx)
> "MediaCodec started successfully: codec = %s, ret = %d\n",
> s->ctx->codec_name, ret);
>
> - sdk_int = ff_Build_SDK_INT(avctx);
> /* ff_Build_SDK_INT can fail when target API < 24 and JVM isn't available.
> * If we don't check sdk_int > 0, the workaround might be enabled by
> * mistake.
> --
> 2.32.0 (Apple Git-132)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add low latency decoding
2023-05-22 8:44 ` "zhilizhao(赵志立)"
@ 2023-05-22 9:32 ` =?gb18030?B?0Oy4o8Kh?=
0 siblings, 0 replies; 3+ messages in thread
From: =?gb18030?B?0Oy4o8Kh?= @ 2023-05-22 9:32 UTC (permalink / raw)
To: =?gb18030?B?RkZtcGVnIGRldmVsb3BtZW50IGRpc2N1c3Npb25zIGFuZCBwYXRjaGVz?=
Cc: =?gb18030?B?InpoaWxpemhhbyjV1Na+waIpIg==?=
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 3546 bytes --]
Ok, I will remove checking about api.
------------------ Original ------------------
From: ""zhilizhao(ÕÔÖ¾Á¢)"" <quinkblack@foxmail.com>;
Date: Mon, May 22, 2023 04:44 PM
To: "FFmpeg development discussions and patches"<ffmpeg-devel@ffmpeg.org>;
Cc: "Ð츣¡"<839789740@qq.com>;
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add low latency decoding
> On May 22, 2023, at 14:52, xufuji456 <839789740@qq.com> wrote:
>
> The low-latency decoding mode has available in Android api 30.
> See https://developer.android.google.cn/reference/android/media/MediaCodec?hl=en#PARAMETER_KEY_LOW_LATENCY
>
> Signed-off-by: xufuji456 <839789740@qq.com>
> ---
> libavcodec/mediacodecdec.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c
> index 21464900d1..52c30e1173 100644
> --- a/libavcodec/mediacodecdec.c
> +++ b/libavcodec/mediacodecdec.c
> @@ -395,6 +395,12 @@ static av_cold int mediacodec_decode_init(AVCodecContext *avctx)
> ff_AMediaFormat_setInt32(format, "width", avctx->width);
> ff_AMediaFormat_setInt32(format, "height", avctx->height);
>
> + sdk_int = ff_Build_SDK_INT(avctx);
> + // low-latency mode: available in Android api 30
> + if (sdk_int >= 30 && (avctx->flags & AV_CODEC_FLAG_LOW_DELAY)) {
> + ff_AMediaFormat_setInt32(format, "low-latency", 1);
> + }
> +
Please remove the check on api level. ff_Build_SDK_INT() can fail,
and set an unknown option for api level < 30 should be fine.
> s->ctx = av_mallocz(sizeof(*s->ctx));
> if (!s->ctx) {
> av_log(avctx, AV_LOG_ERROR, "Failed to allocate MediaCodecDecContext\n");
> @@ -414,7 +420,6 @@ static av_cold int mediacodec_decode_init(AVCodecContext *avctx)
> "MediaCodec started successfully: codec = %s, ret = %d\n",
> s->ctx->codec_name, ret);
>
> - sdk_int = ff_Build_SDK_INT(avctx);
> /* ff_Build_SDK_INT can fail when target API < 24 and JVM isn't available.
> * If we don't check sdk_int > 0, the workaround might be enabled by
> * mistake.
> --
> 2.32.0 (Apple Git-132)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-22 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-22 6:52 [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: add low latency decoding xufuji456
2023-05-22 8:44 ` "zhilizhao(赵志立)"
2023-05-22 9:32 ` =?gb18030?B?0Oy4o8Kh?=
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git