From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9B87C441F7 for ; Thu, 2 Feb 2023 08:52:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 43F3568BC86; Thu, 2 Feb 2023 10:52:56 +0200 (EET) Received: from out162-62-57-137.mail.qq.com (out162-62-57-137.mail.qq.com [162.62.57.137]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D4E968AC3F for ; Thu, 2 Feb 2023 10:52:48 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1675327964; bh=5NjBSHUM1DptCje5c3BNR2X1QfeGQXHyDpwOZyjI6Vo=; h=From:Subject:Date:References:To:In-Reply-To; b=mAMhV+wApcgrC3YmQtEahvDAXbAlsKsDvz4JGv9ozHKSUqrRRTx8dQSy3pF1X7P2U B1k8sVbW7LIRpvJyJL7VCUKBlWXwDKcnFY8g61XBE1On4j7zh8zvp/P4hVkLfxSYs+ 0ImMR0Cm6gX+u7C1WE9jIufpr9t8ij6rZxXUpxg0= Received: from smtpclient.apple ([113.108.77.52]) by newxmesmtplogicsvrszc2-0.qq.com (NewEsmtp) with SMTP id D2BA48FD; Thu, 02 Feb 2023 16:52:43 +0800 X-QQ-mid: xmsmtpt1675327963twljh1asx Message-ID: X-QQ-XMAILINFO: Nq1uWKlIb9DMCyXs43hXKHbygIv0uqLZeQWOiCzF08A4Eh4Q0M1YwonB95xpM7 YOdMh61XfR44D69zgB3kcQ7T7usAXgC4/cVt+h6J9/RmoW4D9FjxG7pOvApQAsjCBYCiPUfbE7pY KyKVMAFYk0ZyFI7kHRU5bUxhhPC+zwILG7Ih4GyId1GeWjlf4rY39Q9j7PxUGDQL5x656HUikq+E LPHg2i7NA1fo1AcL4zibXsRIU29Vf9ZmO5ueVv4NEFSRkwIkTNNbs2CGQxPOcrf8VDOmy7d6Mo/a VMhxfDvrHFQYZx9AcsOAOJHy98CnE2lflNZpr4yJfkghg3/jmJ/Y8SLMRRB8mSz2cDVNtdPhcDmG nvtLWSf153XXYzgV1MBUnKQNE5+U5gfsL9Ik3YMtGUSLxyBe4uvLueGP5hcZfdLBM7xzlgJHWQ1Z l97BZ05QbmHwy5SqvB40bYk6spEDm4MKoXV7l7p0VzvbLMYbx7acAUDbwqZeXWORMIyFRKfIS2N2 JF+Q48ikbix1pRDwhZ9oHgFJO4rrr3MULT4Er7PQVBWQf+DrQBCgzBPiLRhj53u0V7zw3AUSb+CB +YZzbWoJWs1s0aFbu0/fhP8oks33cj54oS2eMAtkvbCMh1n4/0LoWLw5+lUD3U49erCpcwZYeMdN RrXXcvYv/TOyGICEAtATlnRFxzjt8foYbTaZTHDGspJ87ZrnEWy0pzSnBY6WMPP9OUI4Af87uEJU 8yDCBEIB8IOaaeshsxS57to1L5Km5vm/1OsxeH/S/rXvP49Q/lJknJbp4WHyapAlzGYMsD6HQWaF H8m5kV5cepuiwheLkKrPwXIsYcIQ19a96BQ3geo+vmAXnpysaNAKL/h2JzFM7naFlTzujcWWP34S QiSsHWi9k5heyYreXaSmO2wXDu+372dl6Dca7NL9wRnhoQkwf6QzbzLyR0f+U5GVCJMB/du/BaRu AYPu2f1rJaYlVW5bksfJ1/hoyvBS7UjD6Tbvpjm1JMK93il21nTisBnEA+gPnu From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Thu, 2 Feb 2023 16:52:43 +0800 References: <20230128135818.387953-1-leo.izen@gmail.com> <20230202070208.1962086-1-quinkblack@foxmail.com> <167532576618.13393.12797931957164785656@lain.khirnov.net> To: FFmpeg development discussions and patches In-Reply-To: <167532576618.13393.12797931957164785656@lain.khirnov.net> X-OQ-MSGID: <9FC238E5-EB7F-46F0-9F73-A3F7EB47BC25@foxmail.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [FFmpeg-devel] [PATCH major bump 1/6] libavutil/hdr_dynamic_vivid_metadata: fix AVHDRVividColorToneMappingParams X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Feb 2, 2023, at 16:16, Anton Khirnov wrote: > > Quoting Zhao Zhili (2023-02-02 08:02:03) >> From: Zhao Zhili >> >> There are two group of three_Spline params. Fix the struct >> definition and usecases inside libavcodec, libavfilter and ffprobe. >> >> Co-Author: Houxiang ZHU >> Signed-off-by: Zhao Zhili >> --- >> diff --git a/libavutil/hdr_dynamic_vivid_metadata.h b/libavutil/hdr_dynamic_vivid_metadata.h >> index a34f83072c..4ceddc539d 100644 >> --- a/libavutil/hdr_dynamic_vivid_metadata.h >> +++ b/libavutil/hdr_dynamic_vivid_metadata.h >> @@ -126,42 +126,42 @@ typedef struct AVHDRVividColorToneMappingParams { >> * The mode of three Spline. the value shall be in the range >> * of 0 to 3, inclusive. >> */ >> - int three_Spline_TH_mode; >> + int three_Spline_TH_mode[2]; >> >> /** >> * three_Spline_TH_enable_MB is in the range of 0.0 to 1.0, inclusive >> * and in multiples of 1.0/255. >> * >> */ >> - AVRational three_Spline_TH_enable_MB; >> + AVRational three_Spline_TH_enable_MB[2]; >> >> /** >> * 3Spline_TH_enable of three Spline. >> * The value shall be in the range of 0.0 to 1.0, inclusive. >> * and in multiples of 1.0/4095. >> */ >> - AVRational three_Spline_TH_enable; >> + AVRational three_Spline_TH_enable[2]; >> >> /** >> * 3Spline_TH_Delta1 of three Spline. >> * The value shall be in the range of 0.0 to 0.25, inclusive, >> * and in multiples of 0.25/1023. >> */ >> - AVRational three_Spline_TH_Delta1; >> + AVRational three_Spline_TH_Delta1[2]; >> >> /** >> * 3Spline_TH_Delta2 of three Spline. >> * The value shall be in the range of 0.0 to 0.25, inclusive, >> * and in multiples of 0.25/1023. >> */ >> - AVRational three_Spline_TH_Delta2; >> + AVRational three_Spline_TH_Delta2[2]; >> >> /** >> * 3Spline_enable_Strength of three Spline. >> * The value shall be in the range of 0.0 to 1.0, inclusive, >> * and in multiples of 1.0/255. >> */ >> - AVRational three_Spline_enable_Strength; >> + AVRational three_Spline_enable_Strength[2]; >> } AVHDRVividColorToneMappingParams; > > A major bump is not for breaking APIs however you like, only for things > that were scheduled in advance that our callers could have prepared for. > You should add new fields, not change existing ones. > Also, the documentation and doc/APIchanges need to be updated. Adding new fields works, but very ugly. The code never work if three_Spline_num > 1. Breaking API to let user notice that may not be a bad thing in this specific situation. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".