From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Extract av_hls_codec_attr
Date: Fri, 3 Nov 2023 13:28:20 +0800
Message-ID: <tencent_E6564E7670E72DD39A42409E9AAD9F05AB08@qq.com> (raw)
In-Reply-To: <CABWZ6OQ8rqjkEM3M4OWbOgwELtq0HC4r849Fv+-jTufy=e-EnQ@mail.gmail.com>
> 在 2023年11月3日，下午1:21，Romain Beauxis <romain.beauxis@gmail.com> 写道：
>
> Le mar. 31 oct. 2023 à 11:47, Zhao Zhili <quinkblack@foxmail.com> a écrit :
>>
>>
>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Romain Beauxis
>>> Sent: 2023年10月30日 9:06
>>> To: ffmpeg-devel@ffmpeg.org
>>> Cc: Romain Beauxis <toots@rastageeks.org>
>>> Subject: [FFmpeg-devel] [PATCH] Extract av_hls_codec_attr
>>>
>>> The logic for extracting HLS codec attribute strings is very useful and
>>> can be re-used in many different situations when working with HLS
>>> streams using libavcodec/libavformat.
>>>
>>> This patch extracts the function's code and places it into a publicly
>>> available function.
>>
>> I don't think the implementation is complete enough to be exported as
>> an API. And the ad-hoc API needs some design too.
>
> I am not in a position to dispute this assessment but I would say it
> could be a "build it and they will come" kind of situation (or chicken
> and egg too).
Maybe it’s fine for internal implementation, but dangerous for API.
>
>>>
>>> ---
>>> libavcodec/Makefile | 2 +
>>> libavcodec/hls.c | 105 +++++++++++++++++++++++++++++++++++++++++++
>>> libavcodec/hls.h | 42 +++++++++++++++++
>>> libavformat/hlsenc.c | 83 +++-------------------------------
>>> 4 files changed, 155 insertions(+), 77 deletions(-)
>>> create mode 100644 libavcodec/hls.c
>>> create mode 100644 libavcodec/hls.h
>>>
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-dev
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-11-03 5:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 1:05 Romain Beauxis
2023-10-31 13:28 ` Michael Niedermayer
2023-11-03 5:20 ` Romain Beauxis
2023-10-31 16:47 ` Zhao Zhili
2023-11-03 5:21 ` Romain Beauxis
2023-11-03 5:28 ` Zhao Zhili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_E6564E7670E72DD39A42409E9AAD9F05AB08@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git