From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 80A61436E7 for ; Fri, 24 Jun 2022 06:59:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 161C368B619; Fri, 24 Jun 2022 09:59:05 +0300 (EEST) Received: from out203-205-221-239.mail.qq.com (out203-205-221-239.mail.qq.com [203.205.221.239]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 95DFD68B201 for ; Fri, 24 Jun 2022 09:58:57 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1656053931; bh=/yaE6XlBsk8RlYvv2akHQ0XmZINmPHXiKuKpwdIh/0c=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=IQ0jhoTSyXxJeXr974ZrcntwOXkAGU8VnK1UZTz/LQ7oxaV6sff9LjoMvB1iXURlH +it3OSmTSQFMGZzUStM/xilNVWug7degw2NnMSIFytf9SgoByXa25598pFMv7GSAu3 KKbS7cEXnWvnztMsVWc5C1WiCsKZnqqIqv9XNksI= Received: from [192.168.255.10] ([59.37.125.123]) by newxmesmtplogicsvrszc11.qq.com (NewEsmtp) with SMTP id EB22686C; Fri, 24 Jun 2022 14:58:50 +0800 X-QQ-mid: xmsmtpt1656053930t8sa71978 Message-ID: X-QQ-XMAILINFO: M8o/yLUHYa2bKKdeEXeiWS8cu8LhoQkPeqN8sN+j+LCp7LvDWg80fpZFCcPSoD rQvouOctS8StU42cxNVsERpkHugVkWaEasQIFNVxnSHo4AzvwBZVod4YdbgzrbsHmadWci1JFUub U30i9J537B3PR8VPu/U5bQARKVuL+DEAKDftHrIEMVYH6H+tfma+QqcYH4nWTJfUiYYGldVXoYrv +gYMfP8Im0SIqucMDITO4l9cdVJvgMXq8euy+CbQFB2SzQSVKlqOXC2I8JkQDXzpQTV1nTNiApgr 1YJYe3pvlei7s8C4SQCppN5MdDPiNC41kn8wy8bHwWot2eVhrD/7EaQZueCS/rjlWtLm3UiEJlv9 0/yKCzfLxRpE6zMOc7dqhW/0WtjXyKsjxGgINECrSAqHHAT+DxOhUHXWMnRtlOC2DzNtBwlmkp35 uKYjVAuwXM5sues25aSHEy9FED+vbs7/RwmeKrKmpxm2OsUw8Ajx/XezMjmuqbb7y0eIs/SBlftW ivH608bi9XGkd6PtWQs/LNBQvKqMt3eiAtNYeUctMpOFSTC80/ZqyoME7gQf7o4peD9HR+uLt9Lp B4QYV712rVuw2RgVHxWVSq1473AkGvzMWeRJDkXJQSE42KhCbBqAx0hUvzexdW5Uuw7KP1nkxsSa 8URNh1Cg3S98oQ3cvFPIuxiUirWDalBfjIw2WRy7p6Y3Q0uKdrKiymYvVn4FrWjyT+8PiwI+dwEJ MgmzJBB07ar2+agQ8oGmE7Sa9Nj5q5gKzdslV628+6qkNGe/9x237+wuPjiEDnYCfxPvzQLwKCPX hGTbrSS49IJ5tqfMplJpL0fp26OFDSkyV2vqz9C2SJP4RC9VCznwGdkoTn2lu5VEZ+4XGbtj1eIg spomEAYXYfRdmR2SxV5QusZtCddEeDeFBbsvJDw1Z0uxL+PlYaa4phMeo82BpZ7aUzOruqsd6Uiy B9oR04J8k= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= In-Reply-To: <20220624055957.48149-1-lq@chinaffmpeg.org> Date: Fri, 24 Jun 2022 14:58:49 +0800 X-OQ-MSGID: References: <20220624055957.48149-1-lq@chinaffmpeg.org> To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/audiotoolboxenc: return external error if encode failed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jun 24, 2022, at 1:59 PM, Steven Liu wrote: > > because the AudioConverterFillComplexBuffer can return 0 or 1 if > success. > so set the ret to 0 it AudioConverterFillComplexBuffer success and > return ret value for success or return AVERROR_EXTERNAL when > AudioConverterFillComplexBuffer failed. > BTW change the error message log level from warning to error. > > Signed-off-by: Steven Liu > --- > libavcodec/audiotoolboxenc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/audiotoolboxenc.c b/libavcodec/audiotoolboxenc.c > index f8305ab89b..00293154bf 100644 > --- a/libavcodec/audiotoolboxenc.c > +++ b/libavcodec/audiotoolboxenc.c > @@ -554,11 +554,13 @@ static int ffat_encode(AVCodecContext *avctx, AVPacket *avpkt, > avctx->frame_size, > &avpkt->pts, > &avpkt->duration); > + ret = 0; > } else if (ret && ret != 1) { > - av_log(avctx, AV_LOG_WARNING, "Encode error: %i\n", ret); > + av_log(avctx, AV_LOG_ERROR, "Encode error: %i\n", ret); > + ret = AVERROR_EXTERNAL; > } > > - return 0; > + return ret; > } > LGTM. > static av_cold void ffat_encode_flush(AVCodecContext *avctx) > -- > 2.25.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".