From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8069B44C40 for ; Wed, 14 Dec 2022 12:40:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0FEC968BB37; Wed, 14 Dec 2022 14:40:23 +0200 (EET) Received: from out203-205-221-210.mail.qq.com (out203-205-221-210.mail.qq.com [203.205.221.210]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 91CE368A927 for ; Wed, 14 Dec 2022 14:40:14 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1671021607; bh=8Ah69iGTjBisgS9bM+2PBqzH4BV9a36d9IYPhTF08GE=; h=From:Subject:Date:References:To:In-Reply-To; b=fuq4pCL/qEwTbCRP7YjEwV0LEgLkqZEfXLwmbwW5QX6nVtkJweeq3jMSETsJDLnAo hdFIidpYP7VPZvnt2VVKBQ9801+VeEdoeC+JVOyqMl0ur/GD1enEmCP7IbLmaC6XZo IL1Ih4cWd4s0jhakIUTrbXZqHEgx8/emSA4F7WRE= Received: from smtpclient.apple ([119.147.10.202]) by newxmesmtplogicsvrszc2-0.qq.com (NewEsmtp) with SMTP id A063106A; Wed, 14 Dec 2022 20:40:06 +0800 X-QQ-mid: xmsmtpt1671021606tmb1vxyu7 Message-ID: X-QQ-XMAILINFO: NsaAmeczaimWBV2d/eU6neS0zeCvU8egDbXYnofzQ7mfimo1VwVcwOGpZZkoZz aWTgSYo+FuwP3ikuBgxj1xSzn/8tPzBfdAhvNkiDyYYzNwq0tw6Ha6Q3EZB2I2aH5/ozfFgUNsrK RCdmDDLwLLfAFd2ZUtFH6hY23esdu98JDdeIQvt48KMQQ8T9DpmjUBDpg38DSCwN78BfNdWf4ni9 OxC1Q7XWNuH9Qm7XvZDAXVlSd3HKb3wvk2fZeI9kUm2gjnj1zebefG5W1M2eVl1wVEe6EmtHJ8vM VPdae5C2TNzl1dqbdMymrLRFoAMJyggjOt/U2JETih7k3MW3p4C7sJb4HX9eDmjRKsj35CSIc9NS B7C2YGwsXuUKTvRxu3BZtg8hF8D5oMWWHIiZVedpOZXTbqFRuuHGOyMnAuZrDHQLPjN/U3Q3YUUn XOIdikNY8DBDKXTD3jjmWFTQrRsFgErlQZIZyviHweT1NWTwTcXEUrBhmJNUz/ADY+n+HEF5ZrGR 67x6V+OYV72P0czoI/cpjfPAVl8M6QJuc6pv7Sal9YEzBzV9TIII/oIaHveL2YlU4cU12avY/JZN hSDVI1Tj8WqsFCJK/aooNcr9x21GgNoNDviH2IuM+ZbmC9jin8SXSkgu/9k2wn+QpPTtp9S+ZoQr jKigV4sm05oGFkunbGcMHFcN2ByNj16wnAH96gaODIZHDXmdLyS8Knle3R0z8eUyrASOJ42xD0U+ v3gXLC9TdZNetnD1BHDmEEGnvt+33n3sHEwW47/nER9tZUkCLImgcbMvo29ffzT1ywTfcFd30wKk 0nkj3FR0ukBOLSCEyQO7tDEH+8nesE8vOA6pK+R3y62TQURabOxo/djTP4LwPlgGqY1yz4w+WTuK kiVHHWHHHAFwMnEotUzo/6MveMm+sbap6KQ6XPRQqzEQ73boKFydialtbmFc/wqGE2lA6iTuRUBf xpJ6eJwJ47RES1pEurEcaPkF7mL4/yYXIt+DVxcDw= From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Wed, 14 Dec 2022 20:40:05 +0800 References: <20221214115819.1886-1-ffmpeg@gyani.pro> To: FFmpeg development discussions and patches In-Reply-To: <20221214115819.1886-1-ffmpeg@gyani.pro> X-OQ-MSGID: X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: correct write_colr warning placement X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Dec 14, 2022, at 19:58, Gyan Doshi wrote: > > The old warning is no longer applicable in the inner block after > c5b20cfe19. > --- > libavformat/movenc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 7b00e65cdd..c427109609 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -2330,10 +2330,11 @@ static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex > av_stream_get_side_data(track->st, AV_PKT_DATA_ICC_PROFILE, NULL)) { > int prefer_icc = mov->flags & FF_MOV_FLAG_PREFER_ICC || !has_color_info; > mov_write_colr_tag(pb, track, prefer_icc); > - } else if (mov->flags & FF_MOV_FLAG_WRITE_COLR) { > - av_log(mov->fc, AV_LOG_WARNING, "Not writing 'colr' atom. Format is not MOV or MP4.\n"); > } > + } else if (mov->flags & FF_MOV_FLAG_WRITE_COLR) { > + av_log(mov->fc, AV_LOG_WARNING, "Not writing 'colr' atom. Format is not MOV or MP4 or AVIF.\n"); LGTM except the indentation. > } > + > if (track->mode == MODE_MOV || track->mode == MODE_MP4) { > mov_write_clli_tag(pb, track); > mov_write_mdcv_tag(pb, track); > -- > 2.36.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".