From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 48BCC4043E for ; Thu, 22 Sep 2022 11:50:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6B93A68BBA3; Thu, 22 Sep 2022 14:50:30 +0300 (EEST) Received: from out162-62-57-137.mail.qq.com (out162-62-57-137.mail.qq.com [162.62.57.137]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 22BF468B9CB for ; Thu, 22 Sep 2022 14:50:23 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1663847418; bh=kIEr5OLl2id1RUsTN8G1SsEAulzTCEsP5PVwo0zc7xU=; h=From:Subject:Date:References:To:In-Reply-To; b=f7V4qedRBA7P9nJOkE3Qh0sCLgSHQA3e9V631Rz+t2/Ox7MvkpKs7lVYOs8sxaMUu q0zJfyeucBBsTlMQ6N/MqhLDp3h9BAbQ1TMzd46QaRpg5xZhHzKmGhzvLj4ND/fswm HAxz/gX31CT3vL27PLMbTmzgZnLc3iSMP7Qz3Ujw= Received: from smtpclient.apple ([119.147.10.195]) by newxmesmtplogicsvrsza9.qq.com (NewEsmtp) with SMTP id C91AB81E; Thu, 22 Sep 2022 19:50:17 +0800 X-QQ-mid: xmsmtpt1663847417tsemsz96a Message-ID: X-QQ-XMAILINFO: Mm0jDPjQYDdll4NsEOXUxI5n34AnqOiQewWzg6p4tPg8FTeIbEY5MSVpSCKI/n hp/eKwQ5vQk+S4HMlhKQr1HqfZ/c/zVOAsIooC/O+5uDLquyjLWm3XKIbngp+hAhXl9wL4wFHrro gags4e2+ByFtmpgDyKV/b6lbzOc1LbssSM55tYTfRBSiKxaVmi6pmOhzHeMxtEkM5IHdHxiCTjDN Jy5hN21sBAz9bvIwuMjhpetIgtSKRVDMWLeOsKLAm5Y8wr+agB5/ctWynuwz8YdrNHyHivwfTgoM BEBob0Bgp6dwfuQ7ZssL3AkT6Id/4iiBOkrZdUELwe25o+8q8tZBZWLf9EIEZk3h9pf39aiRryO1 X06p0fzW3720E3KitXxLK7hdyFjj62KyfW/c1kA0PCTh3P4MoEVbW8Ud2AsPbGastvm3LWIOPPsF 5ZxNql4lkuio8GJPJ6va+cYoxIstoSz+v7MecAMiaf5qqHjiiAEovtZDxUGvMaXVSbyL7qEMzcPU pnDb6egHq29JjHAZBbx2DTCxrzzuXzFaYqys0zmbazeE50SsabbfTMUCd0EIaTOMqALKc9g6BIr+ CpaGnsEV2ZruvEyeFJjgeVWskV7ECJbFjqRS5uVr21A/42KAeONCHcXyhVJ1CSBP+RctLuTZti/q NLw0Kv+yct9natSsfsfjajeOUn50bBCzfbEg0m/U+35CNGT0dzdxWT0FyX+kD1C0RidcJTHK04sX V0aPZBRTeZHnuOO/uZkCbnQXU5+XGBvVJuyMm2u0afSPuPE6m4wyesjHPUOHJ8GUKx0R3Plj19JN +JK3RQUjpOv9lxJpiDjBMauK5cEBJm+1Tvd4/J7sNgaK8/cZPMN5Hb83gsIM9Qa7aMcLpEYjzihl RdhI+QrFLfoCbyfhKS60tKZV0UNDF97DgzgGHO5h5+004m1cIE0gpAC2Z4WHSpz4mza//TC1kx4J yuca/8JsZtjvJGoYvsZdcGkv2bTeDlwOw4Fwe+PhQ= From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Thu, 22 Sep 2022 19:50:18 +0800 References: <90ea6785-b1bd-4da9-8ec3-9d3e35d0f4f9@EX-SZ059.tencent.com> To: FFmpeg development discussions and patches In-Reply-To: <90ea6785-b1bd-4da9-8ec3-9d3e35d0f4f9@EX-SZ059.tencent.com> X-OQ-MSGID: X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [FFmpeg-devel] [Internet][PATCH] fftools/ffmpeg_filter: configure min_hard_comp unconditionally X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Sep 17, 2022, at 12:30, Zhao Zhili wrote: > > From: Zhao Zhili > > There are two issues here. Firstly, the floating-point comparison > is always true. Seconly, the code depends on the default value of > min_hard_comp implicitly, which can be dangerous. > > Partially fixes ticket 9859. > --- > fftools/ffmpeg_filter.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c > index 7a5308425d..17928cea2c 100644 > --- a/fftools/ffmpeg_filter.c > +++ b/fftools/ffmpeg_filter.c > @@ -896,8 +896,7 @@ static int configure_input_audio_filter(FilterGraph *fg, InputFilter *ifilter, > char args[256] = {0}; > > av_strlcatf(args, sizeof(args), "async=%d", audio_sync_method); > - if (audio_drift_threshold != 0.1) > - av_strlcatf(args, sizeof(args), ":min_hard_comp=%f", audio_drift_threshold); > + av_strlcatf(args, sizeof(args), ":min_hard_comp=%f", audio_drift_threshold); > if (!fg->reconfiguration) > av_strlcatf(args, sizeof(args), ":first_pts=0"); > AUTO_INSERT_FILTER_INPUT("-async", "aresample", args); > -- Ping. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".