From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6DD0547EA6 for ; Mon, 30 Oct 2023 08:17:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D7CDE68CBF5; Mon, 30 Oct 2023 10:17:28 +0200 (EET) Received: from out162-62-58-211.mail.qq.com (out162-62-58-211.mail.qq.com [162.62.58.211]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 950A268CB96 for ; Mon, 30 Oct 2023 10:17:21 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1698653826; bh=LZVgRit/IxWWkZ781kwg3CaTWVqe6fWycpyiOB+nda4=; h=From:To:Cc:Subject:Date; b=z3bLY69I/7jrZ9jbmFEurX66IypuAnih1gqrev9Eu+Gs19dcN5uGibQQ3eGmJqYs2 1Ye5cdNeuVzNlyHtWBqHVKf9V4uz9A6shaahBhibmHvqTfjLCP4npILxfusPc9gCqx Z0ueIS0e11RvmmaqHfsFbvVXSg6YM7TMw15jqr54= Received: from ZHILIZHAO-MB1.tencent.com ([113.108.77.55]) by newxmesmtplogicsvrsza12-0.qq.com (NewEsmtp) with SMTP id 4449321B; Mon, 30 Oct 2023 16:17:04 +0800 X-QQ-mid: xmsmtpt1698653824tuwhjr0ar Message-ID: X-QQ-XMAILINFO: NvH2zBBgt3uTOjeXrXe+vyGya2/tdSRYCPk2T4XRHr78wbcIQE6W+DlyPkP9o3 lrs58Yc414E8oFDSZw69jt6DUxPLmBF4ab8vnYOKtEe6DOj6snbC5rfIcQnpb9hluPB6jAMF7YDx af5TJb24uEYKpz1ssPa8VvL1CQv5bjMbSKfOKSbs+oIGbzrXUMPUyLzisKJcCtq/2LNxB7etyLib oHo4OyVGuZtL3gbI/Lha3gV9jNI1HOiQgFYfZwhdxyv5ADqxCTwfFv4QqlVyi40RDI0nM64Qm99P T4uBtKTUvvvHgdxeBvAhn0snBMLnA3nInz71FzdFHREHcdHrCqK+zd/1Gmuv/ZkEuiL89h5dSn8Z V8dHQJi96v/hRzmR0GMC0JurvpmvxsvF+Xa+IyxhfweZsihpG2AvUVWAylxcBwxc0kf6imEAECxj fy1uILKFzwi+LRv+J3/6GMwI2RhR19O8nvOaeH/6rl34XmytQk761NLivsHhvRWvQQzpP1YGWP04 D0+Cdr/54E1Z0zb79Z+Esc3Cgu2/h451MztRDfp0XfybUv687cHOkqmLSHh8YnpDSp0ODn/qVkrM xGr6s6ZVyudyyMjvdPt5WR2hYH5d5kLE/9GSAGfIeWWVCg1VF7Cp3PocnN+jJjd9OJmAN0XyOXJZ M3arwiOabFCKGbh+xtgO1TFGqzIvi4XAvIzeLGci830mavfmUWvhYId13YBSvCUmwhCQ0SQN2pE2 JXlHa8e4pCHMIDJpgxVA9nK9HW1QJNmEyhgOaynZ6FEHLJ63APv6m5dTq96vrCmGH/PAVlQ+eOi7 06LTxYxRR1JW1U8wbR1jPFAbfXgcRhUN3X/l/6CzfIs7nMc3FJoGv8tDjK5FB6uu7QMsy6TgrJnz YW6xRaI8kRLYer9sWK0EXsYuHwMSeLr8V7+pS8LKmhNY++6vv0SJr3H81jmGbHKuAPzxMXaPxw0Y 3ELE9rJS/f2JYCbMdnbRn/X1jQ7YLAdTo/dzBSU18= X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Mon, 30 Oct 2023 16:17:03 +0800 X-OQ-MSGID: <20231030081703.16821-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: fix run on macOS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME is required on macOS, and VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR flag should be set. --- libavutil/hwcontext_vulkan.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 8481427b42..9fbf61ee70 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c @@ -405,7 +405,6 @@ typedef struct VulkanOptExtension { } VulkanOptExtension; static const VulkanOptExtension optional_instance_exts[] = { - /* Pointless, here avoid zero-sized structs */ { VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME, FF_VK_EXT_NO_FLAG }, }; @@ -784,6 +783,14 @@ static int create_instance(AVHWDeviceContext *ctx, AVDictionary *opts) inst_props.pNext = &validation_features; } + for (int i = 0; i < inst_props.enabledExtensionCount; i++) { + if (!strcmp(VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME, + inst_props.ppEnabledExtensionNames[i])) { + inst_props.flags |= VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR; + break; + } + } + /* Try to create the instance */ ret = vk->CreateInstance(&inst_props, hwctx->alloc, &hwctx->inst); -- 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".