* [FFmpeg-devel] [PATCH] tests/checkasm: Remove check on linux perf fd in uninit
@ 2024-06-12 17:35 Zhao Zhili
2024-06-13 2:04 ` Shiqi Zhu
0 siblings, 1 reply; 3+ messages in thread
From: Zhao Zhili @ 2024-06-12 17:35 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
From: Zhao Zhili <zhilizhao@tencent.com>
The check should be >= 0, not > 0. The check itself is redundant
since uninit only being called after init is success.
---
tests/checkasm/checkasm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
index 28237b4d25..bbcc90f91f 100644
--- a/tests/checkasm/checkasm.c
+++ b/tests/checkasm/checkasm.c
@@ -814,8 +814,7 @@ static int bench_init(void)
static void bench_uninit(void)
{
#if CONFIG_LINUX_PERF
- if (state.sysfd > 0)
- close(state.sysfd);
+ close(state.sysfd);
#endif
}
--
2.42.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] tests/checkasm: Remove check on linux perf fd in uninit
2024-06-12 17:35 [FFmpeg-devel] [PATCH] tests/checkasm: Remove check on linux perf fd in uninit Zhao Zhili
@ 2024-06-13 2:04 ` Shiqi Zhu
2024-06-13 12:21 ` Zhao Zhili
0 siblings, 1 reply; 3+ messages in thread
From: Shiqi Zhu @ 2024-06-13 2:04 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Thu, 13 Jun 2024 at 01:36, Zhao Zhili <quinkblack@foxmail.com> wrote:
>
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> The check should be >= 0, not > 0. The check itself is redundant
> since uninit only being called after init is success.
> ---
> tests/checkasm/checkasm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
> index 28237b4d25..bbcc90f91f 100644
> --- a/tests/checkasm/checkasm.c
> +++ b/tests/checkasm/checkasm.c
> @@ -814,8 +814,7 @@ static int bench_init(void)
> static void bench_uninit(void)
> {
> #if CONFIG_LINUX_PERF
> - if (state.sysfd > 0)
> - close(state.sysfd);
> + close(state.sysfd);
Is this better?
if (state.sysfd >= 0) {
close(state.sysfd);
state.sysfd = -1;
}
> #endif
> }
>
> --
> 2.42.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] tests/checkasm: Remove check on linux perf fd in uninit
2024-06-13 2:04 ` Shiqi Zhu
@ 2024-06-13 12:21 ` Zhao Zhili
0 siblings, 0 replies; 3+ messages in thread
From: Zhao Zhili @ 2024-06-13 12:21 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jun 13, 2024, at 10:04, Shiqi Zhu <hiccupzhu@gmail.com> wrote:
>
> On Thu, 13 Jun 2024 at 01:36, Zhao Zhili <quinkblack@foxmail.com <mailto:quinkblack@foxmail.com>> wrote:
>>
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> The check should be >= 0, not > 0. The check itself is redundant
>> since uninit only being called after init is success.
>> ---
>> tests/checkasm/checkasm.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
>> index 28237b4d25..bbcc90f91f 100644
>> --- a/tests/checkasm/checkasm.c
>> +++ b/tests/checkasm/checkasm.c
>> @@ -814,8 +814,7 @@ static int bench_init(void)
>> static void bench_uninit(void)
>> {
>> #if CONFIG_LINUX_PERF
>> - if (state.sysfd > 0)
>> - close(state.sysfd);
>> + close(state.sysfd);
>
> Is this better?
>
> if (state.sysfd >= 0) {
> close(state.sysfd);
> state.sysfd = -1;
> }
I don’t think there is a requirement on reentrancy in this case.
>
>> #endif
>> }
>>
>> --
>> 2.42.0
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-13 12:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-12 17:35 [FFmpeg-devel] [PATCH] tests/checkasm: Remove check on linux perf fd in uninit Zhao Zhili
2024-06-13 2:04 ` Shiqi Zhu
2024-06-13 12:21 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git