[FFmpeg-devel] [PATCH] avformat/movenc: editlist doesn't work with hybrid_fragmented

[FFmpeg-devel] [PATCH] avformat/movenc: editlist doesn't work with hybrid_fragmented

[Zhao Zhili]

From: Zhao Zhili <zhilizhao@tencent.com>

---
 libavformat/movenc.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index cd5b45f6fe..93af0723db 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -7781,6 +7781,11 @@ static int mov_init(AVFormatContext *s)
         !(mov->flags & FF_MOV_FLAG_NEGATIVE_CTS_OFFSETS))
         s->avoid_negative_ts = AVFMT_AVOID_NEG_TS_MAKE_ZERO;
 
+    if (mov->use_editlist && mov->flags & FF_MOV_FLAG_HYBRID_FRAGMENTED) {
+        av_log(s, AV_LOG_ERROR, "Setting both hybrid_fragmented and use_editlist is not supported.\n");
+        return AVERROR(EINVAL);
+    }
+
     /* Clear the omit_tfhd_offset flag if default_base_moof is set;
      * if the latter is set that's enough and omit_tfhd_offset doesn't
      * add anything extra on top of that. */
-- 
2.46.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/movenc: editlist doesn't work with hybrid_fragmented

[Martin Storsjö]

On Thu, 12 Jun 2025, Zhao Zhili wrote:

> From: Zhao Zhili <zhilizhao@tencent.com>
>
> ---
> libavformat/movenc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index cd5b45f6fe..93af0723db 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -7781,6 +7781,11 @@ static int mov_init(AVFormatContext *s)
>         !(mov->flags & FF_MOV_FLAG_NEGATIVE_CTS_OFFSETS))
>         s->avoid_negative_ts = AVFMT_AVOID_NEG_TS_MAKE_ZERO;
>
> +    if (mov->use_editlist && mov->flags & FF_MOV_FLAG_HYBRID_FRAGMENTED) {
> +        av_log(s, AV_LOG_ERROR, "Setting both hybrid_fragmented and use_editlist is not supported.\n");
> +        return AVERROR(EINVAL);
> +    }
> +

This is probably ok, but we recently added a similar case for another 
incompatible option (faststart?), it'd be nice to place the cases close 
together.

Can you describe why it doesn't work together? Offhand I don't see why it 
wouldn't work though.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/movenc: editlist doesn't work with hybrid_fragmented

[Zhao Zhili]

> On Jun 13, 2025, at 00:03, Martin Storsjö <martin@martin.st> wrote:
> 
> On Thu, 12 Jun 2025, Zhao Zhili wrote:
> 
>> From: Zhao Zhili <zhilizhao@tencent.com>
>> 
>> ---
>> libavformat/movenc.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>> 
>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>> index cd5b45f6fe..93af0723db 100644
>> --- a/libavformat/movenc.c
>> +++ b/libavformat/movenc.c
>> @@ -7781,6 +7781,11 @@ static int mov_init(AVFormatContext *s)
>>        !(mov->flags & FF_MOV_FLAG_NEGATIVE_CTS_OFFSETS))
>>        s->avoid_negative_ts = AVFMT_AVOID_NEG_TS_MAKE_ZERO;
>> 
>> +    if (mov->use_editlist && mov->flags & FF_MOV_FLAG_HYBRID_FRAGMENTED) {
>> +        av_log(s, AV_LOG_ERROR, "Setting both hybrid_fragmented and use_editlist is not supported.\n");
>> +        return AVERROR(EINVAL);
>> +    }
>> +
> 
> This is probably ok, but we recently added a similar case for another incompatible option (faststart?), it'd be nice to place the cases close together.
> 
> Can you describe why it doesn't work together? Offhand I don't see why it wouldn't work though.

The bug is related to segment_duration in editlist. It’s set to zero for fmp4, that doesn’t work for standard mp4.
I have figured out a patch, but editlist is too complex than I can handle. Please help review.

https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/345057.html

> 
> // Martin
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".