From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] aarch64: vvc: Consistently use # for immediate constants
Date: Tue, 23 Jul 2024 19:48:50 +0800
Message-ID: <tencent_DEA04ECDC2CFEA551427773896962D4D0C07@qq.com> (raw)
In-Reply-To: <20240723112821.2185107-2-martin@martin.st>
> On Jul 23, 2024, at 19:28, Martin Storsjö <martin@martin.st> wrote:
>
> ---
> libavcodec/aarch64/vvc/alf.S | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/libavcodec/aarch64/vvc/alf.S b/libavcodec/aarch64/vvc/alf.S
> index 828031cb90..eec193302a 100644
> --- a/libavcodec/aarch64/vvc/alf.S
> +++ b/libavcodec/aarch64/vvc/alf.S
> @@ -95,7 +95,7 @@
> .else
> ldr q5, [x5] // curr
> .endif
> - movi v20.4s, 64
> + movi v20.4s, #64
> cbz is_near_vb, 1f
> shl v20.4s, v20.4s, #3
> 1:
> @@ -220,7 +220,7 @@
> .else
> ldr d5, [x5] // curr
> .endif
> - movi v20.4s, 64
> + movi v20.4s, #64
> cbz is_near_vb, 1f
> shl v20.4s, v20.4s, #3
> 1:
> @@ -267,12 +267,12 @@ function ff_alf_filter_luma_kernel_8_neon, export=1
> endfunc
>
> function ff_alf_filter_luma_kernel_12_neon, export=1
> - mov w5, 4095
> + mov w5, #4095
> b 1f
> endfunc
>
> function ff_alf_filter_luma_kernel_10_neon, export=1
> - mov w5, 1023
> + mov w5, #1023
> 1:
> alf_filter_luma_kernel 2
> endfunc
> @@ -282,12 +282,12 @@ function ff_alf_filter_chroma_kernel_8_neon, export=1
> endfunc
>
> function ff_alf_filter_chroma_kernel_12_neon, export=1
> - mov w5, 4095
> + mov w5, #4095
> b 1f
> endfunc
>
> function ff_alf_filter_chroma_kernel_10_neon, export=1
> - mov w5, 1023
> + mov w5, #1023
> 1:
> alf_filter_chroma_kernel 2
> endfunc
> --
> 2.34.1
LGTM for the patch set. Thanks for the quick fix.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-07-23 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 11:28 [FFmpeg-devel] [PATCH 1/2] aarch64: vvc: Fix compilation of alf.S with MSVC 2022 17.7 and older Martin Storsjö
2024-07-23 11:28 ` [FFmpeg-devel] [PATCH 2/2] aarch64: vvc: Consistently use # for immediate constants Martin Storsjö
2024-07-23 11:48 ` Zhao Zhili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_DEA04ECDC2CFEA551427773896962D4D0C07@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git