* [FFmpeg-devel] [PATCH 1/1] add option in file.c: pkt_size to set max_packet_size
@ 2025-07-17 14:05 yangsen5 via ffmpeg-devel
2025-07-17 14:27 ` Gyan Doshi
2025-07-17 15:01 ` Zhao Zhili
0 siblings, 2 replies; 3+ messages in thread
From: yangsen5 via ffmpeg-devel @ 2025-07-17 14:05 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: 1441923451
From: yangsen5 <1441923451@qq.com>
Signed-off-by: yangsen5 <1441923451@qq.com>
---
libavformat/file.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/file.c b/libavformat/file.c
index 6a66040b65..8099a7e931 100644
--- a/libavformat/file.c
+++ b/libavformat/file.c
@@ -94,6 +94,7 @@ typedef struct FileContext {
int fd;
int trunc;
int blocksize;
+ int pkt_size;
int follow;
int seekable;
#if HAVE_DIRENT_H
@@ -106,6 +107,7 @@ static const AVOption file_options[] = {
{ "blocksize", "set I/O operation maximum block size", offsetof(FileContext, blocksize), AV_OPT_TYPE_INT, { .i64 = INT_MAX }, 1, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM },
{ "follow", "Follow a file as it is being written", offsetof(FileContext, follow), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, AV_OPT_FLAG_DECODING_PARAM },
{ "seekable", "Sets if the file is seekable", offsetof(FileContext, seekable), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 0, AV_OPT_FLAG_DECODING_PARAM | AV_OPT_FLAG_ENCODING_PARAM },
+ { "pkt_size", "Maximum file packet size", offsetof(FileContext, pkt_size), AV_OPT_TYPE_INT, { .i64 = 262144 }, -1, INT_MAX, AV_OPT_FLAG_DECODING_PARAM | AV_OPT_FLAG_ENCODING_PARAM },
{ NULL }
};
@@ -313,7 +315,7 @@ static int file_open(URLContext *h, const char *filename, int flags)
/* Buffer writes more than the default 32k to improve throughput especially
* with networked file systems */
if (!h->is_streamed && flags & AVIO_FLAG_WRITE)
- h->min_packet_size = h->max_packet_size = 262144;
+ h->min_packet_size = h->max_packet_size = c->pkt_size;
if (c->seekable >= 0)
h->is_streamed = !c->seekable;
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH 1/1] add option in file.c: pkt_size to set max_packet_size
2025-07-17 14:05 [FFmpeg-devel] [PATCH 1/1] add option in file.c: pkt_size to set max_packet_size yangsen5 via ffmpeg-devel
@ 2025-07-17 14:27 ` Gyan Doshi
2025-07-17 15:01 ` Zhao Zhili
1 sibling, 0 replies; 3+ messages in thread
From: Gyan Doshi @ 2025-07-17 14:27 UTC (permalink / raw)
To: ffmpeg-devel
On 2025-07-17 07:35 pm, yangsen5 via ffmpeg-devel wrote:
> From: yangsen5 <1441923451@qq.com>
>
> Signed-off-by: yangsen5 <1441923451@qq.com>
> ---
> libavformat/file.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/file.c b/libavformat/file.c
> index 6a66040b65..8099a7e931 100644
> --- a/libavformat/file.c
> +++ b/libavformat/file.c
> @@ -94,6 +94,7 @@ typedef struct FileContext {
> int fd;
> int trunc;
> int blocksize;
> + int pkt_size;
> int follow;
> int seekable;
> #if HAVE_DIRENT_H
> @@ -106,6 +107,7 @@ static const AVOption file_options[] = {
> { "blocksize", "set I/O operation maximum block size", offsetof(FileContext, blocksize), AV_OPT_TYPE_INT, { .i64 = INT_MAX }, 1, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM },
> { "follow", "Follow a file as it is being written", offsetof(FileContext, follow), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, AV_OPT_FLAG_DECODING_PARAM },
> { "seekable", "Sets if the file is seekable", offsetof(FileContext, seekable), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 0, AV_OPT_FLAG_DECODING_PARAM | AV_OPT_FLAG_ENCODING_PARAM },
> + { "pkt_size", "Maximum file packet size", offsetof(FileContext, pkt_size), AV_OPT_TYPE_INT, { .i64 = 262144 }, -1, INT_MAX, AV_OPT_FLAG_DECODING_PARAM | AV_OPT_FLAG_ENCODING_PARAM },
I see naive assignment of the value in avio*.c
What happens if someone sets the value to -1?
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH 1/1] add option in file.c: pkt_size to set max_packet_size
2025-07-17 14:05 [FFmpeg-devel] [PATCH 1/1] add option in file.c: pkt_size to set max_packet_size yangsen5 via ffmpeg-devel
2025-07-17 14:27 ` Gyan Doshi
@ 2025-07-17 15:01 ` Zhao Zhili
1 sibling, 0 replies; 3+ messages in thread
From: Zhao Zhili @ 2025-07-17 15:01 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: 1441923451
> On Jul 17, 2025, at 22:05, yangsen5 via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>
> From: yangsen5 <1441923451@qq.com>
>
> Signed-off-by: yangsen5 <1441923451@qq.com>
> ---
> libavformat/file.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/file.c b/libavformat/file.c
> index 6a66040b65..8099a7e931 100644
> --- a/libavformat/file.c
> +++ b/libavformat/file.c
> @@ -94,6 +94,7 @@ typedef struct FileContext {
> int fd;
> int trunc;
> int blocksize;
> + int pkt_size;
> int follow;
> int seekable;
> #if HAVE_DIRENT_H
> @@ -106,6 +107,7 @@ static const AVOption file_options[] = {
> { "blocksize", "set I/O operation maximum block size", offsetof(FileContext, blocksize), AV_OPT_TYPE_INT, { .i64 = INT_MAX }, 1, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM },
> { "follow", "Follow a file as it is being written", offsetof(FileContext, follow), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, AV_OPT_FLAG_DECODING_PARAM },
> { "seekable", "Sets if the file is seekable", offsetof(FileContext, seekable), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 0, AV_OPT_FLAG_DECODING_PARAM | AV_OPT_FLAG_ENCODING_PARAM },
> + { "pkt_size", "Maximum file packet size", offsetof(FileContext, pkt_size), AV_OPT_TYPE_INT, { .i64 = 262144 }, -1, INT_MAX, AV_OPT_FLAG_DECODING_PARAM | AV_OPT_FLAG_ENCODING_PARAM },
> { NULL }
> };
>
> @@ -313,7 +315,7 @@ static int file_open(URLContext *h, const char *filename, int flags)
> /* Buffer writes more than the default 32k to improve throughput especially
> * with networked file systems */
> if (!h->is_streamed && flags & AVIO_FLAG_WRITE)
> - h->min_packet_size = h->max_packet_size = 262144;
> + h->min_packet_size = h->max_packet_size = c->pkt_size;
What's the use case?
>
> if (c->seekable >= 0)
> h->is_streamed = !c->seekable;
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-17 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-17 14:05 [FFmpeg-devel] [PATCH 1/1] add option in file.c: pkt_size to set max_packet_size yangsen5 via ffmpeg-devel
2025-07-17 14:27 ` Gyan Doshi
2025-07-17 15:01 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git