Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zhao Zhili <quinkblack@foxmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Rick Kern <kernrj@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH 0/2] lavc/videotoolbox: use objpool instead of allocating memory each frame
Date: Sun, 20 Nov 2022 22:47:32 +0800
Message-ID: <tencent_D8B8BA965D4D2BA04ECDFDCF93D510271C07@qq.com> (raw)
In-Reply-To: <20221119213516.45148-1-kernrj@gmail.com>

On Sat, 2022-11-19 at 16:35 -0500, Rick Kern wrote:
> objpool was only being used in fftools, but it's useful in other
> components to reduce alloation time and memory fragmentation.
> 
> This patch set moves objpool to libavutil, so it can be used by
> lavc/videotoolboxenc for data being passed from input frames to
> output packets.
> 
> Rick Kern (2):
>   fftools/objpool: move objpool to libavutil
>   lavc/videotoolboxenc: use objectpool for encoder output information
> 
>  fftools/Makefile                 |  1 -
>  fftools/ffmpeg_mux.c             |  2 +-
>  fftools/sync_queue.c             |  2 +-
>  fftools/thread_queue.c           |  2 +-
>  fftools/thread_queue.h           |  2 +-
>  libavcodec/videotoolboxenc.c     | 80 ++++++++++++++++++++++++++++
> ----
>  libavutil/Makefile               |  2 +
>  {fftools => libavutil}/objpool.c |  0
>  {fftools => libavutil}/objpool.h |  0
>  9 files changed, 77 insertions(+), 14 deletions(-)
>  rename {fftools => libavutil}/objpool.c (100%)
>  rename {fftools => libavutil}/objpool.h (100%)
> 

libavutil.v specifies that only symbols with av prefix can be visible
outside of libavutil. So it doesn't work without rename those
functions.

Meanwhile I don't know if it's appropriate to add these functions to
libavutil.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-11-20 14:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19 21:35 Rick Kern
2022-11-19 21:35 ` [FFmpeg-devel] [PATCH 1/2] fftools/objpool: move objpool to libavutil Rick Kern
2022-11-19 21:35 ` [FFmpeg-devel] [PATCH 2/2] lavc/videotoolboxenc: use objectpool for encoder output information Rick Kern
2022-11-20 14:47 ` Zhao Zhili [this message]
2022-12-03 15:50   ` [FFmpeg-devel] [PATCH v2 0/2] lavc/videotoolbox: use objpool instead of allocating memory each frame Rick Kern
2022-12-03 15:50     ` [FFmpeg-devel] [PATCH v2 1/2] fftools/objpool: move objpool to libavutil Rick Kern
2022-12-03 15:50     ` [FFmpeg-devel] [PATCH v2 2/2] lavc/videotoolboxenc: use objectpool for encoder output information Rick Kern
2022-12-03 16:07     ` [FFmpeg-devel] [PATCH v3 0/2] lavc/videotoolbox: use objpool instead of allocating memory each frame Rick Kern
2022-12-03 16:07       ` [FFmpeg-devel] [PATCH v3 1/2] fftools/objpool: move objpool to libavutil Rick Kern
2022-12-03 17:29         ` Lynne
2022-12-03 16:07       ` [FFmpeg-devel] [PATCH v3 2/2] lavc/videotoolboxenc: use objectpool for encoder output information Rick Kern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_D8B8BA965D4D2BA04ECDFDCF93D510271C07@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=kernrj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git