From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 40CC64F30F for ; Mon, 16 Jun 2025 10:46:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1A7A468D99B; Mon, 16 Jun 2025 13:46:56 +0300 (EEST) Received: from xmbghk7.mail.qq.com (xmbghk7.mail.qq.com [43.163.128.47]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id C0A3D68D917 for ; Mon, 16 Jun 2025 13:46:47 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1750070804; bh=Xhl5yLwwZo+WToiflhkpFtVDTJQf9mREMQjWHKu+g6g=; h=From:Subject:Date:References:To:In-Reply-To; b=xp3larzXf2P0B+jPT/cVpVR4oCy9opuPTidgjdNg9ubQOCOlIF1cNQr10IFR0eEM9 9ygVddHLr7tFpW2b4kJbv4B34jE/PgbE75HfaTtkZT0fwD1zjL0Jmm7PPZ82gFA1DX 5FjpgQUYoR9Y23/ma9r3YucoUG0rT87dxikafO4M= Received: from smtpclient.apple ([119.147.10.242]) by newxmesmtplogicsvrsza36-0.qq.com (NewEsmtp) with SMTP id BAB94C3A; Mon, 16 Jun 2025 18:46:43 +0800 X-QQ-mid: xmsmtpt1750070803tdhcaky3s Message-ID: X-QQ-XMAILINFO: MwYHXMt4tQ2g+SNy+6pmeAK0wXZZa/KjHKvIp7EBx3OfSxNVktI//LsNpiUVym FSQevuGr1Och+49j4nyGpd0uvqE7CfQ+6L8hyb63GM5rD9Uen6ALTg2SixpXDWA/ciYrz7bfy+WJ 8rTyC5CECsKQ/RtlBQA0WU9EaP7RvQbbPfqSqcf7ZAvs1zVuBr+00ikNTtEbqI8zIfbs/1pBBX2v BN1w9T+ck84QAwtVHxODf2gyOK+69fsu9js0oaQ8QPinA4UtW9XZPgRMxomwr5GZLtAHY99FXUnu AxPFq0dtZtNrsNLZ7G8UCEt5RGUZOqq7v2OwwV6BngV2eXzmxocLxbJ4yx3ljWgrFvNFhFXvClIv gAMPYAxGF4rjKOcF85bIxxoNOUY7vtkdiZ5Kd72WIYk6c+wmd6zJ60smUwniDJ8+C8X2Y+dNNVfj iPSEmHTkUHFRtdF/1GRlgG7Re1AcXCCXU4QUNA6mP19jBaRPCIHKT0B+djh0n95h6qZ5ibWRPZu8 XxkRA+WsyZ2upGBc/XBnVhABJLeTEtg5wSDWJ+q4jTzbMZ13pdjo9weDYFM07hDCMstk1RJxWeWa y0YbL/3vh79wOwo6pMfTJTzrUhNM2OfciNeWUtCQNWZ7pFEuYwsZqReYwzcA4Dc6lwL/A1XLTC09 h0Dk3219LUjhHIUpnGzSn3FwGKZ7bWeRjBQG4hVykffSKL+PM20iAdz2ItQ3p4DBMJp+gfyH5GY2 O/ILyN5TyEnUQwDIfhjH8Lnn6ERQFYaOGUMk1RT2KHwzdBU3LdJEpRI5aFZ6xYHgfXvRAtV1vL62 4A8o8iV+rNZXeM/jEZhuyW4jz2WG9qrRoSuG3lEM4xaPFYKPjNwt+JMymwakGrn/Z7zbBLXmAm0H 80BJc7zVZeFwwkveqd1c/enR3wVuYkZcqDK0pITB/Yn5WjOc2YyiXypPjVdPF5qnFflHuCWSZcpT RGquqAKpau8DuCqZ5EomH6sLY2GJas2YTZrQPLNvkfIeSA8tZ0XXKo4gpPYjyXr1I5aTsLn6Y7Ct WndxT1OoOzeUWaMWyuQdF5GnZp/0MKMCLGg7bm/i9lVcDwUB5ZkE6pWKGHV4x3HMPCtE361/sFSM 3cviR1GDHLdndtq/PbxBgFAmvdjS0K2ZWurtsP X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= From: Zhao Zhili Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\)) Date: Mon, 16 Jun 2025 18:46:33 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: X-Mailer: Apple Mail (2.3826.500.181.1.5) Subject: Re: [FFmpeg-devel] [PATCH v4] checkasm/h264dsp: Fix stack overflow in check_idct_dequant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Please ignore this version. > On Jun 16, 2025, at 18:43, Zhao Zhili wrote: > > From: Zhao Zhili > > --- > tests/checkasm/h264dsp.c | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > > diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c > index f5f9650224..cdcb1f3aad 100644 > --- a/tests/checkasm/h264dsp.c > +++ b/tests/checkasm/h264dsp.c > @@ -328,8 +328,9 @@ static void check_idct_multiple(void) > static void check_idct_dequant(void) > { > static const int depths[5] = { 8, 9, 10, 12, 14 }; > - LOCAL_ALIGNED_16(int16_t, src, [16]); > - /* Ensure dst buffers are large enough to hold dctcoefs of all bit-depths. */ > + /* Ensure buffers are large enough to hold dctcoefs of all bit-depths. */ > + LOCAL_ALIGNED_16(int16_t, src_buf0, [16]); > + LOCAL_ALIGNED_16(int32_t, src_buf1, [16]); > LOCAL_ALIGNED_16(uint8_t, dst0, [16 * 16 * sizeof(int32_t)]); > LOCAL_ALIGNED_16(uint8_t, dst1, [16 * 16 * sizeof(int32_t)]); > int16_t *dst_ref = (int16_t *)dst0; > @@ -338,15 +339,23 @@ static void check_idct_dequant(void) > int bit_depth, i, qmul; > declare_func_emms(AV_CPU_FLAG_MMX | AV_CPU_FLAG_SSE2, void, int16_t *output, int16_t *input, int qmul); > > - for (int j = 0; j < 16; j++) > - src[j] = (rnd() % 512) - 256; > - > qmul = rnd() % 4096; > > for (i = 0; i < FF_ARRAY_ELEMS(depths); i++) { > + int16_t *src; > bit_depth = depths[i]; > ff_h264dsp_init(&h, bit_depth, 1); > > + if (bit_depth == 8) { > + src = src_buf0; > + for (size_t j = 0; j < 16; j++) > + src_buf0[0] = (rnd() % 512) - 256; > + } else { > + src = (int16_t *)src_buf1; > + for (size_t j = 0; j < 16; j++) > + src_buf1[1] = (rnd() % (1 << (bit_depth + 1))) - (1 << bit_depth); > + } > + > memset(dst0, 0, 16 * 16 * SIZEOF_COEF); > memset(dst1, 0, 16 * 16 * SIZEOF_COEF); > > -- > 2.25.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".