From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 48DE54E093 for ; Fri, 6 Jun 2025 11:28:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id AB2F268C60A; Fri, 6 Jun 2025 14:28:20 +0300 (EEST) Received: from out203-205-221-242.mail.qq.com (out203-205-221-242.mail.qq.com [203.205.221.242]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 6719B68C4B1 for ; Fri, 6 Jun 2025 14:28:11 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1749209287; bh=nAYwdQDUY4jZhhxZthZbMIkc45ppOt7yndYNw2tbdHo=; h=From:Subject:Date:References:To:In-Reply-To; b=eqo/QmzcdC0wDm2KJlIQL1ybhGzfpwE68YXiU9h5b5eG7QMgoIcoQa74hd30/EHEO DTtqWl5qhrb7oeU9KBRAHQctPeb9k4QKiAJXT7ZMwL2X7c2dOdp2Ai6jnWccOXzfDk KNB0/2SoDaNpvoK5rEHHLZ9FuqmSirjX1bVcMOBM= Received: from smtpclient.apple ([119.147.10.162]) by newxmesmtplogicsvrszc16-0.qq.com (NewEsmtp) with SMTP id 7060AAA8; Fri, 06 Jun 2025 19:28:06 +0800 X-QQ-mid: xmsmtpt1749209286tib0jrmm1 Message-ID: X-QQ-XMAILINFO: OCYbvBDBNb9r0BS4DSSua00umTSk+f5sbnsiLdumCR4ZyrD75Va0Omc5yFotJd 2Op2T0oHQIuJQvtd+mk35mzHhCf9gO+pObQifuYb8ezFZui/qDWdAKSO7Vx6ip4x2cXbFW90bMcK qp+GfxqtzvuZVluEjM7T79Znl0mLKgLJ1ZgGHH2ghlk712wbI3Et+jDMrZDbj6icJq+D1+et8TA/ Kj/tJDSUZ3WCyDqt+zyCuRYGJ5CO593hUzo4kKLEnuWj2uvTqHtU++OghKRk6GoGPbOIT8Z6OYWi oPj2Hofj7ZSe32IdlgLVFwi3Kjxv8cncvkKm18dJyZHb1JufwrqzeRGWvoLGkNpHoebZ7cBP4fAI z/7MLTfJRUGmxZVKT2XLI8NrPpo9fTYUHLKLONEasC5tNsytbaA6/3VJDc2+NtCESWkNnSFIhnmu UblwK5n9FraWyONm3HRSu3AmPiKdEdZWR+BLAUXRyu1Rcj1EFx0aVpHX90IiaRGRPj5y+0GzPHkL scjhPaAqQ6zDvf4asgPDQe539V3sYWEuzSTn4uHEcmPsRWgP8TG2K4E5Pc8uNbMtaek4tTIrYI/G sUbRr8e5sHtgnxN3Et7ewhB6QC8Y189VQCYrpIND4TcA1dUZ6q9AVxvpYKOH6syHCR62pEtjcUC5 AyktREDS2RMtkCzEiO2OsZvcC5b08MK+peQYqev2FklrDJd9aya3isQiVtbh4fB6x6qu84CYNklF puZB05fCDYsjKMnQ4u5MY0a/FQlCwMN+RFgDyLdh6cv5V4z2sUGM1IgKcchv8f1fX9gIoZ4G66in hD1yRUh6aEHaZt/b7LC1zMqtAW+5JZaRXMWJE3i+Rd0chozihYhgPa9H7biDfLed0ItEsKyTT4rt ig+oHagvZLyIa48iCemFZPWr4AOjkaLeDvqtvt7HrO5WGvys/KFNuFSTzvq+LUrmhhmOf2kSDRSh 82RsUziMJGtNjnlgiw1GjKFZyrwlSA2I6eXq2wEqJhUKlZgtwL3ixE4egPn7+19/BkNr0hgMCuXP GmssTbSpFQM8ZbGK/byZHc2XEgh8osPfX2Zhr875vUT7WkNvoF X-QQ-XMRINFO: NS+P29fieYNw95Bth2bWPxk= From: Zhao Zhili Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\)) Date: Fri, 6 Jun 2025 19:27:56 +0800 References: <20250606095109.GX29660@pb2> To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <6EEB0356-9E8F-4DDD-92C4-D9773FD9C0AB@foxmail.com> X-Mailer: Apple Mail (2.3826.500.181.1.5) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avformat/format: make experimental flag works for muxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jun 6, 2025, at 18:00, Kieran Kunhya via ffmpeg-devel wrote: > > On Fri, 6 Jun 2025, 10:51 Michael Niedermayer, > wrote: > >> On Fri, Jun 06, 2025 at 12:06:34AM +0800, Zhao Zhili wrote: >>> From: Zhao Zhili >>> >>> --- >>> libavformat/avformat.h | 3 +-- >>> libavformat/format.c | 2 ++ >>> 2 files changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/libavformat/avformat.h b/libavformat/avformat.h >>> index 2034d2aecc..6edcf11022 100644 >>> --- a/libavformat/avformat.h >>> +++ b/libavformat/avformat.h >>> @@ -470,8 +470,7 @@ typedef struct AVProbeData { >>> /** >>> * The muxer/demuxer is experimental and should be used with caution. >>> * >>> - * - demuxers: will not be selected automatically by probing, must be >> specified >>> - * explicitly. >>> + * Will not be selected automatically, must be specified explicitly. >>> */ >>> #define AVFMT_EXPERIMENTAL 0x0004 >>> #define AVFMT_SHOW_IDS 0x0008 /**< Show format stream IDs numbers. >> */ >>> diff --git a/libavformat/format.c b/libavformat/format.c >>> index 71018ea6ab..516925e7e4 100644 >>> --- a/libavformat/format.c >>> +++ b/libavformat/format.c >>> @@ -95,6 +95,8 @@ const AVOutputFormat *av_guess_format(const char >> *short_name, const char *filena >>> /* Find the proper file type. */ >>> score_max = 0; >>> while ((fmt = av_muxer_iterate(&i))) { >>> + if (fmt->flags & AVFMT_EXPERIMENTAL && !short_name) >>> + continue; >> >> what does AVFMT_EXPERIMENTAL mean for a muxer ? >> >> * a muxer could generate invalid, non compliant data >> * a muxer could be insecure and exploitable >> * a muxer could lack some feature (iam sure most muxers in most projects >> lack some feature) >> >> I think the first 2 are reasons to use this flag >> > > In the case of WebRTC it's 3. The user would expect it to work over the > internet (*Web*RTC after all) but it lacks NACK support so cannot recover > from any packet loss. > > Without the experimental flag FFmpeg will get support tickets raised and > claims it is inferior to other implementations. Users will not be aware of > the lack of missing feature otherwise. > > So it may be compliant on paper but it's not usable in the real world. I have sent v2 to fix doc as suggested by James. Any comments on the patch itself? https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344737.html > > Kieran > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".