From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0D7F94658C for ; Wed, 21 Jun 2023 09:40:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0C4B968C074; Wed, 21 Jun 2023 12:40:02 +0300 (EEST) Received: from out203-205-221-231.mail.qq.com (out203-205-221-231.mail.qq.com [203.205.221.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B626B680AA3 for ; Wed, 21 Jun 2023 12:39:54 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1687340391; bh=qIK7/C0Hk8nTSuMd+hDQyU3g9mWQUlojPkHbAuys6yo=; h=From:To:Cc:Subject:Date; b=ADoNfifn3Hqe77DzOT8jbZaWHq9GMZ7rclQ65HI+LvZM7lG2ooadAWRdr0zyDxbT1 /nw6o7MhXmUhUD6F4bDxO48MHE0n44XfHw0s8tBPvq3HL9cRdP/PyA8Dqu0ERc/Nr4 woWKNnw0vYiKVifwbdcSyA8IQ4zXUW5oiTn8EKnI= Received: from localhost.localdomain ([113.66.216.232]) by newxmesmtplogicsvrsza7-0.qq.com (NewEsmtp) with SMTP id 9A3898A8; Wed, 21 Jun 2023 17:38:35 +0800 X-QQ-mid: xmsmtpt1687340315takwexib9 Message-ID: X-QQ-XMAILINFO: OKkKo7I1HxIetpL6+M/cK/g0GeYHmB3G1cVvoVYmLZl6q7JL1JYI4KqGOq6htA 6/RQtRK31XM9Ddb4PfF1J/AJRCZ/eOIf6gZeAgXeFZ/RrA2B+/ed15i0czfFYnvPg5pvWW/1QjDM 4/7LOJz6P0IkTK/T4lG9/L8TZFs2ltqs90eSJxEnonceetXFgDJDkBgv23sOSMpB8IhN6fKFECtH 5UiEPfvgj2IMu1tgQCSS+UfdeHT+Vf9M1Hu9TlvmmTZ0P7tnQyjUtuNpOzMzg3SV+TDv2a7cPdzM 6g9+vv4NfJneKbEFLThal8YrHr0oHCN3d0Pt7BlGS4KWxdvIXBUu21eK8xQcAAvzLKzGzo0nOHOP QmlG3g+vJy91Yl8rdfO/fYsdT6TMXM/D5DtwjY4+wayv1XIkBv63YNYCuWeFaivoawFa0f50mWTX lzqE19N8SqFpXVQc+YBO5dh2STa0IygqCtu6yRV7M3XBUMmLrwhEeW/CHmKfQl5goynUi5o0HTdW l+YjKHKi0DQyxH2bawt+Y7XV9HQzICI5VEWSEBc3IDpeyVOKyfGRCCryfUZfcYgGAruB8EU+bBRW JjSDpM580RwA923xHpS3hDgoDsHyR1M5U58XoPhVvw/bblvE9YTlx/vTwkCXGADbhJhMrrHWImia pB7Xf71hJ3pPeS2+r5ZrUNcjfPW3W+1KZVAqAvp1djqztLaVbD1FCAAhQYxSxDE8aQ16FfJnX63q wNzlievxYV4RltGKhRpA8HaX2DOcdHHNvluj4D5ocsYg1Gb9A93zj289RTRgIi3yi/zlZarVg6Uz OwOdcxe3/bngnmkqggEkwhYWfb6AuqdcjhsxVTFdnOQLVJzRHCit81nQcmvnJb1PTEJCmDComa6s DLIdThmzuooeh7VRbOv6Rf/cpAwqSsWEmqVqbX+/jcxpKt7n6mpEF4CvCWenUscO+hJhW3sYVGgy Q2VVzFEsA9bkR0I4xc+FRgs5eUKh231XIkJB5q+baegXYNvyYpvbWV2gypSOu3 X-QQ-XMRINFO: OISvejVQwePVgzAjzmAtJeBjKpW55oNAGA== From: xufuji456 <839789740@qq.com> To: ffmpeg-devel@ffmpeg.org Date: Wed, 21 Jun 2023 17:38:33 +0800 X-OQ-MSGID: <20230621093833.59751-1-839789740@qq.com> X-Mailer: git-send-email 2.32.0 (Apple Git-132) MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: fix enabling low-latency encode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: xufuji456 <839789740@qq.com>, kernrj@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Use CFDictionarySetValue to enable low-latency encoding mode. Since the key is a type of "EncoderSpecification", instead of "CompressionProperty". Signed-off-by: xufuji456 <839789740@qq.com> --- libavcodec/videotoolboxenc.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index a313087876..6114351392 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -1536,17 +1536,6 @@ static int vtenc_create_encoder(AVCodecContext *avctx, } } - // low-latency mode: eliminate frame reordering, follow a one-in-one-out encoding mode - if ((avctx->flags & AV_CODEC_FLAG_LOW_DELAY) && avctx->codec_id == AV_CODEC_ID_H264) { - status = VTSessionSetProperty(vtctx->session, - compat_keys.kVTVideoEncoderSpecification_EnableLowLatencyRateControl, - kCFBooleanTrue); - - if (status) { - av_log(avctx, AV_LOG_ERROR, "Error setting low latency property: %d\n", status); - } - } - if ((avctx->flags & AV_CODEC_FLAG_CLOSED_GOP) != 0) { set_encoder_property_or_log(avctx, compat_keys.kVTCompressionPropertyKey_AllowOpenGOP, @@ -1690,6 +1679,13 @@ static int vtenc_configure_encoder(AVCodecContext *avctx) } #endif + // low-latency mode: eliminate frame reordering, follow a one-in-one-out encoding mode + if ((avctx->flags & AV_CODEC_FLAG_LOW_DELAY) && avctx->codec_id == AV_CODEC_ID_H264) { + CFDictionarySetValue(enc_info, + compat_keys.kVTVideoEncoderSpecification_EnableLowLatencyRateControl, + kCFBooleanTrue); + } + if (avctx->pix_fmt != AV_PIX_FMT_VIDEOTOOLBOX) { status = create_cv_pixel_buffer_info(avctx, &pixel_buffer_info); if (status) -- 2.32.0 (Apple Git-132) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".