From: xufuji456 <839789740@qq.com>
To: ffmpeg-devel@ffmpeg.org
Cc: xufuji456 <839789740@qq.com>, kernrj@gmail.com
Subject: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: fix enabling low-latency encode
Date: Wed, 21 Jun 2023 17:38:33 +0800
Message-ID: <tencent_D2650CA1866CD91838C63DF0A5ECA6BC9607@qq.com> (raw)
Use CFDictionarySetValue to enable low-latency encoding mode.
Since the key is a type of "EncoderSpecification", instead of "CompressionProperty".
Signed-off-by: xufuji456 <839789740@qq.com>
---
libavcodec/videotoolboxenc.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index a313087876..6114351392 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -1536,17 +1536,6 @@ static int vtenc_create_encoder(AVCodecContext *avctx,
}
}
- // low-latency mode: eliminate frame reordering, follow a one-in-one-out encoding mode
- if ((avctx->flags & AV_CODEC_FLAG_LOW_DELAY) && avctx->codec_id == AV_CODEC_ID_H264) {
- status = VTSessionSetProperty(vtctx->session,
- compat_keys.kVTVideoEncoderSpecification_EnableLowLatencyRateControl,
- kCFBooleanTrue);
-
- if (status) {
- av_log(avctx, AV_LOG_ERROR, "Error setting low latency property: %d\n", status);
- }
- }
-
if ((avctx->flags & AV_CODEC_FLAG_CLOSED_GOP) != 0) {
set_encoder_property_or_log(avctx,
compat_keys.kVTCompressionPropertyKey_AllowOpenGOP,
@@ -1690,6 +1679,13 @@ static int vtenc_configure_encoder(AVCodecContext *avctx)
}
#endif
+ // low-latency mode: eliminate frame reordering, follow a one-in-one-out encoding mode
+ if ((avctx->flags & AV_CODEC_FLAG_LOW_DELAY) && avctx->codec_id == AV_CODEC_ID_H264) {
+ CFDictionarySetValue(enc_info,
+ compat_keys.kVTVideoEncoderSpecification_EnableLowLatencyRateControl,
+ kCFBooleanTrue);
+ }
+
if (avctx->pix_fmt != AV_PIX_FMT_VIDEOTOOLBOX) {
status = create_cv_pixel_buffer_info(avctx, &pixel_buffer_info);
if (status)
--
2.32.0 (Apple Git-132)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2023-06-21 9:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_D2650CA1866CD91838C63DF0A5ECA6BC9607@qq.com \
--to=839789740@qq.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=kernrj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git