From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: mypopy@gmail.com Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libuavs3d: use output_reorder_delay as has_b_frames Date: Sat, 14 May 2022 11:39:15 +0800 Message-ID: <tencent_D1FD27C1EA8953045C714BB4261050A3E606@qq.com> (raw) In-Reply-To: <CACYjbn2F6mtyHP2BFyhp41YdrD775Z6c6-tEgDvR5_DXKi8NnQ@mail.gmail.com> > On May 14, 2022, at 9:04 AM, mypopy@gmail.com wrote: > > On Fri, May 13, 2022 at 5:41 PM Zhao Zhili <quinkblack@foxmail.com> wrote: >> >> has_b_frames is more than a bool, it's the size of the frame >> reordering buffer in the decoder. >> --- >> libavcodec/libuavs3d.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/libuavs3d.c b/libavcodec/libuavs3d.c >> index 23de4c8cd5..e911963a41 100644 >> --- a/libavcodec/libuavs3d.c >> +++ b/libavcodec/libuavs3d.c >> @@ -206,7 +206,7 @@ static int libuavs3d_decode_frame(AVCodecContext *avctx, AVFrame *frm, >> avctx->framerate.num = ff_avs3_frame_rate_tab[seqh->frame_rate_code].num; >> avctx->framerate.den = ff_avs3_frame_rate_tab[seqh->frame_rate_code].den; >> } >> - avctx->has_b_frames = !seqh->low_delay; >> + avctx->has_b_frames = seqh->output_reorder_delay; > The same case, AVS3 uses output_reorder_delay but AVS2 uses low_delay, > which is a bit strange Patch 3/3 explains why: it should be picture_reorder_delay, but it’s not available in libdavs2’s public API. >> avctx->pix_fmt = seqh->bit_depth_internal == 8 ? AV_PIX_FMT_YUV420P : AV_PIX_FMT_YUV420P10LE; >> ret = ff_set_dimensions(avctx, seqh->horizontal_size, seqh->vertical_size); >> if (ret < 0) >> -- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-14 3:39 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20220513094049.86179-1-quinkblack@foxmail.com> 2022-05-13 9:40 ` Zhao Zhili 2022-05-14 1:04 ` mypopy 2022-05-14 3:39 ` "zhilizhao(赵志立)" [this message] 2022-05-13 9:40 ` [FFmpeg-devel] [PATCH 3/3] avcodec/libdavs2: export has_b_frames info Zhao Zhili
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tencent_D1FD27C1EA8953045C714BB4261050A3E606@qq.com \ --to=quinkblack@foxmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ --cc=mypopy@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git