From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2DD1D47AB8 for ; Tue, 31 Oct 2023 08:40:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7BC7468CCEC; Tue, 31 Oct 2023 10:40:50 +0200 (EET) Received: from out203-205-221-233.mail.qq.com (out203-205-221-233.mail.qq.com [203.205.221.233]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3D5F768CC8E for ; Tue, 31 Oct 2023 10:40:41 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1698741637; bh=sH2n9eBx0XXunlZAIKmOowM7SnTtf6u1Xz+ug3i4RVs=; h=From:Subject:Date:References:To:In-Reply-To; b=AHfNSSioPniFvObHiIcgGpEtqbV5Sn56aZGGfKoQInyyDij9GImszbmhWpjG/8kgd RstNrk2QfiAZciHhiFxlG6n5xRbgmx4RLcSr2fAGdEXqISfr8i8J3h7JnPpDK1zaN1 f31MDFy7Kp693JkzxYRDMTIf1bAxl7OYViiQc01o= Received: from smtpclient.apple ([113.108.77.52]) by newxmesmtplogicsvrszc2-0.qq.com (NewEsmtp) with SMTP id A2416095; Tue, 31 Oct 2023 16:40:36 +0800 X-QQ-mid: xmsmtpt1698741636t5i5f9cg2 Message-ID: X-QQ-XMAILINFO: MB5+LsFw85No6PB52Z1ci/cxIy7P29LRDknBmY2qP16zwRYPmX/tIV2dlqnnMX 3v3fVNWF+QoXbdZfQB1kZroBdORhxduK+phuLN+bYFAP4DgXGvXJp1R983SHG0jLn5i7PKfUGaI7 OdBWISz9OOzx2B6p6nUWuzNxWW0G26f5NGCjp98v5FqCYx4ySc67Zy13Q5TvQB++lZGWLIiwUMfv vzHL5zi7OoZzEG6EIOnrziQnS7nAnEIIy8cAaMP+mwmHiRH9WjChjVHK7AVKi9LokCrcZLfotfeF bnqKO9OqsnxvqBZToSLu5UTF5S8d4XdEnqP3RASDsmP8XhSwuErYwQkxLXUf5Ye5aUmNRIDiz6qL v3lhC/6iujbkAMeSNEKhJ2tj82FtIX53vIF1SZi7HrKXoWW8VTYV1Z9amktvesP8t7Fgbhz4cNBK e/Y1bcdw2SVbQ8nZVRtcaNsphqsEYMwkuLgz4NytkKJmJfXRssQ0o2w02zBdZGWKL5dKfm56+roL c9ICWARNbxlNO8b7e2/7UGq/gmrVjCjg3ls6UJNII7xHzjBSgh/L7oTXZaKU9mZlCYhvlVIcylXf wkMFtQoDf5QcfGL3fXayLNGXlxq0d63xhlxTBY15GMD3JGmFcoFi8Tyn+G8N+xZUfbir6/20aYBV OJJ8kjB/AT3lEEKaD9ZrCXctdjGEz1rTKtfEsxCrWNvh86fV+ovuSFLHqn+fcBFfCZGR44ZLPl0R 223Yy7yTVQZrI+U7x16vkZp+eHHPXjWKb4hCDN1P1hA2J/0BTxt1R9QB2r9feHeLTUJGN8rZ+Bcd afOMiwt5Gob1y1ovCiDVSMKbJOB6fC0vMgeHyP9F6Vq+YqgFJhf5IJhAllS4fm0njKnkoZNn4LR8 mNQAAw+RWyEwM1W4Rtyuy9CJ/RyOgdL7J3oJM+Fodhgk2uWQBDs+4Gtk1ya/PSew/GDggnIXQPq2 DF4q19KmMsrJEBSN1s/Zlso8ITU+ikIyJeRMx62MpACjDbdX1/ig== X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU= From: Zhao Zhili Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.100.2.1.4\)) Date: Tue, 31 Oct 2023 16:40:26 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <765A3416-DEA6-4670-BBE0-604E86A16AD7@foxmail.com> X-Mailer: Apple Mail (2.3774.100.2.1.4) Subject: Re: [FFmpeg-devel] [PATCH v5] fftools/ffplay: add hwaccel decoding support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Oct 31, 2023, at 13:16, Lynne wrote: > > Oct 30, 2023, 18:35 by quinkblack@foxmail.com: > >> >> On 2023/10/31 01:05, Lynne wrote: >> >>> Oct 30, 2023, 17:05 by quinkblack@foxmail.com: >>> >>>> From: Zhao Zhili >>>> >>>> Add vulkan renderer via libplacebo. >>>> >>>> Simple usage: >>>> $ ffplay -hwaccel vulkan foo.mp4 >>>> >>>> Use cuda to vulkan map: >>>> $ ffplay -hwaccel cuda foo.mp4 >>>> >>>> Create vulkan instance by libplacebo, and enable debug: >>>> $ ffplay -hwaccel vulkan \ >>>> -vulkan_params create_by_placebo=1:debug=1 foo.mp4 >>>> --- >>>> v5: >>>> 1. add vulkan_params option. >>>> 2. vulkan instance can be create by hwcontext or libplacebo. >>>> >>>> v4: add more optional extensions >>>> v3: shared vulkan instance between libplacebo and hwcontext >>>> >>> You did it the other way. Instead of creating a device through libplacebo, >>> just create a Vulkan device via the hwcontext, and use it for libplacebo. >>> >> >> I have done both: >> >> 1. create vulkan device by hwcontext and import to placebo >> >> 2. create vulkan device by placebo and pass to hwcontext >> >> It's controlled by -vulkan_params create_by_placebo=1(0). Default is the first behavior. >> >> Did I miss something? >> > > Thanks, I overlooked that. Is there a reason for having a setting, and having that as the default? There is no particular reason for which one be the default. Let hwcontext create vulkan device is easy, but the code path has been tested by fftools/ffmpeg. The second choice covers another code path (av_hwdevice_ctx_alloc + av_hwdevice_ctx_init) and helps finding bugs. The macOS compatibility issue was found by the first choice. The memleak issue was found by the second. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".