Re: [FFmpeg-devel] [PATCH 6/7] avcodec: Make avcodec_decoder_subtitles2 accept a const AVPacket*

["\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>]

> On Mar 31, 2022, at 7:44 PM, Anton Khirnov <anton@khirnov.net> wrote:
> 
> Quoting Andreas Rheinhardt (2022-03-31 00:49:57)
>> From: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
>> 
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
>> ---
>> doc/APIchanges            | 3 +++
>> fftools/ffmpeg.c          | 4 ++--
>> fftools/ffprobe.c         | 2 +-
>> libavcodec/avcodec.h      | 3 +--
>> libavcodec/decode.c       | 9 ++++-----
>> libavcodec/version.h      | 2 +-
>> tools/target_dec_fuzzer.c | 4 ++--
>> 7 files changed, 14 insertions(+), 13 deletions(-)
>> 
>> diff --git a/doc/APIchanges b/doc/APIchanges
>> index 1a9f0a303e..326a3c721c 100644
>> --- a/doc/APIchanges
>> +++ b/doc/APIchanges
>> @@ -14,6 +14,9 @@ libavutil:     2021-04-27
>> 
>> API changes, most recent first:
>> 
>> +2022-03-30 - xxxxxxxxxx - lavc 59.26.100 - avcodec.h
>> +  avcodec_decode_subtitle2() now accepts const AVPacket*.
> 
> I vaguely recall C++ having a problem with such changes. Anybody
> remembers the details? Do we care?

const or not affects mangle and is part of the ABI for C++. Since
FFmpeg is in C and must be included within 'extern “C”’ for C++,
it has no effect. The patch LGTM.

> 
> -- 
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".