From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1A7304C07D for ; Wed, 5 Feb 2025 15:12:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 11A2B68B882; Wed, 5 Feb 2025 17:12:07 +0200 (EET) Received: from out162-62-57-137.mail.qq.com (out162-62-57-137.mail.qq.com [162.62.57.137]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 278E068B4A2 for ; Wed, 5 Feb 2025 17:11:58 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1738768315; bh=l7bks95V5jNFqOlDv/St/Ej5/voveQFDDeCOjrHf+tw=; h=From:To:Cc:Subject:Date; b=bO6RMn4qNFtxuESljmtvciZzFKeYmIgxa7NsPg2Q1IQFNDLlYrAtKwqCgwBDrDB29 IYRUuHnhpfnQW6j54vWZ5E+YME5ZiCjl3os54EvoUoYXsK94ZbWI2oBhedA/sAp7yW as5ZtTh50hFkRmvSr9znL3j5S33q4itHhON3vnb4= Received: from ZHILIZHAO-MB1.tencent.com ([240e:3b7:3277:36f0:544a:7de:c82a:2aa2]) by newxmesmtplogicsvrszc16-0.qq.com (NewEsmtp) with SMTP id 2A832EC3; Wed, 05 Feb 2025 23:10:40 +0800 X-QQ-mid: xmsmtpt1738768240tl3u76v00 Message-ID: X-QQ-XMAILINFO: M4rXzlpNAA0N5GYk6pyRkw5wjA5rpmS9SkHD2FvuitpZUnoH0bKAzu7Y1c456y NCkQO0BM+8h+gVHlpNp7Cm+YuH0PCjMqlWrrKeh28N9ZPnQ9Pdk5iz+eKeZ9TcoqQ0mKu0SuGXoZ eqfQdUD8ftbslE9S67gsTFxfrdSiLZ21ut9bZeTip7jhya8mwEns5JuF5UfkNl82fA/7bcvMHDoT DX5YHcy7Ad6KTUaZ0S+kKNE3arBWjFl4o2UDfi7r/z1yVDRk4TRMkT4uM6+b517LYV0In8QB9iD3 ae5vkM9+JbiUGxPQCgzIcnvJEiV/wpws9VcerbgI5AHTkgjK+V4MiTJ/imHfZ5FuUDqCBGlHlHjT v4SBmmb2at1Pg02IaWo+tKeHQoeu4PABeLUSJieuPmnErItzOqZquW2IHjp0a+jcyM2Z5I5GraOm ErbD6WyMRokjHq8TAX6pLbnx2K8Z4SdCyoworn8oH0IpPp7w0+MfiDZ70T//52fxawyTeEIE/XuK Rw/k+K8JoI48bt7J2jHHMQb5DK1gPk0zjlW1bhcNSWOmfsUc9sCCzxh6GqZdlUWau5EYnt4vazrt QvB/vxAgK4EYzq+B5unockm910HZHvI904am22VB+u04MVK5xokV5Dq9C2hCNctbQCEEoohrH66g Jsynw2V25rVZaN94TcmA2E1683G6iEAS2x+bzFHBH8x2aDjePpUk6BQT7dGZWAbMgkr0aqRrPvXX iOmEdJWJglD73PXS4ruPnlbBigJVOzrCxrKSgZ0WRuvSpRWwu+wnqYd1xlKd2jCZ/3v2Y8UijNI/ 0waNd96o8lS9G1WBZfZH+coJj3Qlq0Uzz7ZOmLvjoFwYmZ0845RQUqqrn9TweSt6gWwdxi3Xnd6B hj4z9+kmcL7a1BLloO+oo6/yL5gQ21TPcOZi9aXwDen+I2nptxlR0RkAuJ6wxF8vRa6H5gC2NjGH 8c4znVAY3Ke0hf6hGRWLvzxIR6mwUy X-QQ-XMRINFO: NS+P29fieYNw95Bth2bWPxk= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Wed, 5 Feb 2025 23:10:29 +0800 X-OQ-MSGID: <20250205151031.70604-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 1/3] avcodec/hevc: Rewrite scalability_mask_flag parse in decode_vps_ext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili Remove a for loop and make it easy to extend to support other types of scalability. Move ScalabilityMask to hevc header file so it can be used in hevc decoder. Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevc.h | 7 +++++++ libavcodec/hevc/ps.c | 33 +++++++++++++++------------------ libavcodec/hevc/ps.h | 2 ++ 3 files changed, 24 insertions(+), 18 deletions(-) diff --git a/libavcodec/hevc/hevc.h b/libavcodec/hevc/hevc.h index 8bd59142db..b2229fda40 100644 --- a/libavcodec/hevc/hevc.h +++ b/libavcodec/hevc/hevc.h @@ -162,5 +162,12 @@ enum { HEVC_MAX_PALETTE_PREDICTOR_SIZE = 128, }; +enum HEVCScalabilityMask { + HEVC_SCALABILITY_DEPTH = 1 << (15 - 0), + HEVC_SCALABILITY_MULTIVIEW = 1 << (15 - 1), + HEVC_SCALABILITY_SPATIAL = 1 << (15 - 2), + HEVC_SCALABILITY_AUXILIARY = 1 << (15 - 3), + HEVC_SCALABILITY_MASK_MAX = 0xFFFF, +}; #endif /* AVCODEC_HEVC_HEVC_H */ diff --git a/libavcodec/hevc/ps.c b/libavcodec/hevc/ps.c index 285084685b..861a6bb0a2 100644 --- a/libavcodec/hevc/ps.c +++ b/libavcodec/hevc/ps.c @@ -450,14 +450,6 @@ static void hevc_vps_free(AVRefStructOpaque opaque, void *obj) av_freep(&vps->data); } -enum ScalabilityMask { - HEVC_SCALABILITY_DEPTH = 0, - HEVC_SCALABILITY_MULTIVIEW = 1, - HEVC_SCALABILITY_SPATIAL = 2, - HEVC_SCALABILITY_AUXILIARY = 3, - HEVC_SCALABILITY_MASK_MAX = 15, -}; - enum DependencyType { HEVC_DEP_TYPE_SAMPLE = 0, HEVC_DEP_TYPE_MV = 1, @@ -532,17 +524,22 @@ static int decode_vps_ext(GetBitContext *gb, AVCodecContext *avctx, HEVCVPS *vps return AVERROR_INVALIDDATA; splitting_flag = get_bits1(gb); - num_scalability_types = 0; - for (int i = 0; i <= HEVC_SCALABILITY_MASK_MAX; i++) { - int scalability_mask_flag = get_bits1(gb); - if (scalability_mask_flag && (i != HEVC_SCALABILITY_MULTIVIEW)) { - av_log(avctx, AV_LOG_ERROR, "Scalability type %d not supported\n", i); - return AVERROR_PATCHWELCOME; - } - num_scalability_types += scalability_mask_flag; - } - if (num_scalability_types != 1) + vps->scalability_mask_flag = get_bits(gb, 16); + num_scalability_types = av_popcount(vps->scalability_mask_flag); + if (!num_scalability_types) { + av_log(avctx, AV_LOG_ERROR, "Missing scalability mask\n"); return AVERROR_INVALIDDATA; + } else if (num_scalability_types > 1) { + av_log(avctx, AV_LOG_ERROR, "Scalability number %d not supported\n", + num_scalability_types); + return AVERROR_PATCHWELCOME; + } + + if (!(vps->scalability_mask_flag & HEVC_SCALABILITY_MULTIVIEW)) { + av_log(avctx, AV_LOG_ERROR, "Scalability type %d not supported\n", + 15 - ff_ctz(vps->scalability_mask_flag)); + return AVERROR_PATCHWELCOME; + } if (!splitting_flag) dimension_id_len = get_bits(gb, 3) + 1; diff --git a/libavcodec/hevc/ps.h b/libavcodec/hevc/ps.h index 6f5b1f8755..d3465e3d27 100644 --- a/libavcodec/hevc/ps.h +++ b/libavcodec/hevc/ps.h @@ -205,6 +205,8 @@ typedef struct HEVCVPS { */ int nb_layers; + uint16_t scalability_mask_flag; + // LayerIdxInVps[nuh_layer_id], i.e. a mapping of nuh_layer_id to VPS layer // indices. Valid values are between 0 and HEVC_VPS_MAX_LAYERS. Entries for // unmapped values of nuh_layer_id are set to -1. -- 2.46.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".