Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Zhao Zhili" <quinkblack@foxmail.com>
To: "'FFmpeg development discussions and patches'" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [Internet]Re: [PATCH v2 5/7] avcodec/mediacodecenc: remove the strategy to create DTS
Date: Thu, 5 Jan 2023 00:12:56 +0800
Message-ID: <tencent_C87938F216314D0EA0774DA2CF92554C2707@qq.com> (raw)
In-Reply-To: <167284533601.4503.16792150834885869128@lain.khirnov.net>



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Anton Khirnov
> Sent: 2023年1月4日 23:16
> To: 'FFmpeg development discussions and patches' <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [Internet]Re: [PATCH v2 5/7] avcodec/mediacodecenc: remove the strategy to create DTS
> 
> Quoting Zhao Zhili (2023-01-04 15:46:52)
> >
> > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Tomas Härdin
> > > Sent: 2023年1月4日 22:00
> > > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [Internet]Re: [PATCH v2 5/7] avcodec/mediacodecenc: remove the strategy to create DTS
> > >
> > > ons 2023-01-04 klockan 19:31 +0800 skrev zhilizhao(赵志立):
> > > >
> > > > > On Jan 4, 2023, at 18:16, Anton Khirnov <anton@khirnov.net> wrote:
> > > > >
> > > > > Does this mean the encoder will produce packets with
> > > > > dts=AV_NOPTS_VALUE?
> > > >
> > > > MediaCodec should not encode B frames by default, so dts = pts by
> > > > default.
> > > > B frames can be enabled explicitly, in that case dts is
> > > > AV_NOPTS_VALUE.
> > > >
> > > > Android system’s MP4 muxer works very hard to recreate dts to
> > > > workaround
> > > > the limitation of MediaCodec API. It create ‘valid’ but almost
> > > > useless
> > > > files with a lot of jitters.
> > >
> > > Maybe we should disallow B-frames entirely until the MediaCodec API is
> > > fixed so as to not add to this mess?
> >
> > There are some valid usecases. For example, RTP works fine without DTS.
> > With some restriction or precondition, use can create DTS too. So I'd like
> > to keep the feature.
> 
> It is currently an API guarantee that all encoders return valid DTS
> values, so this encoder is behaving in an invalid way.

It's an reasonable requirement, but could you elaborate on where is the doc
explicitly says that?

> 
> If you want to keep B-frame functionality in this half-working state,
> I'd say it should be hidden behind something like -strict experimental.

Will do.

> 
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-01-04 16:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221207093122.553668-1-quinkblack@foxmail.com>
2022-12-07  9:31 ` [FFmpeg-devel] [PATCH v2 1/7] avcodec/mediacodecenc: make each encoder has its own option Zhao Zhili
2022-12-07  9:31 ` [FFmpeg-devel] [PATCH v2 2/7] avcodec/mediacodecenc: add bitrate_mode option Zhao Zhili
2022-12-07  9:31 ` [FFmpeg-devel] [PATCH v2 3/7] avcodec/mediacodecenc: add level option Zhao Zhili
2022-12-07  9:31 ` [FFmpeg-devel] [PATCH v2 4/7] avcodec/mediacodecenc: use bsf to handle crop Zhao Zhili
2022-12-09 17:22   ` [FFmpeg-devel] [PATCH v3 3/7] " Zhao Zhili
2022-12-12 15:27     ` Tomas Härdin
2022-12-13  3:20       ` "zhilizhao(赵志立)"
2022-12-14 17:08         ` Tomas Härdin
2022-12-14 17:19           ` Tomas Härdin
2022-12-14 17:37           ` Zhao Zhili
2022-12-14 17:43             ` Zhao Zhili
2022-12-20 18:24             ` Tomas Härdin
2022-12-21  7:17               ` "zhilizhao(赵志立)"
2022-12-21 10:06                 ` Tomas Härdin
2022-12-07  9:31 ` [FFmpeg-devel] [PATCH v2 5/7] avcodec/mediacodecenc: remove the strategy to create DTS Zhao Zhili
2022-12-12 15:28   ` Tomas Härdin
2022-12-13  2:55     ` "zhilizhao(赵志立)"
2022-12-14 17:31       ` Tomas Härdin
2023-01-04 10:16   ` Anton Khirnov
2023-01-04 11:31     ` [FFmpeg-devel] [Internet]Re: " "zhilizhao(赵志立)"
2023-01-04 13:59       ` Tomas Härdin
2023-01-04 14:46         ` Zhao Zhili
2023-01-04 15:15           ` Anton Khirnov
2023-01-04 16:12             ` Zhao Zhili [this message]
2023-01-05  8:07               ` Anton Khirnov
2022-12-07  9:31 ` [FFmpeg-devel] [PATCH v2 6/7] avcodec/mediacodecenc: add max-bframes support Zhao Zhili
2022-12-07  9:31 ` [FFmpeg-devel] [PATCH v2 7/7] avcodec/mediacodecenc: add pts_as_dts option Zhao Zhili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_C87938F216314D0EA0774DA2CF92554C2707@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git