From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avutil/hwcontext_videotoolbox: fix declaration-after-statement
Date: Thu, 17 Mar 2022 11:35:11 +0800
Message-ID: <tencent_C85E38CB960C4D56A06B4DC24FB2550C2707@qq.com> (raw)
In-Reply-To: <tencent_AA95B56869AA007968067DAAADAA39C5C00A@qq.com>
Feel free to drop this one, there is no real gain.
> On Mar 10, 2022, at 12:37 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
>
> ---
> libavutil/hwcontext_videotoolbox.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
> index e442a95007..13f77a7692 100644
> --- a/libavutil/hwcontext_videotoolbox.c
> +++ b/libavutil/hwcontext_videotoolbox.c
> @@ -161,11 +161,11 @@ uint32_t av_map_videotoolbox_format_from_pixfmt2(enum AVPixelFormat pix_fmt, boo
>
> static int vt_pool_alloc(AVHWFramesContext *ctx)
> {
> - VTFramesContext *fctx = ctx->internal->priv;
> CVReturn err;
> CFNumberRef w, h, pixfmt;
> uint32_t cv_pixfmt;
> CFMutableDictionaryRef attributes, iosurface_properties;
> + VTFramesContext *fctx = ctx->internal->priv;
>
> attributes = CFDictionaryCreateMutable(
> NULL,
> @@ -589,13 +589,13 @@ int av_vt_pixbuf_set_attachments(void *log_ctx,
> static int vt_map_frame(AVHWFramesContext *ctx, AVFrame *dst, const AVFrame *src,
> int flags)
> {
> - CVPixelBufferRef pixbuf = (CVPixelBufferRef)src->data[3];
> - OSType pixel_format = CVPixelBufferGetPixelFormatType(pixbuf);
> CVReturn err;
> - uint32_t map_flags = 0;
> int ret;
> int i;
> enum AVPixelFormat format;
> + CVPixelBufferRef pixbuf = (CVPixelBufferRef)src->data[3];
> + OSType pixel_format = CVPixelBufferGetPixelFormatType(pixbuf);
> + uint32_t map_flags = 0;
>
> format = av_map_videotoolbox_format_to_pixfmt(pixel_format);
> if (dst->format != format) {
> --
> 2.31.1
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-03-17 3:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220310043754.53262-1-quinkblack@foxmail.com>
2022-03-10 4:37 ` Zhao Zhili
2022-03-17 3:35 ` "zhilizhao(赵志立)" [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_C85E38CB960C4D56A06B4DC24FB2550C2707@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git