From: "徐福隆 via ffmpeg-devel" <ffmpeg-devel@ffmpeg.org>
To: =?gb18030?B?ZmZtcGVnLWRldmVs?= <ffmpeg-devel@ffmpeg.org>
Cc: =?gb18030?B?0Oy4o8Kh?= <839789740@qq.com>,
=?gb18030?B?dGhpbG8uYm9yZ21hbm4=?= <thilo.borgmann@mail.de>
Subject: Re: [FFmpeg-devel] [PATCH] avdevice/audiotoolbox: silence warning with new api
Date: Mon, 11 Dec 2023 23:28:33 +0800
Message-ID: <tencent_C73642CC306301386736655EE1F295D06106@qq.com> (raw)
In-Reply-To: <tencent_1EB2D5F20896E3840EB2FF6268185DC0D109@qq.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 2494 bytes --]
Hi, Thilo:
There is another patch that needs your review please.
Thanks
------------------ Original ------------------
From: "FFmpeg development discussions and patches" <ffmpeg-devel@ffmpeg.org>;
Date: Sat, Dec 9, 2023 08:50 PM
To: "ffmpeg-devel"<ffmpeg-devel@ffmpeg.org>;
Cc: "Ð츣¡"<839789740@qq.com>;
Subject: [FFmpeg-devel] [PATCH] avdevice/audiotoolbox: silence warning with new api
Building with macOS platform, the compiler has a warning: 'kAudioObjectPropertyElementMaster' is deprecated in macOS 12.0
Signed-off-by: xufuji456 <839789740@qq.com>
---
libavdevice/audiotoolbox.m | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libavdevice/audiotoolbox.m b/libavdevice/audiotoolbox.m
index aa49e2c992..ae91a2bc62 100644
--- a/libavdevice/audiotoolbox.m
+++ b/libavdevice/audiotoolbox.m
@@ -85,7 +85,11 @@ static av_cold int at_write_header(AVFormatContext *avctx)
AudioObjectPropertyAddress prop;
prop.mSelector = kAudioHardwarePropertyDevices;
prop.mScope = kAudioObjectPropertyScopeGlobal;
+#if !TARGET_OS_IPHONE && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1200
+ prop.mElement = kAudioObjectPropertyElementMain;
+#else
prop.mElement = kAudioObjectPropertyElementMaster;
+#endif
err = AudioObjectGetPropertyDataSize(kAudioObjectSystemObject, &prop, 0, NULL, &data_size);
if (check_status(avctx, &err, "AudioObjectGetPropertyDataSize devices"))
return AVERROR(EINVAL);
--
2.32.0 (Apple Git-132)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-11 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 12:50 xufuji456 via ffmpeg-devel
2023-12-11 15:28 ` 徐福隆 via ffmpeg-devel [this message]
2023-12-11 15:40 ` Thilo Borgmann via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_C73642CC306301386736655EE1F295D06106@qq.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=839789740@qq.com \
--cc=thilo.borgmann@mail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git