Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/libopenh264: Support full range videos in transcoding
Date: Thu, 20 Apr 2023 19:27:05 +0800
Message-ID: <tencent_C6A9533F1C488B8226271092A6CC67C4AA06@qq.com> (raw)
In-Reply-To: <20230418153351.2350679-1-mypopydev@gmail.com>



> On Apr 18, 2023, at 23:33, Jun Zhao <mypopydev@gmail.com> wrote:
> 
> Support full range videos when transcoding, enabled the
> YUVJ420P to avoid auto scale from YUVJ420P to YUV420P


According to "Towards YUVJ removal"
http://ffmpeg.org/pipermail/ffmpeg-devel/2022-December/304718.html

> So, as was discussed at the last meeting, we should move towards
removing YUVJ.

However, it looks like there is no much progress since then.

> 
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
> libavcodec/libopenh264enc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c
> index 8b4755f5ba..cccc11fbb7 100644
> --- a/libavcodec/libopenh264enc.c
> +++ b/libavcodec/libopenh264enc.c
> @@ -311,10 +311,12 @@ static av_cold int svc_encode_init(AVCodecContext *avctx)
> 
> #if OPENH264_VER_AT_LEAST(1, 6)
>     param.sSpatialLayers[0].uiVideoFormat = VF_UNDEF;
> +
>     if (avctx->color_range != AVCOL_RANGE_UNSPECIFIED) {
>         param.sSpatialLayers[0].bVideoSignalTypePresent = true;
>         param.sSpatialLayers[0].bFullRange = (avctx->color_range == AVCOL_RANGE_JPEG);
> -    }
> +    }  else if (avctx->pix_fmt == AV_PIX_FMT_YUVJ420P)
> +        param.sSpatialLayers[0].bFullRange = 1;
> 
>     if (avctx->colorspace != AVCOL_SPC_UNSPECIFIED      ||
>         avctx->color_primaries != AVCOL_PRI_UNSPECIFIED ||
> @@ -443,6 +445,7 @@ const FFCodec ff_libopenh264_encoder = {
>     .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP |
>                       FF_CODEC_CAP_AUTO_THREADS,
>     .p.pix_fmts     = (const enum AVPixelFormat[]){ AV_PIX_FMT_YUV420P,
> +                                                    AV_PIX_FMT_YUVJ420P,
>                                                     AV_PIX_FMT_NONE },
>     .defaults       = svc_enc_defaults,
>     .p.priv_class   = &class,
> -- 
> 2.25.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-04-20 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 15:33 Jun Zhao
2023-04-18 15:33 ` [FFmpeg-devel] [PATCH 2/2] lavc/libopenh264: refine the code Jun Zhao
2023-04-20 11:27 ` "zhilizhao(赵志立)" [this message]
2023-04-20 11:51   ` [FFmpeg-devel] [PATCH 1/2] lavc/libopenh264: Support full range videos in transcoding mypopy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_C6A9533F1C488B8226271092A6CC67C4AA06@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git