From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 239FF4F195 for ; Mon, 16 Jun 2025 10:43:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 21CFB68DBBC; Mon, 16 Jun 2025 13:43:50 +0300 (EEST) Received: from xmbghk7.mail.qq.com (xmbghk7.mail.qq.com [43.163.128.48]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id B96DF68A51F for ; Mon, 16 Jun 2025 13:43:42 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1750070613; bh=4m6TA1WOF0dX8scoEUYi3Q/lsBMmm81HbVCJXspPptg=; h=From:To:Cc:Subject:Date; b=JAlDQrJHvzNf72u458h9zIbSU3O/vK12n+oFeMo4KtCdupN6T+cRdYxK8e5U/Oq/C wwy6WnDNXd0scbsUktMPEXbyFHdsQrjgPseHPL7GOaeCu2cfaCaVzhOyL/cT+HhDUq fmmG+eEeT4P8D8jI+NjHFwSXhFtdH2JgavXWiUFE= Received: from localhost.localdomain ([119.147.10.242]) by newxmesmtplogicsvrszgpuc5-0.qq.com (NewEsmtp) with SMTP id AE0AB4F4; Mon, 16 Jun 2025 18:43:32 +0800 X-QQ-mid: xmsmtpt1750070612t3pf9sld5 Message-ID: X-QQ-XMAILINFO: Nq1uWKlIb9DMzP3XD5XpmzdRQBFW/cm3BnR33GmXWDcgynE8CBPfcWVaQOfyRs XyHYy+DmOw1ihsQ5+7i6OEUpZVKlCaAyQIjznVE1yvOoNKc895WVTTK/bowZ6zjnY2b5JZwxO5H6 R2S13tRI3DQMngtl2jtv9Yo1x5TS5s/Gdeg5bDpKcVynn23z4Kvj5pPMBiSgY37x3AQMHyX7oaC9 6Wv95ZwMuIxTeRilwepM7JLhDBQAYO16cfOb2+yNEROak7r/IG91XoaNhLXAP5zD39Myc96iP4nD G9LYKxE9TYOtMLfTm/xCHPTI9Ow5Ik7Pw9we4Z8jl+DZZ1utHhaqiAPhHXhPmGJIgGHIWHyOpHDl Vd/fTAYevgZbK9W9Ts+LHTxH2uamM1lVV4b4sags8xjEcDTHkfT1NYcf4aTpi8oqz21I+aX5rBbF ik/9SDD1FLX9VTojOTcw5B/K+6xewUMFr+07/JH/aXaj49G9wLzb3kLuNPaLY21H9/c9dlZzvaiC clB3p5WZQ7izf5aabJACcO3iv6M/MY6PWisNPJ1Rm/1FAtfRyTiAMWo/Ad+anVmwCsKOvqi5xgjI pVyCPKz7pPZasWkfQ9zms/NWj9/+IzmmiD4hEJrRlMSHqI3YY/YyggHnCdndcxHOEpbrKUGtOfVV 6pAZ5L+ckRGJIeOsuP7noEFt1sg8OWv3ccS0uhQ7kCcV6eefwWA8nvwvbFB9R2SBHjUJnxTZMqC1 YveV0jOdbtPxBpzKZmBulbV1ytXih1CCMeGK2KUpK56RzSkzN2WO6Zx6SKI5PhbLm5jnZpqlBScc 18wapgoWXSWLo6KxuHmq43MPGIOG+1sZtlCdbN0zucotxXM0WJBr8fdj+8tk8fJmk+9xTdQjE14c oNXjguzVr3OjtMxqty+OFaH78aXJwp6lCXfr3/uoBZHMSnEAY+fbX0xmmln2mML/Sn5cmykOSGc0 8R/vovXt1EngEnoolfa5YgLWjyt312m4cqPsE1MhTY/djujbGpeHx9dgtxSt766VTeYjWxiY77Mi w02ANp1w== X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Mon, 16 Jun 2025 18:43:34 +0800 X-OQ-MSGID: <20250616104334.301260-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v4] checkasm/h264dsp: Fix stack overflow in check_idct_dequant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili --- tests/checkasm/h264dsp.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c index f5f9650224..cdcb1f3aad 100644 --- a/tests/checkasm/h264dsp.c +++ b/tests/checkasm/h264dsp.c @@ -328,8 +328,9 @@ static void check_idct_multiple(void) static void check_idct_dequant(void) { static const int depths[5] = { 8, 9, 10, 12, 14 }; - LOCAL_ALIGNED_16(int16_t, src, [16]); - /* Ensure dst buffers are large enough to hold dctcoefs of all bit-depths. */ + /* Ensure buffers are large enough to hold dctcoefs of all bit-depths. */ + LOCAL_ALIGNED_16(int16_t, src_buf0, [16]); + LOCAL_ALIGNED_16(int32_t, src_buf1, [16]); LOCAL_ALIGNED_16(uint8_t, dst0, [16 * 16 * sizeof(int32_t)]); LOCAL_ALIGNED_16(uint8_t, dst1, [16 * 16 * sizeof(int32_t)]); int16_t *dst_ref = (int16_t *)dst0; @@ -338,15 +339,23 @@ static void check_idct_dequant(void) int bit_depth, i, qmul; declare_func_emms(AV_CPU_FLAG_MMX | AV_CPU_FLAG_SSE2, void, int16_t *output, int16_t *input, int qmul); - for (int j = 0; j < 16; j++) - src[j] = (rnd() % 512) - 256; - qmul = rnd() % 4096; for (i = 0; i < FF_ARRAY_ELEMS(depths); i++) { + int16_t *src; bit_depth = depths[i]; ff_h264dsp_init(&h, bit_depth, 1); + if (bit_depth == 8) { + src = src_buf0; + for (size_t j = 0; j < 16; j++) + src_buf0[0] = (rnd() % 512) - 256; + } else { + src = (int16_t *)src_buf1; + for (size_t j = 0; j < 16; j++) + src_buf1[1] = (rnd() % (1 << (bit_depth + 1))) - (1 << bit_depth); + } + memset(dst0, 0, 16 * 16 * SIZEOF_COEF); memset(dst1, 0, 16 * 16 * SIZEOF_COEF); -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".