From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 33DD440CB8 for ; Thu, 30 Dec 2021 06:57:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 63E2C68AC6D; Thu, 30 Dec 2021 08:57:05 +0200 (EET) Received: from out162-62-58-211.mail.qq.com (out162-62-58-211.mail.qq.com [162.62.58.211]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA41D68A7FD for ; Thu, 30 Dec 2021 08:56:58 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1640847414; bh=U7aoDlOP+FIIgBGCtzXe3/FKpC89t9sLU5aU/wjJ5VY=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=o1eoYdoHr1tGqv+czNCSWY+nEKeKfp63Smj8hVP7fxoll4jZksbLXwLFi/da/YD8M LFL9lSA4cm1f783+gNEu7+0N2oB/+RfQ4/QzvoYiHjznYjJfHbRM9rki3ajL6NlIcV UanGq2Amvab5QW97vxj+ubK0sbIjQWPM+oYuv5Sg= Received: from [192.168.255.10] ([113.108.77.70]) by newxmesmtplogicsvrsza9.qq.com (NewEsmtp) with SMTP id E359BCE1; Thu, 30 Dec 2021 14:56:53 +0800 X-QQ-mid: xmsmtpt1640847413tokdk5har Message-ID: X-QQ-XMAILINFO: NhDhJCJPIfnTSMjy50TpSptP0GGdZyQdwoBAH0kALhoCNtL8RRllr3rtcbd2+J IB6CPeYoZZF3qe7UmIqz8wns/+vcCGF6JRHHHSHptHRThmLvCtDZHHHtCMzmU/IjwcnNW8mPIjwX dm4VI94EMgZLdoJwP7JfF2+gvKj6tfUuKlrir9/cNNI/aGVmMr0ZLbVd49Uy0KCrpzkBerrcccwp V6z3ZQkIHy849r8UEmU1drrL6SLDA67gaWqqCr8nVhZ+NCfJHu2rigReUR75pts7/nFY9/QpTj/H DPOuWjBIPU3p+xshFlIp9GVNYA+wxmBf/6reGXkKYfDRWFDdHF0XoYhax2VkWzKQmX8h+w6e+9R7 yce6HmnixBwGa9BPh84lINhVsiYE8eiIIiRgC0ImTyV7olbfTIVUcpLdPWJeFx+Duz3mnmzFpKo/ rG/s4SqAiLEo1elPL5AtECrqtZ2qECVTgZe4uF7ZUbexTCTCi78MCl5DWoSPwSvUpmFezMq7kHTR W6QaMxQVlCcXX3VRL3fiEneDKFga0a2tZ3vyI5zZxIpsIMwbfKaxLiDJnBNj04f91tfUj9ANe28w MfJCYNUn9uq/wjRePui29HDtWEI02WUFw1cs44TfeU+wbl1f77jWCfYH+qAyH7kPvbN48rcHQJ0W y9xeUHEC5J/os3ajjU43+UNjG+hynESujsf1/1weqNqunD1VugNLqcal1a2Ho3fULBxFkljAq9IP kardTMrAixYbFtDg3Dd2EMDF87TJ+vjcYKl3rn/9h1TtVcnfUnGPWOPhqzIwW4P4+tDrWkVPMUap fHkT9FxCVUu+shsxtgiUjTRBnS/gt5u4NHeGfUT6QRq/ivdHmZXfvNKWPuksbd4TtucXVrsy1OjQ == Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= In-Reply-To: <20211230061145.20864-1-zozobreak@163.com> Date: Thu, 30 Dec 2021 14:56:55 +0800 X-OQ-MSGID: <8BA311B9-83C8-49A7-B501-13135BEA5441@foxmail.com> References: <20211230061145.20864-1-zozobreak@163.com> To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: zourenyi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Dec 30, 2021, at 2:11 PM, zourenyi wrote: > > since there is only debug log 'no picture ooo' when droping a picture, > I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps', > FFmpeg keeped silence about this error, so a warning log is much helpfull about this. > > Signed-off-by: zourenyi > --- > libavcodec/h264_slice.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c > index c21004df97..f347d8ee1a 100644 > --- a/libavcodec/h264_slice.c > +++ b/libavcodec/h264_slice.c > @@ -1533,7 +1533,13 @@ static int h264_select_output_frame(H264Context *h) > } > } > } else { > - av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : ""); > + if (out_of_order) { > + av_log(h->avctx, AV_LOG_WARNING, > + "drop picture(%c, %d/%" PRId64 ") because out of order\n", > + av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts); > + } else { > + av_log(h->avctx, AV_LOG_DEBUG, "no picture\n"); > + } > } The patch is about decoding, has nothing to do with libx264. Please fix the commit subject. > > return 0; > -- > 2.34.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".