From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4A95748889 for ; Tue, 19 Dec 2023 07:37:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EEB5968D03C; Tue, 19 Dec 2023 09:37:20 +0200 (EET) Received: from out203-205-251-82.mail.qq.com (out203-205-251-82.mail.qq.com [203.205.251.82]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA81068D03B for ; Tue, 19 Dec 2023 09:37:13 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1702971425; bh=dJHsUYNgvmmQ8BBEAOWOii8hktnRMCCUtXDjK33c20Y=; h=From:To:Cc:Subject:Date; b=H/4jdkNpjJRdgsaPXsL2epVkRx6dvENoWLQb690w66+c83ZLahtDkJLoJFmf+0RNG lV0wCR0BQtQgqrJnPZfHnif//qmdegNS+Wn7jYAZfdny5tN6v1t0oLpQysfEOtip6D VaEms9Wq+x1Xcm8ZnrqLTrPEsXNm+Wf4Q3pxC5z8= Received: from localhost.localdomain ([119.147.10.192]) by newxmesmtplogicsvrszc5-2.qq.com (NewEsmtp) with SMTP id 943A0EBC; Tue, 19 Dec 2023 15:37:03 +0800 X-QQ-mid: xmsmtpt1702971423t9oeizqsb Message-ID: X-QQ-XMAILINFO: OZZSS56D9fAjUvQnEwa4OdFQW5A0M6uIl1MfoP7hwAe/5dPoA7O/VXPHf37ENS XXTCkJmfL8vTzgXt/TVTImrPoVz7AmTqYnGKiyqQahhM7/peBxJ9AXOP3TGo1AX4y6ibpraAPTdS FMbqGMuK8ZkIRNujZAc43oU0xDI8jBVbhlbeL59NFfdZCtjoxc9fUcAr7whaQszhPIHjViPQuFoQ ep6UH0XX9nr6RwyhmVzRZUSQg+xDHLl0MvgbZsmHUxb8b80mYQ5lPEsbf3HqvPxSL5kqI4O+YKhg PBofddtW/ROsYCup6cH69ybx9u/RnpyQ94KvsA15uwjOhWI5BnPSmtfGAfNwwzWIchH3OXqfRPdF hmRY+JOr+4Tuu4LUB0Ic7tWp3K3cPIkt/jY40XjEi+YqdQXm9DurvFTe7KfZr6ZmwuANDrz1uL5U dPZEmxAC/N/RTn6vBiygXv1okq+ILscsQzha0m1ErV1Xlf1sUpU7byZm9lLzw7WTW02rbOZPxNHH Kejepg+fKMzfK3+9xh50+owdS6pWFnEud3us8nJv53tIb4OXvD9jG74cohh3rIVtHT3dHlmcCZ9o 9XEPN7er5nmqXxufmQ93FXbf0TErcxcsxLkRzQPILhbXkf6kaUJJp4ukb7jHWu+EJFMUG7+Dmcmb i7Id5EtzHHt1WntlCV9Zqmzaz96/NZMnLZsED0wGkLb/B8jz89QBAojcmZn/CnyHrv4SXqmiVvu8 lncKhCXz+9qNwIH2ft47slkshwdAifjhFbc3YeDqgDk5FbTPAJqzVjakQTr7IGuEXEUoyyq63VdG QgNnQTQ3goDVdxU8GIj4Sw2t8BMcPb8KvANS6hl+plA1Nnx7Pe8e7PUXFAhB7SeOwjhEYr+vluU8 jJFWUeo2rj3hZZscdM6QGN0xO8ky+9rrxLGZLsG6Is5iSWzndjdxq202WAsERUDdOLNOCQCOnYt7 RWiijHGvIcF4PRrBYik5g3jdo4+z3pe6tz5wAgoAAs/lsjm/xNig== X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Tue, 19 Dec 2023 23:37:01 +0800 X-OQ-MSGID: <20231219153703.450826-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 1/3] fftools/ffmpeg_filter: fix NULL pointer dereference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili In close_output(), a dummy frame is created with format NONE passed to enc_open(), which doesn't prepare for it. The NULL pointer dereference happened at av_pix_fmt_desc_get(enc_ctx->pix_fmt)->comp[0].depth. When fgt.graph is NULL, skip fg_output_frame() since there is nothing to output. frame #0: 0x0000005555bc34a4 ffmpeg_g`enc_open(opaque=0xb400007efe2db690, frame=0xb400007efe2d9f70) at ffmpeg_enc.c:235:44 frame #1: 0x0000005555bef250 ffmpeg_g`enc_open(sch=0xb400007dde2d4090, enc=0xb400007e4e2daad0, frame=0xb400007efe2d9f70) at ffmpeg_sched.c:1462:11 frame #2: 0x0000005555bee094 ffmpeg_g`send_to_enc(sch=0xb400007dde2d4090, enc=0xb400007e4e2daad0, frame=0xb400007efe2d9f70) at ffmpeg_sched.c:1571:19 frame #3: 0x0000005555bee01c ffmpeg_g`sch_filter_send(sch=0xb400007dde2d4090, fg_idx=0, out_idx=0, frame=0xb400007efe2d9f70) at ffmpeg_sched.c:2154:12 frame #4: 0x0000005555bcf124 ffmpeg_g`close_output(ofp=0xb400007e4e2d85b0, fgt=0x0000007d1790eb08) at ffmpeg_filter.c:2225:15 frame #5: 0x0000005555bcb000 ffmpeg_g`fg_output_frame(ofp=0xb400007e4e2d85b0, fgt=0x0000007d1790eb08, frame=0x0000000000000000) at ffmpeg_filter.c:2317:16 frame #6: 0x0000005555bc7e48 ffmpeg_g`filter_thread(arg=0xb400007eae2ce7a0) at ffmpeg_filter.c:2836:15 frame #7: 0x0000005555bee568 ffmpeg_g`task_wrapper(arg=0xb400007d8e2db478) at ffmpeg_sched.c:2200:21 --- fftools/ffmpeg_filter.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 9fc877b437..69a49a071e 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -2335,10 +2335,7 @@ static int fg_output_step(OutputFilterPriv *ofp, FilterGraphThread *fgt, ret = av_buffersink_get_frame_flags(filter, frame, AV_BUFFERSINK_FLAG_NO_REQUEST); - if (ret == AVERROR_EOF && !fgt->eof_out[ofp->index]) { - ret = fg_output_frame(ofp, fgt, NULL); - return (ret < 0) ? ret : 1; - } else if (ret == AVERROR(EAGAIN) || ret == AVERROR_EOF) { + if (ret == AVERROR(EAGAIN) || ret == AVERROR_EOF) { return 1; } else if (ret < 0) { av_log(fgp, AV_LOG_WARNING, @@ -2835,7 +2832,7 @@ read_frames: for (unsigned i = 0; i < fg->nb_outputs; i++) { OutputFilterPriv *ofp = ofp_from_ofilter(fg->outputs[i]); - if (fgt.eof_out[i]) + if (fgt.eof_out[i] || !fgt.graph) continue; ret = fg_output_frame(ofp, &fgt, NULL); -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".