From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 44AC24889D for ; Tue, 19 Dec 2023 11:32:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2C17E68D054; Tue, 19 Dec 2023 13:32:18 +0200 (EET) Received: from out203-205-221-242.mail.qq.com (out203-205-221-242.mail.qq.com [203.205.221.242]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 511D868CF2C for ; Tue, 19 Dec 2023 13:32:09 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1702985525; bh=lgvi+KXca6ln4RJEx3miIpmePMEL+OrdLeyYpqjWmL0=; h=From:Subject:Date:References:To:In-Reply-To; b=BNJB+//ixy+JRqgWZGIOdrxKSTl8iN/XOulVOxplVz9e4GUBbsQvYMeDwV3iKxEkx EqEx592fEl3osWVSLIHbVjpGI85wwREsRd0cVzX8qhEULl3bJxQyHSZZEO1G4XrCqj OpN+5GBMGAt6bVHTfi3Ub0Tw8imcXtqYxvl00IF0= Received: from smtpclient.apple ([113.108.77.62]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id 80430821; Tue, 19 Dec 2023 19:32:04 +0800 X-QQ-mid: xmsmtpt1702985524ts8olz9ml Message-ID: X-QQ-XMAILINFO: NwIPvWX4YDagxMvzdKXl+Vjlf1SzvgAyAY/e1vrpwO67p0MLKM41scCzwODvwk cixsS68CNH3G2I9FciPCELhch8VsK3aZCdmzC9qcwnR02esudJJfNiZbL8zisQjBOBGaEBOYe4I9 au4ECT5tydRsRZsCYBcrCaN00GapBnztaH7pBCBbsByp3/UpkRD7FYi+1o8y58ptdq8QFJrx8Ksf A69YystY4Gfr72Ax45hSBZ/DlGCKMnEn6VSdMH9gyKaWv7B4aKe8U4zZ0vFOu/4m+r3zHoF/7Rbv 3BPLUgQwlAxG6g7lrxHD+ncydpRVj6vaPdyI+D661AZVazgdK8EIb042n+izhCDroedjtOhBaSwx kIreCM2T5L1tV8UD41bFWlKolLkVM9fXBM8TFtfKsuNTee/GlLsosbpoy9dk91lwniCTd2SFfW+6 beAyKu/mRHQZYgR7N/6URi4oUyMd6cNdjS3FA7ePq7xlKB1cypR1iob86nciZaJzgRc/uJ7HWL67 nO2h1kLnFrmTMBA+yDVBA9gGgJigAVLX3uC0zHiopoMNK8n0a2dSyTLPZ9t8TKwpBjbzFBZMOLc0 rSadN1atzFULpv7GOQUPMCuoK5x5/No4i0EZXp0W9IoFpZSBFLEBcQmovAoZQvFvjlHR5GF+8kO4 I57kSdzY7Jzaw+B+C4KdmrBw22YpOjKsABYGnAmqkh4RhgB5aDR36g5xcnatHsQ/TQrshowpr9g+ IBpfGlPEMOLUx56bEqxb7Y+PrJcKAH8Y+JZLHwNPggLoW/lA+ej0VEbsXNXPtV0cbe1jW18P7XFm 4s611MGM7CJgjCPj1vNO6ACJ80824Exr/wLE3qFrh9H/zrwROpyJr8i8qeqJyGkGVBXn1Rgyw+0x XlrQ4Qv8U9QHRB/YcDJ9nuSvqK5ssVrt+JiGY+caNB7rsy2/z7Joj1OmS1+rHCyWZpcxMBPLKANG 8TZFNXh+WEZr6nKuy0w5qKrjw+75rlAKbkUskUaeUIU+9s/e/RN/h2nZk5ZLBgvO+tw5H7ADU= X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= From: Zhao Zhili Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Date: Tue, 19 Dec 2023 19:31:53 +0800 References: <170298193747.8914.3330104981111843352@lain.khirnov.net> To: FFmpeg development discussions and patches In-Reply-To: <170298193747.8914.3330104981111843352@lain.khirnov.net> X-OQ-MSGID: X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] fftools/ffmpeg_filter: fix NULL pointer dereference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Dec 19, 2023, at 18:32, Anton Khirnov wrote: > > Quoting Zhao Zhili (2023-12-19 16:37:01) >> From: Zhao Zhili >> >> In close_output(), a dummy frame is created with format NONE passed >> to enc_open(), which doesn't prepare for it. The NULL pointer >> dereference happened at >> av_pix_fmt_desc_get(enc_ctx->pix_fmt)->comp[0].depth. >> >> When fgt.graph is NULL, skip fg_output_frame() since there is >> nothing to output. >> >> frame #0: 0x0000005555bc34a4 ffmpeg_g`enc_open(opaque=0xb400007efe2db690, frame=0xb400007efe2d9f70) at ffmpeg_enc.c:235:44 >> frame #1: 0x0000005555bef250 ffmpeg_g`enc_open(sch=0xb400007dde2d4090, enc=0xb400007e4e2daad0, frame=0xb400007efe2d9f70) at ffmpeg_sched.c:1462:11 >> frame #2: 0x0000005555bee094 ffmpeg_g`send_to_enc(sch=0xb400007dde2d4090, enc=0xb400007e4e2daad0, frame=0xb400007efe2d9f70) at ffmpeg_sched.c:1571:19 >> frame #3: 0x0000005555bee01c ffmpeg_g`sch_filter_send(sch=0xb400007dde2d4090, fg_idx=0, out_idx=0, frame=0xb400007efe2d9f70) at ffmpeg_sched.c:2154:12 >> frame #4: 0x0000005555bcf124 ffmpeg_g`close_output(ofp=0xb400007e4e2d85b0, fgt=0x0000007d1790eb08) at ffmpeg_filter.c:2225:15 >> frame #5: 0x0000005555bcb000 ffmpeg_g`fg_output_frame(ofp=0xb400007e4e2d85b0, fgt=0x0000007d1790eb08, frame=0x0000000000000000) at ffmpeg_filter.c:2317:16 >> frame #6: 0x0000005555bc7e48 ffmpeg_g`filter_thread(arg=0xb400007eae2ce7a0) at ffmpeg_filter.c:2836:15 >> frame #7: 0x0000005555bee568 ffmpeg_g`task_wrapper(arg=0xb400007d8e2db478) at ffmpeg_sched.c:2200:21 >> --- >> fftools/ffmpeg_filter.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c >> index 9fc877b437..69a49a071e 100644 >> --- a/fftools/ffmpeg_filter.c >> +++ b/fftools/ffmpeg_filter.c >> @@ -2335,10 +2335,7 @@ static int fg_output_step(OutputFilterPriv *ofp, FilterGraphThread *fgt, >> >> ret = av_buffersink_get_frame_flags(filter, frame, >> AV_BUFFERSINK_FLAG_NO_REQUEST); >> - if (ret == AVERROR_EOF && !fgt->eof_out[ofp->index]) { >> - ret = fg_output_frame(ofp, fgt, NULL); >> - return (ret < 0) ? ret : 1; > > Why are you removing this block? I misread what you mean > I see, then seems to me it'd be better to run the final loop in > filter_thread() (the one calling fg_output_frame(, NULL)) only when > fgt->graph is non-NULL. That should fix this issue as well. These two flush operations can be combined into a single one, no? > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".